commit f91149e4a194621b08346ce3f110712a174e271c
author Georg Brandl <georg@python.org> Thu Jul 12 08:05:45 2007 +0000
committer Georg Brandl <georg@python.org> Thu Jul 12 08:05:45 2007 +0000
tree d21757aed1764d8da0871f29b39662ff333f48f8
parent c6057c7812ac3dd05a80255b4750f606a0f79f81

Patch #1752270, #1750931: complain if urllib2 add_handler called
without handler.

Lib/urllib2.py

diff --git a/Lib/urllib2.py b/Lib/urllib2.py
index 415c991..b2cec72 100644
--- a/Lib/urllib2.py
+++ b/Lib/urllib2.py
@@ -295,6 +295,10 @@
         self.process_request = {}
 
     def add_handler(self, handler):
+        if not hasattr(handler, "add_parent"):
+            raise TypeError("expected BaseHandler instance, got %r" %
+                            type(handler))
+
         added = False
         for meth in dir(handler):
             if meth in ["redirect_request", "do_open", "proxy_open"]: