commit fd24f9e51e80fb050e4239f6909eaff2d29ec30d
author Stefan Krah <skrah@bytereef.org> Mon Aug 20 11:04:24 2012 +0200
committer Stefan Krah <skrah@bytereef.org> Mon Aug 20 11:04:24 2012 +0200
tree 0b9630a2ee3f5252c781ca9fef9207578dbbd43e
parent e56bf97ef4283a877c459390516bb7385e8e4ec4

Issue #15732: Fix (constructed) crash in _PySequence_BytesToCharpArray().
Found by Coverity.

Objects/abstract.c

diff --git a/Objects/abstract.c b/Objects/abstract.c
index 2f887aa..299daf5 100644
--- a/Objects/abstract.c
+++ b/Objects/abstract.c
@@ -2736,6 +2736,11 @@
     for (i = 0; i < argc; ++i) {
         char *data;
         item = PySequence_GetItem(self, i);
+        if (item == NULL) {
+            /* NULL terminate before freeing. */
+            array[i] = NULL;
+            goto fail;
+        }
         data = PyBytes_AsString(item);
         if (data == NULL) {
             /* NULL terminate before freeing. */