commit fd52afd1928643a715202147b1ce5b0d130ec252
author Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Tue Sep 28 05:56:52 2021 -0700
committer GitHub <noreply@github.com> Tue Sep 28 05:56:52 2021 -0700
tree 28a65cc5dc175d275bf70eb3a1b036af453b37bd
parent acd46feff3c06d3f1d00ab850e530c519445a737

bpo-35606: Fix math.prod tests using 'start' as keyword parameter (GH-28595)

(cherry picked from commit 84975146a7ce64f1d50dcec8311b7f7188a5c962)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>

Modules/mathmodule.c

diff --git a/Modules/mathmodule.c b/Modules/mathmodule.c
index a2a2db2..16da008 100644
--- a/Modules/mathmodule.c
+++ b/Modules/mathmodule.c
@@ -3081,14 +3081,9 @@
     }
 
     if (result == NULL) {
-        result = PyLong_FromLong(1);
-        if (result == NULL) {
-            Py_DECREF(iter);
-            return NULL;
-        }
-    } else {
-        Py_INCREF(result);
+        result = _PyLong_GetOne();
     }
+    Py_INCREF(result);
 #ifndef SLOW_PROD
     /* Fast paths for integers keeping temporary products in C.
      * Assumes all inputs are the same type.
@@ -3104,7 +3099,7 @@
         }
         /* Loop over all the items in the iterable until we finish, we overflow
          * or we found a non integer element */
-        while(result == NULL) {
+        while (result == NULL) {
             item = PyIter_Next(iter);
             if (item == NULL) {
                 Py_DECREF(iter);