blob: 77d134939f8de9fc28882ea6c08f6fbe44a13e52 [file] [log] [blame]
Guido van Rossumd8faa362007-04-27 19:54:29 +00001/* Peephole optimizations for bytecode compiler. */
Thomas Wouters00ee7ba2006-08-21 19:07:27 +00002
3#include "Python.h"
4
5#include "Python-ast.h"
6#include "node.h"
Thomas Wouters00ee7ba2006-08-21 19:07:27 +00007#include "ast.h"
8#include "code.h"
Thomas Wouters00ee7ba2006-08-21 19:07:27 +00009#include "symtable.h"
10#include "opcode.h"
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030011#include "wordcode_helpers.h"
Thomas Wouters00ee7ba2006-08-21 19:07:27 +000012
Antoine Pitrouf95a1b32010-05-09 15:52:27 +000013#define UNCONDITIONAL_JUMP(op) (op==JUMP_ABSOLUTE || op==JUMP_FORWARD)
Jeffrey Yasskin9de7ec72009-02-25 02:25:04 +000014#define CONDITIONAL_JUMP(op) (op==POP_JUMP_IF_FALSE || op==POP_JUMP_IF_TRUE \
Antoine Pitrouf95a1b32010-05-09 15:52:27 +000015 || op==JUMP_IF_FALSE_OR_POP || op==JUMP_IF_TRUE_OR_POP)
Serhiy Storchaka520b7ae2018-02-22 23:33:30 +020016#define ABSOLUTE_JUMP(op) (op==JUMP_ABSOLUTE \
Antoine Pitrouf95a1b32010-05-09 15:52:27 +000017 || op==POP_JUMP_IF_FALSE || op==POP_JUMP_IF_TRUE \
18 || op==JUMP_IF_FALSE_OR_POP || op==JUMP_IF_TRUE_OR_POP)
Jeffrey Yasskin9de7ec72009-02-25 02:25:04 +000019#define JUMPS_ON_TRUE(op) (op==POP_JUMP_IF_TRUE || op==JUMP_IF_TRUE_OR_POP)
Serhiy Storchakaab874002016-09-11 13:48:15 +030020#define GETJUMPTGT(arr, i) (get_arg(arr, i) / sizeof(_Py_CODEUNIT) + \
21 (ABSOLUTE_JUMP(_Py_OPCODE(arr[i])) ? 0 : i+1))
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030022#define ISBASICBLOCK(blocks, start, end) \
23 (blocks[start]==blocks[end])
Thomas Wouters00ee7ba2006-08-21 19:07:27 +000024
Antoine Pitrou17b880a2011-03-11 17:27:02 +010025
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030026/* Scans back N consecutive LOAD_CONST instructions, skipping NOPs,
27 returns index of the Nth last's LOAD_CONST's EXTENDED_ARG prefix.
28 Callers are responsible to check CONST_STACK_LEN beforehand.
29*/
30static Py_ssize_t
Serhiy Storchakaab874002016-09-11 13:48:15 +030031lastn_const_start(const _Py_CODEUNIT *codestr, Py_ssize_t i, Py_ssize_t n)
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030032{
Serhiy Storchakaab874002016-09-11 13:48:15 +030033 assert(n > 0);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030034 for (;;) {
Serhiy Storchakaab874002016-09-11 13:48:15 +030035 i--;
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030036 assert(i >= 0);
Serhiy Storchakaab874002016-09-11 13:48:15 +030037 if (_Py_OPCODE(codestr[i]) == LOAD_CONST) {
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030038 if (!--n) {
Serhiy Storchakaab874002016-09-11 13:48:15 +030039 while (i > 0 && _Py_OPCODE(codestr[i-1]) == EXTENDED_ARG) {
40 i--;
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030041 }
42 return i;
43 }
44 }
45 else {
INADA Naoki87010e82017-12-18 15:52:54 +090046 assert(_Py_OPCODE(codestr[i]) == EXTENDED_ARG);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030047 }
48 }
49}
Antoine Pitrou17b880a2011-03-11 17:27:02 +010050
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030051/* Scans through EXTENDED ARGs, seeking the index of the effective opcode */
52static Py_ssize_t
Gregory P. Smith49fa4a92018-11-08 17:55:07 -080053find_op(const _Py_CODEUNIT *codestr, Py_ssize_t codelen, Py_ssize_t i)
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030054{
Gregory P. Smith49fa4a92018-11-08 17:55:07 -080055 while (i < codelen && _Py_OPCODE(codestr[i]) == EXTENDED_ARG) {
Serhiy Storchakaab874002016-09-11 13:48:15 +030056 i++;
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030057 }
58 return i;
59}
Antoine Pitrou17b880a2011-03-11 17:27:02 +010060
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030061/* Given the index of the effective opcode,
62 scan back to construct the oparg with EXTENDED_ARG */
63static unsigned int
Serhiy Storchakaab874002016-09-11 13:48:15 +030064get_arg(const _Py_CODEUNIT *codestr, Py_ssize_t i)
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030065{
Serhiy Storchakaab874002016-09-11 13:48:15 +030066 _Py_CODEUNIT word;
67 unsigned int oparg = _Py_OPARG(codestr[i]);
68 if (i >= 1 && _Py_OPCODE(word = codestr[i-1]) == EXTENDED_ARG) {
69 oparg |= _Py_OPARG(word) << 8;
70 if (i >= 2 && _Py_OPCODE(word = codestr[i-2]) == EXTENDED_ARG) {
71 oparg |= _Py_OPARG(word) << 16;
72 if (i >= 3 && _Py_OPCODE(word = codestr[i-3]) == EXTENDED_ARG) {
73 oparg |= _Py_OPARG(word) << 24;
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030074 }
75 }
76 }
77 return oparg;
78}
79
Serhiy Storchakaab874002016-09-11 13:48:15 +030080/* Fill the region with NOPs. */
81static void
82fill_nops(_Py_CODEUNIT *codestr, Py_ssize_t start, Py_ssize_t end)
83{
84 memset(codestr + start, NOP, (end - start) * sizeof(_Py_CODEUNIT));
85}
86
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030087/* Given the index of the effective opcode,
88 attempt to replace the argument, taking into account EXTENDED_ARG.
89 Returns -1 on failure, or the new op index on success */
90static Py_ssize_t
Serhiy Storchakaab874002016-09-11 13:48:15 +030091set_arg(_Py_CODEUNIT *codestr, Py_ssize_t i, unsigned int oparg)
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030092{
93 unsigned int curarg = get_arg(codestr, i);
94 int curilen, newilen;
95 if (curarg == oparg)
96 return i;
97 curilen = instrsize(curarg);
98 newilen = instrsize(oparg);
99 if (curilen < newilen) {
100 return -1;
101 }
102
Serhiy Storchakaab874002016-09-11 13:48:15 +0300103 write_op_arg(codestr + i + 1 - curilen, _Py_OPCODE(codestr[i]), oparg, newilen);
104 fill_nops(codestr, i + 1 - curilen + newilen, i + 1);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300105 return i-curilen+newilen;
106}
107
108/* Attempt to write op/arg at end of specified region of memory.
109 Preceding memory in the region is overwritten with NOPs.
110 Returns -1 on failure, op index on success */
111static Py_ssize_t
Serhiy Storchakaab874002016-09-11 13:48:15 +0300112copy_op_arg(_Py_CODEUNIT *codestr, Py_ssize_t i, unsigned char op,
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300113 unsigned int oparg, Py_ssize_t maxi)
114{
115 int ilen = instrsize(oparg);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300116 if (i + ilen > maxi) {
117 return -1;
118 }
119 write_op_arg(codestr + maxi - ilen, op, oparg, ilen);
Serhiy Storchakaab874002016-09-11 13:48:15 +0300120 fill_nops(codestr, i, maxi - ilen);
121 return maxi - 1;
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300122}
123
124/* Replace LOAD_CONST c1, LOAD_CONST c2 ... LOAD_CONST cn, BUILD_TUPLE n
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000125 with LOAD_CONST (c1, c2, ... cn).
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000126 The consts table must still be in list form so that the
127 new constant (c1, c2, ... cn) can be appended.
128 Called with codestr pointing to the first LOAD_CONST.
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000129*/
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300130static Py_ssize_t
Gregory P. Smith49fa4a92018-11-08 17:55:07 -0800131fold_tuple_on_constants(_Py_CODEUNIT *codestr, Py_ssize_t codelen,
132 Py_ssize_t c_start, Py_ssize_t opcode_end,
133 PyObject *consts, int n)
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000134{
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000135 /* Pre-conditions */
136 assert(PyList_CheckExact(consts));
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000137
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000138 /* Buildup new tuple of constants */
INADA Naoki87010e82017-12-18 15:52:54 +0900139 PyObject *newconst = PyTuple_New(n);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300140 if (newconst == NULL) {
141 return -1;
142 }
INADA Naoki87010e82017-12-18 15:52:54 +0900143
144 for (Py_ssize_t i = 0, pos = c_start; i < n; i++, pos++) {
145 assert(pos < opcode_end);
Gregory P. Smith49fa4a92018-11-08 17:55:07 -0800146 pos = find_op(codestr, codelen, pos);
INADA Naoki87010e82017-12-18 15:52:54 +0900147 assert(_Py_OPCODE(codestr[pos]) == LOAD_CONST);
148
149 unsigned int arg = get_arg(codestr, pos);
150 PyObject *constant = PyList_GET_ITEM(consts, arg);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000151 Py_INCREF(constant);
152 PyTuple_SET_ITEM(newconst, i, constant);
153 }
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000154
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000155 /* Append folded constant onto consts */
156 if (PyList_Append(consts, newconst)) {
157 Py_DECREF(newconst);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300158 return -1;
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000159 }
160 Py_DECREF(newconst);
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000161
INADA Naoki87010e82017-12-18 15:52:54 +0900162 return copy_op_arg(codestr, c_start, LOAD_CONST,
163 PyList_GET_SIZE(consts)-1, opcode_end);
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000164}
165
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000166static unsigned int *
Serhiy Storchakaab874002016-09-11 13:48:15 +0300167markblocks(_Py_CODEUNIT *code, Py_ssize_t len)
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000168{
Serhiy Storchaka1a1ff292015-02-16 13:28:22 +0200169 unsigned int *blocks = PyMem_New(unsigned int, len);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300170 int i, j, opcode, blockcnt = 0;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000171
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000172 if (blocks == NULL) {
173 PyErr_NoMemory();
174 return NULL;
175 }
176 memset(blocks, 0, len*sizeof(int));
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000177
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000178 /* Mark labels in the first pass */
Serhiy Storchakaab874002016-09-11 13:48:15 +0300179 for (i = 0; i < len; i++) {
180 opcode = _Py_OPCODE(code[i]);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000181 switch (opcode) {
182 case FOR_ITER:
183 case JUMP_FORWARD:
184 case JUMP_IF_FALSE_OR_POP:
185 case JUMP_IF_TRUE_OR_POP:
186 case POP_JUMP_IF_FALSE:
187 case POP_JUMP_IF_TRUE:
188 case JUMP_ABSOLUTE:
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000189 case SETUP_FINALLY:
190 case SETUP_WITH:
Yury Selivanov75445082015-05-11 22:57:16 -0400191 case SETUP_ASYNC_WITH:
Serhiy Storchaka520b7ae2018-02-22 23:33:30 +0200192 case CALL_FINALLY:
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000193 j = GETJUMPTGT(code, i);
Serhiy Storchakaab874002016-09-11 13:48:15 +0300194 assert(j < len);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000195 blocks[j] = 1;
196 break;
197 }
198 }
199 /* Build block numbers in the second pass */
Serhiy Storchakaab874002016-09-11 13:48:15 +0300200 for (i = 0; i < len; i++) {
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000201 blockcnt += blocks[i]; /* increment blockcnt over labels */
202 blocks[i] = blockcnt;
203 }
204 return blocks;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000205}
206
207/* Perform basic peephole optimizations to components of a code object.
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000208 The consts object should still be in list form to allow new constants
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000209 to be appended.
210
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300211 To keep the optimizer simple, it bails when the lineno table has complex
212 encoding for gaps >= 255.
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000213
Martin Panter46f50722016-05-26 05:35:26 +0000214 Optimizations are restricted to simple transformations occurring within a
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000215 single basic block. All transformations keep the code size the same or
216 smaller. For those that reduce size, the gaps are initially filled with
217 NOPs. Later those NOPs are removed and the jump addresses retargeted in
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300218 a single pass. */
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000219
220PyObject *
221PyCode_Optimize(PyObject *code, PyObject* consts, PyObject *names,
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100222 PyObject *lnotab_obj)
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000223{
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300224 Py_ssize_t h, i, nexti, op_start, codelen, tgt;
225 unsigned int j, nops;
226 unsigned char opcode, nextop;
Serhiy Storchakaab874002016-09-11 13:48:15 +0300227 _Py_CODEUNIT *codestr = NULL;
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100228 unsigned char *lnotab;
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300229 unsigned int cum_orig_offset, last_offset;
Serhiy Storchaka67559bf2015-02-16 21:13:24 +0200230 Py_ssize_t tabsiz;
INADA Naoki87010e82017-12-18 15:52:54 +0900231 // Count runs of consecutive LOAD_CONSTs
232 unsigned int cumlc = 0, lastlc = 0;
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000233 unsigned int *blocks = NULL;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000234
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000235 /* Bail out if an exception is set */
236 if (PyErr_Occurred())
237 goto exitError;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000238
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100239 /* Bypass optimization when the lnotab table is too complex */
240 assert(PyBytes_Check(lnotab_obj));
241 lnotab = (unsigned char*)PyBytes_AS_STRING(lnotab_obj);
242 tabsiz = PyBytes_GET_SIZE(lnotab_obj);
243 assert(tabsiz == 0 || Py_REFCNT(lnotab_obj) == 1);
244 if (memchr(lnotab, 255, tabsiz) != NULL) {
245 /* 255 value are used for multibyte bytecode instructions */
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000246 goto exitUnchanged;
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100247 }
248 /* Note: -128 and 127 special values for line number delta are ok,
249 the peephole optimizer doesn't modify line numbers. */
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000250
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000251 assert(PyBytes_Check(code));
252 codelen = PyBytes_GET_SIZE(code);
Serhiy Storchakaab874002016-09-11 13:48:15 +0300253 assert(codelen % sizeof(_Py_CODEUNIT) == 0);
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000254
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000255 /* Make a modifiable copy of the code string */
Serhiy Storchakaab874002016-09-11 13:48:15 +0300256 codestr = (_Py_CODEUNIT *)PyMem_Malloc(codelen);
Victor Stinnere0af3a82013-07-09 00:32:04 +0200257 if (codestr == NULL) {
258 PyErr_NoMemory();
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000259 goto exitError;
Victor Stinnere0af3a82013-07-09 00:32:04 +0200260 }
Serhiy Storchakaab874002016-09-11 13:48:15 +0300261 memcpy(codestr, PyBytes_AS_STRING(code), codelen);
262 codelen /= sizeof(_Py_CODEUNIT);
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000263
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000264 blocks = markblocks(codestr, codelen);
265 if (blocks == NULL)
266 goto exitError;
267 assert(PyList_Check(consts));
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000268
Gregory P. Smith49fa4a92018-11-08 17:55:07 -0800269 for (i=find_op(codestr, codelen, 0) ; i<codelen ; i=nexti) {
Serhiy Storchakaa1e9ab32016-09-11 15:19:12 +0300270 opcode = _Py_OPCODE(codestr[i]);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300271 op_start = i;
Serhiy Storchakaab874002016-09-11 13:48:15 +0300272 while (op_start >= 1 && _Py_OPCODE(codestr[op_start-1]) == EXTENDED_ARG) {
273 op_start--;
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300274 }
275
Serhiy Storchakaab874002016-09-11 13:48:15 +0300276 nexti = i + 1;
277 while (nexti < codelen && _Py_OPCODE(codestr[nexti]) == EXTENDED_ARG)
278 nexti++;
279 nextop = nexti < codelen ? _Py_OPCODE(codestr[nexti]) : 0;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000280
INADA Naoki87010e82017-12-18 15:52:54 +0900281 lastlc = cumlc;
282 cumlc = 0;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000283
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000284 switch (opcode) {
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000285 /* Skip over LOAD_CONST trueconst
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300286 POP_JUMP_IF_FALSE xx. This improves
287 "while 1" performance. */
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000288 case LOAD_CONST:
INADA Naoki87010e82017-12-18 15:52:54 +0900289 cumlc = lastlc + 1;
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300290 if (nextop != POP_JUMP_IF_FALSE ||
Serhiy Storchakaab874002016-09-11 13:48:15 +0300291 !ISBASICBLOCK(blocks, op_start, i + 1) ||
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300292 !PyObject_IsTrue(PyList_GET_ITEM(consts, get_arg(codestr, i))))
293 break;
Serhiy Storchakaab874002016-09-11 13:48:15 +0300294 fill_nops(codestr, op_start, nexti + 1);
INADA Naoki87010e82017-12-18 15:52:54 +0900295 cumlc = 0;
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000296 break;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000297
Serhiy Storchaka15a87282017-12-14 20:24:31 +0200298 /* Try to fold tuples of constants.
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000299 Skip over BUILD_SEQN 1 UNPACK_SEQN 1.
300 Replace BUILD_SEQN 2 UNPACK_SEQN 2 with ROT2.
301 Replace BUILD_SEQN 3 UNPACK_SEQN 3 with ROT3 ROT2. */
302 case BUILD_TUPLE:
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300303 j = get_arg(codestr, i);
INADA Naoki87010e82017-12-18 15:52:54 +0900304 if (j > 0 && lastlc >= j) {
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300305 h = lastn_const_start(codestr, op_start, j);
Serhiy Storchaka15a87282017-12-14 20:24:31 +0200306 if (ISBASICBLOCK(blocks, h, op_start)) {
Gregory P. Smith49fa4a92018-11-08 17:55:07 -0800307 h = fold_tuple_on_constants(codestr, codelen,
308 h, i+1, consts, j);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300309 break;
310 }
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000311 }
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300312 if (nextop != UNPACK_SEQUENCE ||
Serhiy Storchakaab874002016-09-11 13:48:15 +0300313 !ISBASICBLOCK(blocks, op_start, i + 1) ||
Serhiy Storchaka15a87282017-12-14 20:24:31 +0200314 j != get_arg(codestr, nexti))
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300315 break;
316 if (j < 2) {
Serhiy Storchakaab874002016-09-11 13:48:15 +0300317 fill_nops(codestr, op_start, nexti + 1);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000318 } else if (j == 2) {
Serhiy Storchakaab874002016-09-11 13:48:15 +0300319 codestr[op_start] = PACKOPARG(ROT_TWO, 0);
320 fill_nops(codestr, op_start + 1, nexti + 1);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000321 } else if (j == 3) {
Serhiy Storchakaab874002016-09-11 13:48:15 +0300322 codestr[op_start] = PACKOPARG(ROT_THREE, 0);
323 codestr[op_start + 1] = PACKOPARG(ROT_TWO, 0);
324 fill_nops(codestr, op_start + 2, nexti + 1);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000325 }
326 break;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000327
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000328 /* Simplify conditional jump to conditional jump where the
329 result of the first test implies the success of a similar
330 test or the failure of the opposite test.
331 Arises in code like:
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000332 "a and b or c"
333 "(a and b) and c"
Serhiy Storchaka36ff4512017-06-11 14:50:22 +0300334 "(a or b) or c"
335 "(a or b) and c"
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000336 x:JUMP_IF_FALSE_OR_POP y y:JUMP_IF_FALSE_OR_POP z
337 --> x:JUMP_IF_FALSE_OR_POP z
338 x:JUMP_IF_FALSE_OR_POP y y:JUMP_IF_TRUE_OR_POP z
Serhiy Storchakaab874002016-09-11 13:48:15 +0300339 --> x:POP_JUMP_IF_FALSE y+1
340 where y+1 is the instruction following the second test.
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000341 */
342 case JUMP_IF_FALSE_OR_POP:
343 case JUMP_IF_TRUE_OR_POP:
Serhiy Storchakaab874002016-09-11 13:48:15 +0300344 h = get_arg(codestr, i) / sizeof(_Py_CODEUNIT);
Gregory P. Smith49fa4a92018-11-08 17:55:07 -0800345 tgt = find_op(codestr, codelen, h);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300346
Serhiy Storchakaab874002016-09-11 13:48:15 +0300347 j = _Py_OPCODE(codestr[tgt]);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000348 if (CONDITIONAL_JUMP(j)) {
Raymond Hettinger08eef3f2016-08-07 20:20:33 -0700349 /* NOTE: all possible jumps here are absolute. */
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000350 if (JUMPS_ON_TRUE(j) == JUMPS_ON_TRUE(opcode)) {
Raymond Hettinger08eef3f2016-08-07 20:20:33 -0700351 /* The second jump will be taken iff the first is.
352 The current opcode inherits its target's
353 stack effect */
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300354 h = set_arg(codestr, i, get_arg(codestr, tgt));
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000355 } else {
Raymond Hettinger08eef3f2016-08-07 20:20:33 -0700356 /* The second jump is not taken if the first is (so
357 jump past it), and all conditional jumps pop their
358 argument when they're not taken (so change the
359 first jump to pop its argument when it's taken). */
Serhiy Storchakaab874002016-09-11 13:48:15 +0300360 h = set_arg(codestr, i, (tgt + 1) * sizeof(_Py_CODEUNIT));
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300361 j = opcode == JUMP_IF_TRUE_OR_POP ?
362 POP_JUMP_IF_TRUE : POP_JUMP_IF_FALSE;
363 }
364
365 if (h >= 0) {
366 nexti = h;
Serhiy Storchakaab874002016-09-11 13:48:15 +0300367 codestr[nexti] = PACKOPARG(j, _Py_OPARG(codestr[nexti]));
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300368 break;
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000369 }
370 }
371 /* Intentional fallthrough */
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000372
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000373 /* Replace jumps to unconditional jumps */
374 case POP_JUMP_IF_FALSE:
375 case POP_JUMP_IF_TRUE:
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000376 case JUMP_FORWARD:
377 case JUMP_ABSOLUTE:
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300378 h = GETJUMPTGT(codestr, i);
Gregory P. Smith49fa4a92018-11-08 17:55:07 -0800379 tgt = find_op(codestr, codelen, h);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000380 /* Replace JUMP_* to a RETURN into just a RETURN */
381 if (UNCONDITIONAL_JUMP(opcode) &&
Serhiy Storchakaab874002016-09-11 13:48:15 +0300382 _Py_OPCODE(codestr[tgt]) == RETURN_VALUE) {
383 codestr[op_start] = PACKOPARG(RETURN_VALUE, 0);
384 fill_nops(codestr, op_start + 1, i + 1);
385 } else if (UNCONDITIONAL_JUMP(_Py_OPCODE(codestr[tgt]))) {
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300386 j = GETJUMPTGT(codestr, tgt);
387 if (opcode == JUMP_FORWARD) { /* JMP_ABS can go backwards */
388 opcode = JUMP_ABSOLUTE;
389 } else if (!ABSOLUTE_JUMP(opcode)) {
Serhiy Storchakaab874002016-09-11 13:48:15 +0300390 if ((Py_ssize_t)j < i + 1) {
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300391 break; /* No backward relative jumps */
392 }
Serhiy Storchakaab874002016-09-11 13:48:15 +0300393 j -= i + 1; /* Calc relative jump addr */
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300394 }
Serhiy Storchakaab874002016-09-11 13:48:15 +0300395 j *= sizeof(_Py_CODEUNIT);
396 copy_op_arg(codestr, op_start, opcode, j, i + 1);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000397 }
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000398 break;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000399
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300400 /* Remove unreachable ops after RETURN */
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000401 case RETURN_VALUE:
Serhiy Storchakaab874002016-09-11 13:48:15 +0300402 h = i + 1;
Serhiy Storchaka520b7ae2018-02-22 23:33:30 +0200403 /* END_FINALLY should be kept since it denotes the end of
404 the 'finally' block in frame_setlineno() in frameobject.c.
405 SETUP_FINALLY should be kept for balancing.
406 */
407 while (h < codelen && ISBASICBLOCK(blocks, i, h) &&
408 _Py_OPCODE(codestr[h]) != END_FINALLY)
409 {
410 if (_Py_OPCODE(codestr[h]) == SETUP_FINALLY) {
411 while (h > i + 1 &&
412 _Py_OPCODE(codestr[h - 1]) == EXTENDED_ARG)
413 {
414 h--;
415 }
416 break;
417 }
Serhiy Storchakaab874002016-09-11 13:48:15 +0300418 h++;
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300419 }
Serhiy Storchakaab874002016-09-11 13:48:15 +0300420 if (h > i + 1) {
Serhiy Storchaka7db3c482016-10-25 09:30:43 +0300421 fill_nops(codestr, i + 1, h);
Gregory P. Smith49fa4a92018-11-08 17:55:07 -0800422 nexti = find_op(codestr, codelen, h);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300423 }
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000424 break;
425 }
426 }
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000427
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100428 /* Fixup lnotab */
Serhiy Storchakaab874002016-09-11 13:48:15 +0300429 for (i = 0, nops = 0; i < codelen; i++) {
Serhiy Storchaka67559bf2015-02-16 21:13:24 +0200430 assert(i - nops <= INT_MAX);
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100431 /* original code offset => new code offset */
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300432 blocks[i] = i - nops;
Serhiy Storchakaab874002016-09-11 13:48:15 +0300433 if (_Py_OPCODE(codestr[i]) == NOP)
434 nops++;
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000435 }
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100436 cum_orig_offset = 0;
437 last_offset = 0;
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000438 for (i=0 ; i < tabsiz ; i+=2) {
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300439 unsigned int offset_delta, new_offset;
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100440 cum_orig_offset += lnotab[i];
Serhiy Storchakaab874002016-09-11 13:48:15 +0300441 assert(cum_orig_offset % sizeof(_Py_CODEUNIT) == 0);
442 new_offset = blocks[cum_orig_offset / sizeof(_Py_CODEUNIT)] *
443 sizeof(_Py_CODEUNIT);
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100444 offset_delta = new_offset - last_offset;
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300445 assert(offset_delta <= 255);
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100446 lnotab[i] = (unsigned char)offset_delta;
447 last_offset = new_offset;
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000448 }
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000449
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000450 /* Remove NOPs and fixup jump targets */
Serhiy Storchakaab874002016-09-11 13:48:15 +0300451 for (op_start = i = h = 0; i < codelen; i++, op_start = i) {
452 j = _Py_OPARG(codestr[i]);
453 while (_Py_OPCODE(codestr[i]) == EXTENDED_ARG) {
454 i++;
455 j = j<<8 | _Py_OPARG(codestr[i]);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300456 }
Serhiy Storchakaab874002016-09-11 13:48:15 +0300457 opcode = _Py_OPCODE(codestr[i]);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000458 switch (opcode) {
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300459 case NOP:continue;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000460
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000461 case JUMP_ABSOLUTE:
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000462 case POP_JUMP_IF_FALSE:
463 case POP_JUMP_IF_TRUE:
464 case JUMP_IF_FALSE_OR_POP:
465 case JUMP_IF_TRUE_OR_POP:
Serhiy Storchakaab874002016-09-11 13:48:15 +0300466 j = blocks[j / sizeof(_Py_CODEUNIT)] * sizeof(_Py_CODEUNIT);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000467 break;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000468
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000469 case FOR_ITER:
470 case JUMP_FORWARD:
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000471 case SETUP_FINALLY:
472 case SETUP_WITH:
Yury Selivanov75445082015-05-11 22:57:16 -0400473 case SETUP_ASYNC_WITH:
Serhiy Storchaka520b7ae2018-02-22 23:33:30 +0200474 case CALL_FINALLY:
Serhiy Storchakaab874002016-09-11 13:48:15 +0300475 j = blocks[j / sizeof(_Py_CODEUNIT) + i + 1] - blocks[i] - 1;
476 j *= sizeof(_Py_CODEUNIT);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000477 break;
478 }
Serhiy Storchakaab874002016-09-11 13:48:15 +0300479 nexti = i - op_start + 1;
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300480 if (instrsize(j) > nexti)
481 goto exitUnchanged;
482 /* If instrsize(j) < nexti, we'll emit EXTENDED_ARG 0 */
483 write_op_arg(codestr + h, opcode, j, nexti);
484 h += nexti;
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000485 }
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300486 assert(h + (Py_ssize_t)nops == codelen);
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000487
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000488 PyMem_Free(blocks);
Serhiy Storchakaab874002016-09-11 13:48:15 +0300489 code = PyBytes_FromStringAndSize((char *)codestr, h * sizeof(_Py_CODEUNIT));
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300490 PyMem_Free(codestr);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000491 return code;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000492
Alexandre Vassalotti6f828182009-07-21 02:51:58 +0000493 exitError:
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000494 code = NULL;
Alexandre Vassalotti6f828182009-07-21 02:51:58 +0000495
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000496 exitUnchanged:
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300497 Py_XINCREF(code);
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100498 PyMem_Free(blocks);
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100499 PyMem_Free(codestr);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000500 return code;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000501}