Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 1 | # Copyright 2006 Google, Inc. All Rights Reserved. |
| 2 | # Licensed to PSF under a Contributor Agreement. |
| 3 | |
| 4 | """Refactoring framework. |
| 5 | |
| 6 | Used as a main program, this can refactor any number of files and/or |
| 7 | recursively descend down directories. Imported as a module, this |
| 8 | provides infrastructure to write your own refactoring tool. |
| 9 | """ |
| 10 | |
| 11 | __author__ = "Guido van Rossum <guido@python.org>" |
| 12 | |
| 13 | |
| 14 | # Python imports |
| 15 | import os |
| 16 | import sys |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 17 | import logging |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 18 | import operator |
Benjamin Peterson | 3059b00 | 2009-07-20 16:42:03 +0000 | [diff] [blame] | 19 | import collections |
| 20 | import io |
Christian Heimes | 81ee3ef | 2008-05-04 22:42:01 +0000 | [diff] [blame] | 21 | from itertools import chain |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 22 | |
| 23 | # Local imports |
Benjamin Peterson | 3059b00 | 2009-07-20 16:42:03 +0000 | [diff] [blame] | 24 | from .pgen2 import driver, tokenize, token |
Benjamin Peterson | f37eb3a | 2010-10-14 23:00:04 +0000 | [diff] [blame] | 25 | from .fixer_util import find_root |
Benjamin Peterson | 2c3ac6b | 2009-06-11 23:47:38 +0000 | [diff] [blame] | 26 | from . import pytree, pygram |
Benjamin Peterson | f37eb3a | 2010-10-14 23:00:04 +0000 | [diff] [blame] | 27 | from . import btm_matcher as bm |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 28 | |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 29 | |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 30 | def get_all_fix_names(fixer_pkg, remove_prefix=True): |
| 31 | """Return a sorted list of all available fix names in the given package.""" |
| 32 | pkg = __import__(fixer_pkg, [], [], ["*"]) |
| 33 | fixer_dir = os.path.dirname(pkg.__file__) |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 34 | fix_names = [] |
Benjamin Peterson | 206e307 | 2008-10-19 14:07:49 +0000 | [diff] [blame] | 35 | for name in sorted(os.listdir(fixer_dir)): |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 36 | if name.startswith("fix_") and name.endswith(".py"): |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 37 | if remove_prefix: |
| 38 | name = name[4:] |
| 39 | fix_names.append(name[:-3]) |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 40 | return fix_names |
| 41 | |
Benjamin Peterson | 3059b00 | 2009-07-20 16:42:03 +0000 | [diff] [blame] | 42 | |
| 43 | class _EveryNode(Exception): |
| 44 | pass |
| 45 | |
| 46 | |
| 47 | def _get_head_types(pat): |
Christian Heimes | 81ee3ef | 2008-05-04 22:42:01 +0000 | [diff] [blame] | 48 | """ Accepts a pytree Pattern Node and returns a set |
| 49 | of the pattern types which will match first. """ |
| 50 | |
| 51 | if isinstance(pat, (pytree.NodePattern, pytree.LeafPattern)): |
| 52 | # NodePatters must either have no type and no content |
| 53 | # or a type and content -- so they don't get any farther |
| 54 | # Always return leafs |
Benjamin Peterson | 3059b00 | 2009-07-20 16:42:03 +0000 | [diff] [blame] | 55 | if pat.type is None: |
| 56 | raise _EveryNode |
Serhiy Storchaka | db9b65d | 2014-12-13 21:50:49 +0200 | [diff] [blame] | 57 | return {pat.type} |
Christian Heimes | 81ee3ef | 2008-05-04 22:42:01 +0000 | [diff] [blame] | 58 | |
| 59 | if isinstance(pat, pytree.NegatedPattern): |
| 60 | if pat.content: |
Benjamin Peterson | 3059b00 | 2009-07-20 16:42:03 +0000 | [diff] [blame] | 61 | return _get_head_types(pat.content) |
| 62 | raise _EveryNode # Negated Patterns don't have a type |
Christian Heimes | 81ee3ef | 2008-05-04 22:42:01 +0000 | [diff] [blame] | 63 | |
| 64 | if isinstance(pat, pytree.WildcardPattern): |
| 65 | # Recurse on each node in content |
| 66 | r = set() |
| 67 | for p in pat.content: |
| 68 | for x in p: |
Benjamin Peterson | 3059b00 | 2009-07-20 16:42:03 +0000 | [diff] [blame] | 69 | r.update(_get_head_types(x)) |
Christian Heimes | 81ee3ef | 2008-05-04 22:42:01 +0000 | [diff] [blame] | 70 | return r |
| 71 | |
| 72 | raise Exception("Oh no! I don't understand pattern %s" %(pat)) |
| 73 | |
Benjamin Peterson | 3059b00 | 2009-07-20 16:42:03 +0000 | [diff] [blame] | 74 | |
| 75 | def _get_headnode_dict(fixer_list): |
Christian Heimes | 81ee3ef | 2008-05-04 22:42:01 +0000 | [diff] [blame] | 76 | """ Accepts a list of fixers and returns a dictionary |
| 77 | of head node type --> fixer list. """ |
Benjamin Peterson | 3059b00 | 2009-07-20 16:42:03 +0000 | [diff] [blame] | 78 | head_nodes = collections.defaultdict(list) |
| 79 | every = [] |
Christian Heimes | 81ee3ef | 2008-05-04 22:42:01 +0000 | [diff] [blame] | 80 | for fixer in fixer_list: |
Benjamin Peterson | 3059b00 | 2009-07-20 16:42:03 +0000 | [diff] [blame] | 81 | if fixer.pattern: |
| 82 | try: |
| 83 | heads = _get_head_types(fixer.pattern) |
| 84 | except _EveryNode: |
| 85 | every.append(fixer) |
| 86 | else: |
| 87 | for node_type in heads: |
| 88 | head_nodes[node_type].append(fixer) |
| 89 | else: |
| 90 | if fixer._accept_type is not None: |
| 91 | head_nodes[fixer._accept_type].append(fixer) |
| 92 | else: |
| 93 | every.append(fixer) |
| 94 | for node_type in chain(pygram.python_grammar.symbol2number.values(), |
| 95 | pygram.python_grammar.tokens): |
| 96 | head_nodes[node_type].extend(every) |
| 97 | return dict(head_nodes) |
| 98 | |
Christian Heimes | 81ee3ef | 2008-05-04 22:42:01 +0000 | [diff] [blame] | 99 | |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 100 | def get_fixers_from_package(pkg_name): |
| 101 | """ |
| 102 | Return the fully qualified names for fixers in the package pkg_name. |
| 103 | """ |
| 104 | return [pkg_name + "." + fix_name |
| 105 | for fix_name in get_all_fix_names(pkg_name, False)] |
| 106 | |
Benjamin Peterson | d481e3d | 2009-05-09 19:42:23 +0000 | [diff] [blame] | 107 | def _identity(obj): |
| 108 | return obj |
| 109 | |
| 110 | if sys.version_info < (3, 0): |
| 111 | import codecs |
| 112 | _open_with_encoding = codecs.open |
| 113 | # codecs.open doesn't translate newlines sadly. |
| 114 | def _from_system_newlines(input): |
| 115 | return input.replace("\r\n", "\n") |
| 116 | def _to_system_newlines(input): |
| 117 | if os.linesep != "\n": |
| 118 | return input.replace("\n", os.linesep) |
| 119 | else: |
| 120 | return input |
| 121 | else: |
| 122 | _open_with_encoding = open |
| 123 | _from_system_newlines = _identity |
| 124 | _to_system_newlines = _identity |
| 125 | |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 126 | |
Benjamin Peterson | 8d26b0b | 2010-05-07 19:10:11 +0000 | [diff] [blame] | 127 | def _detect_future_features(source): |
Benjamin Peterson | 3059b00 | 2009-07-20 16:42:03 +0000 | [diff] [blame] | 128 | have_docstring = False |
| 129 | gen = tokenize.generate_tokens(io.StringIO(source).readline) |
| 130 | def advance(): |
| 131 | tok = next(gen) |
| 132 | return tok[0], tok[1] |
Serhiy Storchaka | db9b65d | 2014-12-13 21:50:49 +0200 | [diff] [blame] | 133 | ignore = frozenset({token.NEWLINE, tokenize.NL, token.COMMENT}) |
Benjamin Peterson | 8d26b0b | 2010-05-07 19:10:11 +0000 | [diff] [blame] | 134 | features = set() |
Benjamin Peterson | 3059b00 | 2009-07-20 16:42:03 +0000 | [diff] [blame] | 135 | try: |
| 136 | while True: |
| 137 | tp, value = advance() |
| 138 | if tp in ignore: |
| 139 | continue |
| 140 | elif tp == token.STRING: |
| 141 | if have_docstring: |
| 142 | break |
| 143 | have_docstring = True |
Benjamin Peterson | 2021100 | 2009-11-25 18:34:42 +0000 | [diff] [blame] | 144 | elif tp == token.NAME and value == "from": |
| 145 | tp, value = advance() |
Benjamin Peterson | 8d26b0b | 2010-05-07 19:10:11 +0000 | [diff] [blame] | 146 | if tp != token.NAME or value != "__future__": |
Benjamin Peterson | 3059b00 | 2009-07-20 16:42:03 +0000 | [diff] [blame] | 147 | break |
Benjamin Peterson | 2021100 | 2009-11-25 18:34:42 +0000 | [diff] [blame] | 148 | tp, value = advance() |
Benjamin Peterson | 8d26b0b | 2010-05-07 19:10:11 +0000 | [diff] [blame] | 149 | if tp != token.NAME or value != "import": |
Benjamin Peterson | 2021100 | 2009-11-25 18:34:42 +0000 | [diff] [blame] | 150 | break |
| 151 | tp, value = advance() |
| 152 | if tp == token.OP and value == "(": |
| 153 | tp, value = advance() |
| 154 | while tp == token.NAME: |
Benjamin Peterson | 8d26b0b | 2010-05-07 19:10:11 +0000 | [diff] [blame] | 155 | features.add(value) |
Benjamin Peterson | 2021100 | 2009-11-25 18:34:42 +0000 | [diff] [blame] | 156 | tp, value = advance() |
Benjamin Peterson | 8d26b0b | 2010-05-07 19:10:11 +0000 | [diff] [blame] | 157 | if tp != token.OP or value != ",": |
Benjamin Peterson | 2021100 | 2009-11-25 18:34:42 +0000 | [diff] [blame] | 158 | break |
| 159 | tp, value = advance() |
Benjamin Peterson | 3059b00 | 2009-07-20 16:42:03 +0000 | [diff] [blame] | 160 | else: |
| 161 | break |
| 162 | except StopIteration: |
| 163 | pass |
Benjamin Peterson | 8d26b0b | 2010-05-07 19:10:11 +0000 | [diff] [blame] | 164 | return frozenset(features) |
Benjamin Peterson | 3059b00 | 2009-07-20 16:42:03 +0000 | [diff] [blame] | 165 | |
| 166 | |
Benjamin Peterson | d61de7f | 2008-09-27 22:17:35 +0000 | [diff] [blame] | 167 | class FixerError(Exception): |
| 168 | """A fixer could not be loaded.""" |
| 169 | |
| 170 | |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 171 | class RefactoringTool(object): |
| 172 | |
Gregory P. Smith | 58f23ff | 2012-02-12 15:50:21 -0800 | [diff] [blame] | 173 | _default_options = {"print_function" : False, |
| 174 | "write_unchanged_files" : False} |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 175 | |
Benjamin Peterson | d61de7f | 2008-09-27 22:17:35 +0000 | [diff] [blame] | 176 | CLASS_PREFIX = "Fix" # The prefix for fixer classes |
| 177 | FILE_PREFIX = "fix_" # The prefix for modules with a fixer within |
| 178 | |
| 179 | def __init__(self, fixer_names, options=None, explicit=None): |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 180 | """Initializer. |
| 181 | |
Benjamin Peterson | df6dc8f | 2008-06-15 02:57:40 +0000 | [diff] [blame] | 182 | Args: |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 183 | fixer_names: a list of fixers to import |
Serhiy Storchaka | 6a7b3a7 | 2016-04-17 08:32:47 +0300 | [diff] [blame] | 184 | options: a dict with configuration. |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 185 | explicit: a list of fixers to run even if they are explicit. |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 186 | """ |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 187 | self.fixers = fixer_names |
Benjamin Peterson | d61de7f | 2008-09-27 22:17:35 +0000 | [diff] [blame] | 188 | self.explicit = explicit or [] |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 189 | self.options = self._default_options.copy() |
| 190 | if options is not None: |
| 191 | self.options.update(options) |
Benjamin Peterson | 2021100 | 2009-11-25 18:34:42 +0000 | [diff] [blame] | 192 | if self.options["print_function"]: |
| 193 | self.grammar = pygram.python_grammar_no_print_statement |
| 194 | else: |
| 195 | self.grammar = pygram.python_grammar |
Gregory P. Smith | 58f23ff | 2012-02-12 15:50:21 -0800 | [diff] [blame] | 196 | # When this is True, the refactor*() methods will call write_file() for |
| 197 | # files processed even if they were not changed during refactoring. If |
| 198 | # and only if the refactor method's write parameter was True. |
| 199 | self.write_unchanged_files = self.options.get("write_unchanged_files") |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 200 | self.errors = [] |
| 201 | self.logger = logging.getLogger("RefactoringTool") |
| 202 | self.fixer_log = [] |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 203 | self.wrote = False |
Benjamin Peterson | 2021100 | 2009-11-25 18:34:42 +0000 | [diff] [blame] | 204 | self.driver = driver.Driver(self.grammar, |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 205 | convert=pytree.convert, |
| 206 | logger=self.logger) |
| 207 | self.pre_order, self.post_order = self.get_fixers() |
Christian Heimes | 81ee3ef | 2008-05-04 22:42:01 +0000 | [diff] [blame] | 208 | |
Christian Heimes | 81ee3ef | 2008-05-04 22:42:01 +0000 | [diff] [blame] | 209 | |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 210 | self.files = [] # List of files that were or should be modified |
| 211 | |
Benjamin Peterson | f37eb3a | 2010-10-14 23:00:04 +0000 | [diff] [blame] | 212 | self.BM = bm.BottomMatcher() |
| 213 | self.bmi_pre_order = [] # Bottom Matcher incompatible fixers |
| 214 | self.bmi_post_order = [] |
| 215 | |
| 216 | for fixer in chain(self.post_order, self.pre_order): |
| 217 | if fixer.BM_compatible: |
| 218 | self.BM.add_fixer(fixer) |
| 219 | # remove fixers that will be handled by the bottom-up |
| 220 | # matcher |
| 221 | elif fixer in self.pre_order: |
| 222 | self.bmi_pre_order.append(fixer) |
| 223 | elif fixer in self.post_order: |
| 224 | self.bmi_post_order.append(fixer) |
| 225 | |
| 226 | self.bmi_pre_order_heads = _get_headnode_dict(self.bmi_pre_order) |
| 227 | self.bmi_post_order_heads = _get_headnode_dict(self.bmi_post_order) |
| 228 | |
| 229 | |
| 230 | |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 231 | def get_fixers(self): |
| 232 | """Inspects the options to load the requested patterns and handlers. |
Martin v. Löwis | f733c60 | 2008-03-19 05:26:18 +0000 | [diff] [blame] | 233 | |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 234 | Returns: |
| 235 | (pre_order, post_order), where pre_order is the list of fixers that |
| 236 | want a pre-order AST traversal, and post_order is the list that want |
| 237 | post-order traversal. |
| 238 | """ |
| 239 | pre_order_fixers = [] |
| 240 | post_order_fixers = [] |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 241 | for fix_mod_path in self.fixers: |
Benjamin Peterson | d61de7f | 2008-09-27 22:17:35 +0000 | [diff] [blame] | 242 | mod = __import__(fix_mod_path, {}, {}, ["*"]) |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 243 | fix_name = fix_mod_path.rsplit(".", 1)[-1] |
Benjamin Peterson | d61de7f | 2008-09-27 22:17:35 +0000 | [diff] [blame] | 244 | if fix_name.startswith(self.FILE_PREFIX): |
| 245 | fix_name = fix_name[len(self.FILE_PREFIX):] |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 246 | parts = fix_name.split("_") |
Benjamin Peterson | d61de7f | 2008-09-27 22:17:35 +0000 | [diff] [blame] | 247 | class_name = self.CLASS_PREFIX + "".join([p.title() for p in parts]) |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 248 | try: |
| 249 | fix_class = getattr(mod, class_name) |
| 250 | except AttributeError: |
Benjamin Peterson | d61de7f | 2008-09-27 22:17:35 +0000 | [diff] [blame] | 251 | raise FixerError("Can't find %s.%s" % (fix_name, class_name)) |
| 252 | fixer = fix_class(self.options, self.fixer_log) |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 253 | if fixer.explicit and self.explicit is not True and \ |
| 254 | fix_mod_path not in self.explicit: |
Berker Peksag | 3a81f9b | 2015-05-13 13:39:51 +0300 | [diff] [blame] | 255 | self.log_message("Skipping optional fixer: %s", fix_name) |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 256 | continue |
| 257 | |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 258 | self.log_debug("Adding transformation: %s", fix_name) |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 259 | if fixer.order == "pre": |
| 260 | pre_order_fixers.append(fixer) |
| 261 | elif fixer.order == "post": |
| 262 | post_order_fixers.append(fixer) |
| 263 | else: |
Benjamin Peterson | d61de7f | 2008-09-27 22:17:35 +0000 | [diff] [blame] | 264 | raise FixerError("Illegal fixer order: %r" % fixer.order) |
Martin v. Löwis | 3faa84f | 2008-03-22 00:07:09 +0000 | [diff] [blame] | 265 | |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 266 | key_func = operator.attrgetter("run_order") |
| 267 | pre_order_fixers.sort(key=key_func) |
| 268 | post_order_fixers.sort(key=key_func) |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 269 | return (pre_order_fixers, post_order_fixers) |
| 270 | |
| 271 | def log_error(self, msg, *args, **kwds): |
Benjamin Peterson | d61de7f | 2008-09-27 22:17:35 +0000 | [diff] [blame] | 272 | """Called when an error occurs.""" |
| 273 | raise |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 274 | |
| 275 | def log_message(self, msg, *args): |
| 276 | """Hook to log a message.""" |
| 277 | if args: |
| 278 | msg = msg % args |
| 279 | self.logger.info(msg) |
| 280 | |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 281 | def log_debug(self, msg, *args): |
| 282 | if args: |
| 283 | msg = msg % args |
| 284 | self.logger.debug(msg) |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 285 | |
Benjamin Peterson | 3059b00 | 2009-07-20 16:42:03 +0000 | [diff] [blame] | 286 | def print_output(self, old_text, new_text, filename, equal): |
| 287 | """Called with the old version, new version, and filename of a |
| 288 | refactored file.""" |
Benjamin Peterson | d61de7f | 2008-09-27 22:17:35 +0000 | [diff] [blame] | 289 | pass |
| 290 | |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 291 | def refactor(self, items, write=False, doctests_only=False): |
| 292 | """Refactor a list of files and directories.""" |
Benjamin Peterson | f37eb3a | 2010-10-14 23:00:04 +0000 | [diff] [blame] | 293 | |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 294 | for dir_or_file in items: |
| 295 | if os.path.isdir(dir_or_file): |
Benjamin Peterson | d61de7f | 2008-09-27 22:17:35 +0000 | [diff] [blame] | 296 | self.refactor_dir(dir_or_file, write, doctests_only) |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 297 | else: |
Benjamin Peterson | d61de7f | 2008-09-27 22:17:35 +0000 | [diff] [blame] | 298 | self.refactor_file(dir_or_file, write, doctests_only) |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 299 | |
| 300 | def refactor_dir(self, dir_name, write=False, doctests_only=False): |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 301 | """Descends down a directory and refactor every Python file found. |
| 302 | |
| 303 | Python files are assumed to have a .py extension. |
| 304 | |
| 305 | Files and subdirectories starting with '.' are skipped. |
| 306 | """ |
Martin v. Löwis | e2bb4eb | 2010-12-03 23:11:07 +0000 | [diff] [blame] | 307 | py_ext = os.extsep + "py" |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 308 | for dirpath, dirnames, filenames in os.walk(dir_name): |
| 309 | self.log_debug("Descending into %s", dirpath) |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 310 | dirnames.sort() |
| 311 | filenames.sort() |
| 312 | for name in filenames: |
Martin v. Löwis | e2bb4eb | 2010-12-03 23:11:07 +0000 | [diff] [blame] | 313 | if (not name.startswith(".") and |
| 314 | os.path.splitext(name)[1] == py_ext): |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 315 | fullname = os.path.join(dirpath, name) |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 316 | self.refactor_file(fullname, write, doctests_only) |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 317 | # Modify dirnames in-place to remove subdirs with leading dots |
| 318 | dirnames[:] = [dn for dn in dirnames if not dn.startswith(".")] |
| 319 | |
Benjamin Peterson | d481e3d | 2009-05-09 19:42:23 +0000 | [diff] [blame] | 320 | def _read_python_source(self, filename): |
| 321 | """ |
| 322 | Do our best to decode a Python source file correctly. |
| 323 | """ |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 324 | try: |
Benjamin Peterson | d481e3d | 2009-05-09 19:42:23 +0000 | [diff] [blame] | 325 | f = open(filename, "rb") |
Andrew Svetlov | f7a17b4 | 2012-12-25 16:47:37 +0200 | [diff] [blame] | 326 | except OSError as err: |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 327 | self.log_error("Can't open %s: %s", filename, err) |
Benjamin Peterson | d481e3d | 2009-05-09 19:42:23 +0000 | [diff] [blame] | 328 | return None, None |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 329 | try: |
Benjamin Peterson | d481e3d | 2009-05-09 19:42:23 +0000 | [diff] [blame] | 330 | encoding = tokenize.detect_encoding(f.readline)[0] |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 331 | finally: |
| 332 | f.close() |
Benjamin Peterson | d481e3d | 2009-05-09 19:42:23 +0000 | [diff] [blame] | 333 | with _open_with_encoding(filename, "r", encoding=encoding) as f: |
| 334 | return _from_system_newlines(f.read()), encoding |
| 335 | |
| 336 | def refactor_file(self, filename, write=False, doctests_only=False): |
| 337 | """Refactors a file.""" |
| 338 | input, encoding = self._read_python_source(filename) |
| 339 | if input is None: |
| 340 | # Reading the file failed. |
| 341 | return |
| 342 | input += "\n" # Silence certain parse errors |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 343 | if doctests_only: |
| 344 | self.log_debug("Refactoring doctests in %s", filename) |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 345 | output = self.refactor_docstring(input, filename) |
Gregory P. Smith | 58f23ff | 2012-02-12 15:50:21 -0800 | [diff] [blame] | 346 | if self.write_unchanged_files or output != input: |
Benjamin Peterson | d481e3d | 2009-05-09 19:42:23 +0000 | [diff] [blame] | 347 | self.processed_file(output, filename, input, write, encoding) |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 348 | else: |
| 349 | self.log_debug("No doctest changes in %s", filename) |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 350 | else: |
| 351 | tree = self.refactor_string(input, filename) |
Gregory P. Smith | 58f23ff | 2012-02-12 15:50:21 -0800 | [diff] [blame] | 352 | if self.write_unchanged_files or (tree and tree.was_changed): |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 353 | # The [:-1] is to take off the \n we added earlier |
Benjamin Peterson | d481e3d | 2009-05-09 19:42:23 +0000 | [diff] [blame] | 354 | self.processed_file(str(tree)[:-1], filename, |
| 355 | write=write, encoding=encoding) |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 356 | else: |
| 357 | self.log_debug("No changes in %s", filename) |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 358 | |
| 359 | def refactor_string(self, data, name): |
| 360 | """Refactor a given input string. |
Martin v. Löwis | f733c60 | 2008-03-19 05:26:18 +0000 | [diff] [blame] | 361 | |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 362 | Args: |
| 363 | data: a string holding the code to be refactored. |
| 364 | name: a human-readable name for use in error/log messages. |
Martin v. Löwis | f733c60 | 2008-03-19 05:26:18 +0000 | [diff] [blame] | 365 | |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 366 | Returns: |
| 367 | An AST corresponding to the refactored input stream; None if |
| 368 | there were errors during the parse. |
| 369 | """ |
Benjamin Peterson | 8d26b0b | 2010-05-07 19:10:11 +0000 | [diff] [blame] | 370 | features = _detect_future_features(data) |
| 371 | if "print_function" in features: |
Benjamin Peterson | 3059b00 | 2009-07-20 16:42:03 +0000 | [diff] [blame] | 372 | self.driver.grammar = pygram.python_grammar_no_print_statement |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 373 | try: |
Benjamin Peterson | 206e307 | 2008-10-19 14:07:49 +0000 | [diff] [blame] | 374 | tree = self.driver.parse_string(data) |
Martin v. Löwis | 8a5f8ca | 2008-03-19 05:33:36 +0000 | [diff] [blame] | 375 | except Exception as err: |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 376 | self.log_error("Can't parse %s: %s: %s", |
| 377 | name, err.__class__.__name__, err) |
| 378 | return |
Benjamin Peterson | 3059b00 | 2009-07-20 16:42:03 +0000 | [diff] [blame] | 379 | finally: |
Benjamin Peterson | 2021100 | 2009-11-25 18:34:42 +0000 | [diff] [blame] | 380 | self.driver.grammar = self.grammar |
Benjamin Peterson | 8d26b0b | 2010-05-07 19:10:11 +0000 | [diff] [blame] | 381 | tree.future_features = features |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 382 | self.log_debug("Refactoring %s", name) |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 383 | self.refactor_tree(tree, name) |
| 384 | return tree |
| 385 | |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 386 | def refactor_stdin(self, doctests_only=False): |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 387 | input = sys.stdin.read() |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 388 | if doctests_only: |
| 389 | self.log_debug("Refactoring doctests in stdin") |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 390 | output = self.refactor_docstring(input, "<stdin>") |
Gregory P. Smith | 58f23ff | 2012-02-12 15:50:21 -0800 | [diff] [blame] | 391 | if self.write_unchanged_files or output != input: |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 392 | self.processed_file(output, "<stdin>", input) |
| 393 | else: |
| 394 | self.log_debug("No doctest changes in stdin") |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 395 | else: |
| 396 | tree = self.refactor_string(input, "<stdin>") |
Gregory P. Smith | 58f23ff | 2012-02-12 15:50:21 -0800 | [diff] [blame] | 397 | if self.write_unchanged_files or (tree and tree.was_changed): |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 398 | self.processed_file(str(tree), "<stdin>", input) |
| 399 | else: |
| 400 | self.log_debug("No changes in stdin") |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 401 | |
| 402 | def refactor_tree(self, tree, name): |
| 403 | """Refactors a parse tree (modifying the tree in place). |
Martin v. Löwis | f733c60 | 2008-03-19 05:26:18 +0000 | [diff] [blame] | 404 | |
Benjamin Peterson | f37eb3a | 2010-10-14 23:00:04 +0000 | [diff] [blame] | 405 | For compatible patterns the bottom matcher module is |
| 406 | used. Otherwise the tree is traversed node-to-node for |
| 407 | matches. |
| 408 | |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 409 | Args: |
| 410 | tree: a pytree.Node instance representing the root of the tree |
| 411 | to be refactored. |
| 412 | name: a human-readable name for this tree. |
Martin v. Löwis | f733c60 | 2008-03-19 05:26:18 +0000 | [diff] [blame] | 413 | |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 414 | Returns: |
| 415 | True if the tree was modified, False otherwise. |
| 416 | """ |
Benjamin Peterson | f37eb3a | 2010-10-14 23:00:04 +0000 | [diff] [blame] | 417 | |
Benjamin Peterson | 8bcddca | 2009-01-03 16:53:14 +0000 | [diff] [blame] | 418 | for fixer in chain(self.pre_order, self.post_order): |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 419 | fixer.start_tree(tree, name) |
| 420 | |
Benjamin Peterson | f37eb3a | 2010-10-14 23:00:04 +0000 | [diff] [blame] | 421 | #use traditional matching for the incompatible fixers |
| 422 | self.traverse_by(self.bmi_pre_order_heads, tree.pre_order()) |
| 423 | self.traverse_by(self.bmi_post_order_heads, tree.post_order()) |
| 424 | |
| 425 | # obtain a set of candidate nodes |
| 426 | match_set = self.BM.run(tree.leaves()) |
| 427 | |
| 428 | while any(match_set.values()): |
| 429 | for fixer in self.BM.fixers: |
| 430 | if fixer in match_set and match_set[fixer]: |
| 431 | #sort by depth; apply fixers from bottom(of the AST) to top |
| 432 | match_set[fixer].sort(key=pytree.Base.depth, reverse=True) |
| 433 | |
| 434 | if fixer.keep_line_order: |
| 435 | #some fixers(eg fix_imports) must be applied |
| 436 | #with the original file's line order |
| 437 | match_set[fixer].sort(key=pytree.Base.get_lineno) |
| 438 | |
| 439 | for node in list(match_set[fixer]): |
| 440 | if node in match_set[fixer]: |
| 441 | match_set[fixer].remove(node) |
| 442 | |
| 443 | try: |
| 444 | find_root(node) |
Benjamin Peterson | 1654d74 | 2012-09-25 11:48:50 -0400 | [diff] [blame] | 445 | except ValueError: |
Benjamin Peterson | f37eb3a | 2010-10-14 23:00:04 +0000 | [diff] [blame] | 446 | # this node has been cut off from a |
| 447 | # previous transformation ; skip |
| 448 | continue |
| 449 | |
| 450 | if node.fixers_applied and fixer in node.fixers_applied: |
| 451 | # do not apply the same fixer again |
| 452 | continue |
| 453 | |
| 454 | results = fixer.match(node) |
| 455 | |
| 456 | if results: |
| 457 | new = fixer.transform(node, results) |
| 458 | if new is not None: |
| 459 | node.replace(new) |
| 460 | #new.fixers_applied.append(fixer) |
| 461 | for node in new.post_order(): |
| 462 | # do not apply the fixer again to |
| 463 | # this or any subnode |
| 464 | if not node.fixers_applied: |
| 465 | node.fixers_applied = [] |
| 466 | node.fixers_applied.append(fixer) |
| 467 | |
| 468 | # update the original match set for |
| 469 | # the added code |
| 470 | new_matches = self.BM.run(new.leaves()) |
| 471 | for fxr in new_matches: |
| 472 | if not fxr in match_set: |
| 473 | match_set[fxr]=[] |
| 474 | |
| 475 | match_set[fxr].extend(new_matches[fxr]) |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 476 | |
Benjamin Peterson | 8bcddca | 2009-01-03 16:53:14 +0000 | [diff] [blame] | 477 | for fixer in chain(self.pre_order, self.post_order): |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 478 | fixer.finish_tree(tree, name) |
| 479 | return tree.was_changed |
| 480 | |
| 481 | def traverse_by(self, fixers, traversal): |
| 482 | """Traverse an AST, applying a set of fixers to each node. |
Martin v. Löwis | f733c60 | 2008-03-19 05:26:18 +0000 | [diff] [blame] | 483 | |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 484 | This is a helper method for refactor_tree(). |
Martin v. Löwis | f733c60 | 2008-03-19 05:26:18 +0000 | [diff] [blame] | 485 | |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 486 | Args: |
| 487 | fixers: a list of fixer instances. |
| 488 | traversal: a generator that yields AST nodes. |
Martin v. Löwis | f733c60 | 2008-03-19 05:26:18 +0000 | [diff] [blame] | 489 | |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 490 | Returns: |
| 491 | None |
| 492 | """ |
| 493 | if not fixers: |
| 494 | return |
| 495 | for node in traversal: |
Benjamin Peterson | 3059b00 | 2009-07-20 16:42:03 +0000 | [diff] [blame] | 496 | for fixer in fixers[node.type]: |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 497 | results = fixer.match(node) |
| 498 | if results: |
| 499 | new = fixer.transform(node, results) |
Benjamin Peterson | 3059b00 | 2009-07-20 16:42:03 +0000 | [diff] [blame] | 500 | if new is not None: |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 501 | node.replace(new) |
| 502 | node = new |
| 503 | |
Benjamin Peterson | d481e3d | 2009-05-09 19:42:23 +0000 | [diff] [blame] | 504 | def processed_file(self, new_text, filename, old_text=None, write=False, |
| 505 | encoding=None): |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 506 | """ |
Gregory P. Smith | 58f23ff | 2012-02-12 15:50:21 -0800 | [diff] [blame] | 507 | Called when a file has been refactored and there may be changes. |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 508 | """ |
| 509 | self.files.append(filename) |
| 510 | if old_text is None: |
Benjamin Peterson | d481e3d | 2009-05-09 19:42:23 +0000 | [diff] [blame] | 511 | old_text = self._read_python_source(filename)[0] |
| 512 | if old_text is None: |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 513 | return |
Benjamin Peterson | 3059b00 | 2009-07-20 16:42:03 +0000 | [diff] [blame] | 514 | equal = old_text == new_text |
| 515 | self.print_output(old_text, new_text, filename, equal) |
| 516 | if equal: |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 517 | self.log_debug("No changes to %s", filename) |
Gregory P. Smith | 58f23ff | 2012-02-12 15:50:21 -0800 | [diff] [blame] | 518 | if not self.write_unchanged_files: |
| 519 | return |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 520 | if write: |
Benjamin Peterson | d481e3d | 2009-05-09 19:42:23 +0000 | [diff] [blame] | 521 | self.write_file(new_text, filename, old_text, encoding) |
Benjamin Peterson | d61de7f | 2008-09-27 22:17:35 +0000 | [diff] [blame] | 522 | else: |
| 523 | self.log_debug("Not writing changes to %s", filename) |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 524 | |
Benjamin Peterson | d481e3d | 2009-05-09 19:42:23 +0000 | [diff] [blame] | 525 | def write_file(self, new_text, filename, old_text, encoding=None): |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 526 | """Writes a string to a file. |
| 527 | |
| 528 | It first shows a unified diff between the old text and the new text, and |
| 529 | then rewrites the file; the latter is only done if the write option is |
| 530 | set. |
| 531 | """ |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 532 | try: |
Benjamin Peterson | d481e3d | 2009-05-09 19:42:23 +0000 | [diff] [blame] | 533 | f = _open_with_encoding(filename, "w", encoding=encoding) |
Andrew Svetlov | ad28c7f | 2012-12-18 22:02:39 +0200 | [diff] [blame] | 534 | except OSError as err: |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 535 | self.log_error("Can't create %s: %s", filename, err) |
| 536 | return |
| 537 | try: |
Benjamin Peterson | d481e3d | 2009-05-09 19:42:23 +0000 | [diff] [blame] | 538 | f.write(_to_system_newlines(new_text)) |
Andrew Svetlov | ad28c7f | 2012-12-18 22:02:39 +0200 | [diff] [blame] | 539 | except OSError as err: |
Benjamin Peterson | ba55818 | 2008-11-10 22:21:33 +0000 | [diff] [blame] | 540 | self.log_error("Can't write %s: %s", filename, err) |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 541 | finally: |
| 542 | f.close() |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 543 | self.log_debug("Wrote changes to %s", filename) |
| 544 | self.wrote = True |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 545 | |
| 546 | PS1 = ">>> " |
| 547 | PS2 = "... " |
| 548 | |
| 549 | def refactor_docstring(self, input, filename): |
| 550 | """Refactors a docstring, looking for doctests. |
| 551 | |
| 552 | This returns a modified version of the input string. It looks |
| 553 | for doctests, which start with a ">>>" prompt, and may be |
| 554 | continued with "..." prompts, as long as the "..." is indented |
| 555 | the same as the ">>>". |
| 556 | |
| 557 | (Unfortunately we can't use the doctest module's parser, |
| 558 | since, like most parsers, it is not geared towards preserving |
| 559 | the original source.) |
| 560 | """ |
| 561 | result = [] |
| 562 | block = None |
| 563 | block_lineno = None |
| 564 | indent = None |
| 565 | lineno = 0 |
Ezio Melotti | d8b509b | 2011-09-28 17:37:55 +0300 | [diff] [blame] | 566 | for line in input.splitlines(keepends=True): |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 567 | lineno += 1 |
| 568 | if line.lstrip().startswith(self.PS1): |
| 569 | if block is not None: |
| 570 | result.extend(self.refactor_doctest(block, block_lineno, |
| 571 | indent, filename)) |
| 572 | block_lineno = lineno |
| 573 | block = [line] |
| 574 | i = line.find(self.PS1) |
| 575 | indent = line[:i] |
| 576 | elif (indent is not None and |
| 577 | (line.startswith(indent + self.PS2) or |
| 578 | line == indent + self.PS2.rstrip() + "\n")): |
| 579 | block.append(line) |
| 580 | else: |
| 581 | if block is not None: |
| 582 | result.extend(self.refactor_doctest(block, block_lineno, |
| 583 | indent, filename)) |
| 584 | block = None |
| 585 | indent = None |
| 586 | result.append(line) |
| 587 | if block is not None: |
| 588 | result.extend(self.refactor_doctest(block, block_lineno, |
| 589 | indent, filename)) |
| 590 | return "".join(result) |
| 591 | |
| 592 | def refactor_doctest(self, block, lineno, indent, filename): |
| 593 | """Refactors one doctest. |
| 594 | |
| 595 | A doctest is given as a block of lines, the first of which starts |
| 596 | with ">>>" (possibly indented), while the remaining lines start |
| 597 | with "..." (identically indented). |
| 598 | |
| 599 | """ |
| 600 | try: |
| 601 | tree = self.parse_block(block, lineno, indent) |
Martin v. Löwis | 8a5f8ca | 2008-03-19 05:33:36 +0000 | [diff] [blame] | 602 | except Exception as err: |
Benjamin Peterson | 4eb5fa5 | 2010-08-08 19:01:25 +0000 | [diff] [blame] | 603 | if self.logger.isEnabledFor(logging.DEBUG): |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 604 | for line in block: |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 605 | self.log_debug("Source: %s", line.rstrip("\n")) |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 606 | self.log_error("Can't parse docstring in %s line %s: %s: %s", |
| 607 | filename, lineno, err.__class__.__name__, err) |
| 608 | return block |
| 609 | if self.refactor_tree(tree, filename): |
Ezio Melotti | d8b509b | 2011-09-28 17:37:55 +0300 | [diff] [blame] | 610 | new = str(tree).splitlines(keepends=True) |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 611 | # Undo the adjustment of the line numbers in wrap_toks() below. |
| 612 | clipped, new = new[:lineno-1], new[lineno-1:] |
| 613 | assert clipped == ["\n"] * (lineno-1), clipped |
| 614 | if not new[-1].endswith("\n"): |
| 615 | new[-1] += "\n" |
| 616 | block = [indent + self.PS1 + new.pop(0)] |
| 617 | if new: |
| 618 | block += [indent + self.PS2 + line for line in new] |
| 619 | return block |
| 620 | |
| 621 | def summarize(self): |
Benjamin Peterson | 8951b61 | 2008-09-03 02:27:16 +0000 | [diff] [blame] | 622 | if self.wrote: |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 623 | were = "were" |
| 624 | else: |
| 625 | were = "need to be" |
| 626 | if not self.files: |
| 627 | self.log_message("No files %s modified.", were) |
| 628 | else: |
| 629 | self.log_message("Files that %s modified:", were) |
| 630 | for file in self.files: |
| 631 | self.log_message(file) |
| 632 | if self.fixer_log: |
| 633 | self.log_message("Warnings/messages while refactoring:") |
| 634 | for message in self.fixer_log: |
| 635 | self.log_message(message) |
| 636 | if self.errors: |
| 637 | if len(self.errors) == 1: |
| 638 | self.log_message("There was 1 error:") |
| 639 | else: |
| 640 | self.log_message("There were %d errors:", len(self.errors)) |
| 641 | for msg, args, kwds in self.errors: |
| 642 | self.log_message(msg, *args, **kwds) |
| 643 | |
| 644 | def parse_block(self, block, lineno, indent): |
| 645 | """Parses a block into a tree. |
| 646 | |
| 647 | This is necessary to get correct line number / offset information |
| 648 | in the parser diagnostics and embedded into the parse tree. |
| 649 | """ |
Benjamin Peterson | 2243e5e | 2010-05-22 18:59:24 +0000 | [diff] [blame] | 650 | tree = self.driver.parse_tokens(self.wrap_toks(block, lineno, indent)) |
| 651 | tree.future_features = frozenset() |
| 652 | return tree |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 653 | |
| 654 | def wrap_toks(self, block, lineno, indent): |
| 655 | """Wraps a tokenize stream to systematically modify start/end.""" |
Martin v. Löwis | 8a5f8ca | 2008-03-19 05:33:36 +0000 | [diff] [blame] | 656 | tokens = tokenize.generate_tokens(self.gen_lines(block, indent).__next__) |
Martin v. Löwis | ef04c44 | 2008-03-19 05:04:44 +0000 | [diff] [blame] | 657 | for type, value, (line0, col0), (line1, col1), line_text in tokens: |
| 658 | line0 += lineno - 1 |
| 659 | line1 += lineno - 1 |
| 660 | # Don't bother updating the columns; this is too complicated |
| 661 | # since line_text would also have to be updated and it would |
| 662 | # still break for tokens spanning lines. Let the user guess |
| 663 | # that the column numbers for doctests are relative to the |
| 664 | # end of the prompt string (PS1 or PS2). |
| 665 | yield type, value, (line0, col0), (line1, col1), line_text |
| 666 | |
| 667 | |
| 668 | def gen_lines(self, block, indent): |
| 669 | """Generates lines as expected by tokenize from a list of lines. |
| 670 | |
| 671 | This strips the first len(indent + self.PS1) characters off each line. |
| 672 | """ |
| 673 | prefix1 = indent + self.PS1 |
| 674 | prefix2 = indent + self.PS2 |
| 675 | prefix = prefix1 |
| 676 | for line in block: |
| 677 | if line.startswith(prefix): |
| 678 | yield line[len(prefix):] |
| 679 | elif line == prefix.rstrip() + "\n": |
| 680 | yield "\n" |
| 681 | else: |
| 682 | raise AssertionError("line=%r, prefix=%r" % (line, prefix)) |
| 683 | prefix = prefix2 |
| 684 | while True: |
| 685 | yield "" |
| 686 | |
| 687 | |
Benjamin Peterson | 608d8bc | 2009-05-05 23:23:31 +0000 | [diff] [blame] | 688 | class MultiprocessingUnsupported(Exception): |
| 689 | pass |
| 690 | |
| 691 | |
| 692 | class MultiprocessRefactoringTool(RefactoringTool): |
| 693 | |
| 694 | def __init__(self, *args, **kwargs): |
| 695 | super(MultiprocessRefactoringTool, self).__init__(*args, **kwargs) |
| 696 | self.queue = None |
Benjamin Peterson | 8d26b0b | 2010-05-07 19:10:11 +0000 | [diff] [blame] | 697 | self.output_lock = None |
Benjamin Peterson | 608d8bc | 2009-05-05 23:23:31 +0000 | [diff] [blame] | 698 | |
| 699 | def refactor(self, items, write=False, doctests_only=False, |
| 700 | num_processes=1): |
| 701 | if num_processes == 1: |
| 702 | return super(MultiprocessRefactoringTool, self).refactor( |
| 703 | items, write, doctests_only) |
| 704 | try: |
| 705 | import multiprocessing |
Brett Cannon | cd171c8 | 2013-07-04 17:43:24 -0400 | [diff] [blame] | 706 | except ImportError: |
Benjamin Peterson | 608d8bc | 2009-05-05 23:23:31 +0000 | [diff] [blame] | 707 | raise MultiprocessingUnsupported |
| 708 | if self.queue is not None: |
| 709 | raise RuntimeError("already doing multiple processes") |
| 710 | self.queue = multiprocessing.JoinableQueue() |
Benjamin Peterson | 8d26b0b | 2010-05-07 19:10:11 +0000 | [diff] [blame] | 711 | self.output_lock = multiprocessing.Lock() |
Benjamin Peterson | 608d8bc | 2009-05-05 23:23:31 +0000 | [diff] [blame] | 712 | processes = [multiprocessing.Process(target=self._child) |
Benjamin Peterson | 87b8719 | 2009-07-03 13:18:18 +0000 | [diff] [blame] | 713 | for i in range(num_processes)] |
Benjamin Peterson | 608d8bc | 2009-05-05 23:23:31 +0000 | [diff] [blame] | 714 | try: |
| 715 | for p in processes: |
| 716 | p.start() |
| 717 | super(MultiprocessRefactoringTool, self).refactor(items, write, |
| 718 | doctests_only) |
| 719 | finally: |
| 720 | self.queue.join() |
Benjamin Peterson | 87b8719 | 2009-07-03 13:18:18 +0000 | [diff] [blame] | 721 | for i in range(num_processes): |
Benjamin Peterson | 608d8bc | 2009-05-05 23:23:31 +0000 | [diff] [blame] | 722 | self.queue.put(None) |
| 723 | for p in processes: |
| 724 | if p.is_alive(): |
| 725 | p.join() |
| 726 | self.queue = None |
| 727 | |
| 728 | def _child(self): |
| 729 | task = self.queue.get() |
| 730 | while task is not None: |
| 731 | args, kwargs = task |
| 732 | try: |
| 733 | super(MultiprocessRefactoringTool, self).refactor_file( |
| 734 | *args, **kwargs) |
| 735 | finally: |
| 736 | self.queue.task_done() |
| 737 | task = self.queue.get() |
| 738 | |
| 739 | def refactor_file(self, *args, **kwargs): |
| 740 | if self.queue is not None: |
| 741 | self.queue.put((args, kwargs)) |
| 742 | else: |
| 743 | return super(MultiprocessRefactoringTool, self).refactor_file( |
| 744 | *args, **kwargs) |