commit 9e0666e0bdd7b8357c0f95b46e8cdad8cfea7a75
author Ian Cordasco <graffatcolmingov@gmail.com> Mon Jul 20 11:42:51 2015 -0500
committer Ian Cordasco <graffatcolmingov@gmail.com> Mon Jul 20 11:42:51 2015 -0500
tree 2ba2ea4414c9fc7464878d50d81a07cb5c3a9a3c
parent 4e7bdc785b29e637d44ecb5a0aefc401ee6b1c14

Add another extension to our CertificateBuilder test

tests/test_x509.py

diff --git a/tests/test_x509.py b/tests/test_x509.py
index 16d040f..7a06913 100644
--- a/tests/test_x509.py
+++ b/tests/test_x509.py
@@ -802,6 +802,9 @@
             subject_private_key.public_key()
         ).add_extension(
             x509.BasicConstraints(ca=False, path_length=None), True,
+        ).add_extension(
+            x509.SubjectAlternativeName([x509.DNSName(u"cryptography.io")]),
+            critical=False,
         ).not_valid_before(
             not_valid_before
         ).not_valid_after(
@@ -952,6 +955,12 @@
                 x509.BasicConstraints(ca=False, path_length=None), True,
             )
 
+    def test_add_unsupported_extension(self):
+        builder = x509.CertificateBuilder()
+
+        with pytest.raises(NotImplementedError):
+            builder.add_extension(object(), False)
+
 
 @pytest.mark.requires_backend_interface(interface=X509Backend)
 class TestCertificateSigningRequestBuilder(object):