Merge pull request #2036 from major/master
Added a repr() method to x509._Certificate
diff --git a/AUTHORS.rst b/AUTHORS.rst
index 7e7b94d..5f5e1a4 100644
--- a/AUTHORS.rst
+++ b/AUTHORS.rst
@@ -24,3 +24,4 @@
* Steven Buss <steven.buss@gmail.com> (1FB9 2EC1 CF93 DFD6 B47F F583 B1A5 6C22 290D A4C3)
* Andre Caron <andre.l.caron@gmail.com>
* Jiangge Zhang <tonyseek@gmail.com> (BBEC 782B 015F 71B1 5FF7 EACA 1A8C AA98 255F 5000)
+* Major Hayden <major@mhtx.net> (1BF9 9264 9596 0033 698C 252B 7370 51E0 C101 1FB1)
diff --git a/src/cryptography/hazmat/backends/openssl/x509.py b/src/cryptography/hazmat/backends/openssl/x509.py
index 38dc8e7..a03414c 100644
--- a/src/cryptography/hazmat/backends/openssl/x509.py
+++ b/src/cryptography/hazmat/backends/openssl/x509.py
@@ -159,6 +159,9 @@
self._backend = backend
self._x509 = x509
+ def __repr__(self):
+ return "<Certificate(subject={0}, ...)>".format(self.subject)
+
def __eq__(self, other):
if not isinstance(other, x509.Certificate):
return NotImplemented
diff --git a/tests/test_x509.py b/tests/test_x509.py
index 547aa58..cf3499b 100644
--- a/tests/test_x509.py
+++ b/tests/test_x509.py
@@ -450,6 +450,39 @@
serialized = cert.public_bytes(encoding)
assert serialized == cert_bytes
+ def test_certificate_repr(self, backend):
+ cert = _load_cert(
+ os.path.join(
+ "x509", "cryptography.io.pem"
+ ),
+ x509.load_pem_x509_certificate,
+ backend
+ )
+ if six.PY3:
+ assert repr(cert) == (
+ "<Certificate(subject=<Name([<NameAttribute(oid=<ObjectIdentif"
+ "ier(oid=2.5.4.11, name=organizationalUnitName)>, value='GT487"
+ "42965')>, <NameAttribute(oid=<ObjectIdentifier(oid=2.5.4.11, "
+ "name=organizationalUnitName)>, value='See www.rapidssl.com/re"
+ "sources/cps (c)14')>, <NameAttribute(oid=<ObjectIdentifier(oi"
+ "d=2.5.4.11, name=organizationalUnitName)>, value='Domain Cont"
+ "rol Validated - RapidSSL(R)')>, <NameAttribute(oid=<ObjectIde"
+ "ntifier(oid=2.5.4.3, name=commonName)>, value='www.cryptograp"
+ "hy.io')>])>, ...)>"
+ )
+ else:
+ assert repr(cert) == (
+ "<Certificate(subject=<Name([<NameAttribute(oid=<ObjectIdentif"
+ "ier(oid=2.5.4.11, name=organizationalUnitName)>, value=u'GT48"
+ "742965')>, <NameAttribute(oid=<ObjectIdentifier(oid=2.5.4.11,"
+ " name=organizationalUnitName)>, value=u'See www.rapidssl.com/"
+ "resources/cps (c)14')>, <NameAttribute(oid=<ObjectIdentifier("
+ "oid=2.5.4.11, name=organizationalUnitName)>, value=u'Domain C"
+ "ontrol Validated - RapidSSL(R)')>, <NameAttribute(oid=<Object"
+ "Identifier(oid=2.5.4.3, name=commonName)>, value=u'www.crypto"
+ "graphy.io')>])>, ...)>"
+ )
+
@pytest.mark.requires_backend_interface(interface=RSABackend)
@pytest.mark.requires_backend_interface(interface=X509Backend)