commit e2dccec0c3087809ff3a045b2d1032f655a59004
author Xinan Lin <tristan-lin@users.noreply.github.com> Fri Dec 07 05:28:33 2018 +0900
committer Thea Flowers <theaflowers@google.com> Thu Dec 06 12:28:33 2018 -0800
tree 6c2a71ee64ba6c5caaf5663931236ce5db954573
parent fef743a41e8f0e533469d621567f322a5f8465be

Add client-side limit for batch requests (#585)

tests/test_http.py

diff --git a/tests/test_http.py b/tests/test_http.py
index e381294..3e23ed4 100644
--- a/tests/test_http.py
+++ b/tests/test_http.py
@@ -1192,6 +1192,21 @@
     batch.add(self.request1, request_id='1')
     self.assertRaises(KeyError, batch.add, self.request1, request_id='1')
 
+  def test_add_fail_for_over_limit(self):
+    from googleapiclient.http import MAX_BATCH_LIMIT
+
+    batch = BatchHttpRequest()
+    for i in xrange(0, MAX_BATCH_LIMIT):
+      batch.add(HttpRequest(
+        None,
+        None,
+        'https://www.googleapis.com/someapi/v1/collection/?foo=bar',
+        method='POST',
+        body='{}',
+        headers={'content-type': 'application/json'})
+      )
+    self.assertRaises(BatchError, batch.add, self.request1)
+
   def test_add_fail_for_resumable(self):
     batch = BatchHttpRequest()