commit 0c4e0372a36a2389da1d661690d9358793f63829
author Dean Moldovan <dean0x7d@gmail.com> Sat Apr 29 21:31:06 2017 +0200
committer Dean Moldovan <dean0x7d@gmail.com> Mon May 08 01:53:07 2017 +0200
tree 40506586e5bb98a5f08a8e03afc508702fea622b
parent 36f0a15a49658da03c58ca42e88fe156b56429af

Improve PYBIND11_DEPRECATED by showing the message on all compilers

GCC supports `deprecated(msg)` since v4.5 and VS supports the standard
[[deprecated(msg)]] since 2015 RTM.

The deprecated constructor change from `= default` to `{}` is
a workaround for a VS2015 bug.

include/pybind11/attr.h

diff --git a/include/pybind11/attr.h b/include/pybind11/attr.h
index bcd69a8..25c7cb3 100644
--- a/include/pybind11/attr.h
+++ b/include/pybind11/attr.h
@@ -58,7 +58,7 @@
     handle value;
 
     PYBIND11_DEPRECATED("py::metaclass() is no longer required. It's turned on by default now.")
-    metaclass() = default;
+    metaclass() {}
 
     /// Override pybind11's default metaclass
     explicit metaclass(handle value) : value(value) { }

include/pybind11/common.h

diff --git a/include/pybind11/common.h b/include/pybind11/common.h
index 6df39f8..58fc205 100644
--- a/include/pybind11/common.h
+++ b/include/pybind11/common.h
@@ -69,14 +69,10 @@
 #  define PYBIND11_NOINLINE __attribute__ ((noinline))
 #endif
 
-#if defined(PYBIND11_CPP14)
+#if defined(PYBIND11_CPP14) || defined(_MSC_VER)
 #  define PYBIND11_DEPRECATED(reason) [[deprecated(reason)]]
-#elif defined(__clang__)
+#else
 #  define PYBIND11_DEPRECATED(reason) __attribute__((deprecated(reason)))
-#elif defined(__GNUG__)
-#  define PYBIND11_DEPRECATED(reason) __attribute__((deprecated))
-#elif defined(_MSC_VER)
-#  define PYBIND11_DEPRECATED(reason) __declspec(deprecated)
 #endif
 
 #define PYBIND11_VERSION_MAJOR 2