commit 1f53c373e44ab80a1a3d9b0dbc6c4e8dd824e9c1
author Henry Schreiner <henryschreineriii@gmail.com> Thu Jul 23 22:55:29 2020 -0400
committer Henry Schreiner <HenrySchreinerIII@gmail.com> Sun Jul 26 09:25:27 2020 -0400
tree c5c039d75c2c5569d9c17c35908a6a139b07f077
parent e428a7f6b89625eb153f5346fe85a656803b92a2

fix: C++17 mode on Clang may error

tools/pybind11Tools.cmake

diff --git a/tools/pybind11Tools.cmake b/tools/pybind11Tools.cmake
index a3603ab..be536e6 100644
--- a/tools/pybind11Tools.cmake
+++ b/tools/pybind11Tools.cmake
@@ -224,6 +224,14 @@
     endif()
   endif()
 
+  # Python 2 doesn't really support C++17, Clang warns/errors over it
+  if(CMAKE_CXX_STANDARD
+     AND CMAKE_CXX_COMPILER_ID MATCHES "Clang"
+     AND PYTHON_VERSION VERSION_LESS 3.0
+     AND NOT CMAKE_CXX_STANDARD LESS 17)
+       target_compile_options(${target_name} PUBLIC -Wno-register)
+  endif()
+
   if(ARG_NO_EXTRAS)
     return()
   endif()