commit 5b4751af269afab9a2e40a92b486bd29214f352b
author Stephen Larew <slarew@users.noreply.github.com> Tue Aug 27 08:05:47 2019 -0700
committer Wenzel Jakob <wenzel.jakob@epfl.ch> Tue Aug 27 17:05:47 2019 +0200
tree 9d47a15e2feee2982d8861128143a0d02c1d5269
parent 8f5a8ab4ac693efc9610aba1e3bb1f5e0d711533

Add const to buffer:request() (#1890)

include/pybind11/pytypes.h

diff --git a/include/pybind11/pytypes.h b/include/pybind11/pytypes.h
index 78a604e..96eab96 100644
--- a/include/pybind11/pytypes.h
+++ b/include/pybind11/pytypes.h
@@ -1312,7 +1312,7 @@
 public:
     PYBIND11_OBJECT_DEFAULT(buffer, object, PyObject_CheckBuffer)
 
-    buffer_info request(bool writable = false) {
+    buffer_info request(bool writable = false) const {
         int flags = PyBUF_STRIDES | PyBUF_FORMAT;
         if (writable) flags |= PyBUF_WRITABLE;
         Py_buffer *view = new Py_buffer();

tests/test_buffers.cpp

diff --git a/tests/test_buffers.cpp b/tests/test_buffers.cpp
index 5199cf6..433dfee 100644
--- a/tests/test_buffers.cpp
+++ b/tests/test_buffers.cpp
@@ -78,7 +78,7 @@
     py::class_<Matrix>(m, "Matrix", py::buffer_protocol())
         .def(py::init<ssize_t, ssize_t>())
         /// Construct from a buffer
-        .def(py::init([](py::buffer b) {
+        .def(py::init([](py::buffer const b) {
             py::buffer_info info = b.request();
             if (info.format != py::format_descriptor<float>::format() || info.ndim != 2)
                 throw std::runtime_error("Incompatible buffer format!");