commit 731a9f6ceaf061a7630b4d859515bf3f2ebe3892
author Jason Rhinelander <jason@imaginary.ca> Tue May 16 09:38:58 2017 -0400
committer Jason Rhinelander <jason@imaginary.ca> Tue May 16 09:38:58 2017 -0400
tree cdfe319854e47b1cf05c954fb383ad7546f29bc7
parent 4567f1f82a72726b1c03cf0927212ade372c7f10

Fix Py_buffer leak on GetBuffer failure

Fixes #852.

include/pybind11/pytypes.h

diff --git a/include/pybind11/pytypes.h b/include/pybind11/pytypes.h
index 8093ead..8a8499c 100644
--- a/include/pybind11/pytypes.h
+++ b/include/pybind11/pytypes.h
@@ -1155,8 +1155,10 @@
         int flags = PyBUF_STRIDES | PyBUF_FORMAT;
         if (writable) flags |= PyBUF_WRITABLE;
         Py_buffer *view = new Py_buffer();
-        if (PyObject_GetBuffer(m_ptr, view, flags) != 0)
+        if (PyObject_GetBuffer(m_ptr, view, flags) != 0) {
+            delete view;
             throw error_already_set();
+        }
         return buffer_info(view);
     }
 };