tree 5805bedf41940c9996564cd2c4e00124d4a7371d
parent fd47779f40120e4257856ace044a91c3948ee98e
author Jason Rhinelander <jason@imaginary.ca> 1499869089 -0400
committer Jason Rhinelander <jason@imaginary.ca> 1499870898 -0400

Fix past-the-end dereference in values_and_holders

The value and holder iterator code had a past-the-end iterator
dereference.  While of course invalid, the dereference didn't actually
cause any problems (which is why it wasn't caught before) because the
dereferenced value is never actually used and `vector` implementations
appear to allow dereferencing the past-the-end iterator.  Under a MSVC
debug build, however, it fails a debug assertion and aborts.

This amends the iterator to just store and use a pointer to the vector
(rather than adding a second past-the-end iterator member), checking the
type index against the type vector size.