Wenzel Jakob | 17cdb06 | 2016-03-10 13:24:10 +0100 | [diff] [blame] | 1 | /* |
Dean Moldovan | a0c1ccf | 2016-08-12 13:50:00 +0200 | [diff] [blame] | 2 | tests/test_issues.cpp -- collection of testcases for miscellaneous issues |
Wenzel Jakob | 17cdb06 | 2016-03-10 13:24:10 +0100 | [diff] [blame] | 3 | |
Wenzel Jakob | 8cb6cb3 | 2016-04-17 20:21:41 +0200 | [diff] [blame] | 4 | Copyright (c) 2016 Wenzel Jakob <wenzel.jakob@epfl.ch> |
Wenzel Jakob | 17cdb06 | 2016-03-10 13:24:10 +0100 | [diff] [blame] | 5 | |
| 6 | All rights reserved. Use of this source code is governed by a |
| 7 | BSD-style license that can be found in the LICENSE file. |
| 8 | */ |
| 9 | |
Dean Moldovan | a0c1ccf | 2016-08-12 13:50:00 +0200 | [diff] [blame] | 10 | #include "pybind11_tests.h" |
| 11 | #include "constructor_stats.h" |
Wenzel Jakob | f54ded7 | 2016-04-20 17:00:57 +0200 | [diff] [blame] | 12 | #include <pybind11/stl.h> |
Jason Rhinelander | 1b05ce5 | 2016-08-09 17:57:59 -0400 | [diff] [blame] | 13 | #include <pybind11/operators.h> |
Wenzel Jakob | 17cdb06 | 2016-03-10 13:24:10 +0100 | [diff] [blame] | 14 | |
Wenzel Jakob | d2b628b | 2016-04-30 23:02:39 +0200 | [diff] [blame] | 15 | PYBIND11_DECLARE_HOLDER_TYPE(T, std::shared_ptr<T>); |
| 16 | |
Jason Rhinelander | 3f58937 | 2016-08-07 13:05:26 -0400 | [diff] [blame] | 17 | #define TRACKERS(CLASS) CLASS() { print_default_created(this); } ~CLASS() { print_destroyed(this); } |
| 18 | struct NestABase { int value = -2; TRACKERS(NestABase) }; |
| 19 | struct NestA : NestABase { int value = 3; NestA& operator+=(int i) { value += i; return *this; } TRACKERS(NestA) }; |
| 20 | struct NestB { NestA a; int value = 4; NestB& operator-=(int i) { value -= i; return *this; } TRACKERS(NestB) }; |
| 21 | struct NestC { NestB b; int value = 5; NestC& operator*=(int i) { value *= i; return *this; } TRACKERS(NestC) }; |
| 22 | |
Wenzel Jakob | 382484a | 2016-09-10 15:28:37 +0900 | [diff] [blame^] | 23 | /// #393 |
| 24 | class OpTest1 {}; |
| 25 | class OpTest2 {}; |
| 26 | |
| 27 | OpTest1 operator+(const OpTest1 &, const OpTest1 &) { |
| 28 | py::print("Add OpTest1 with OpTest1"); |
| 29 | return OpTest1(); |
| 30 | } |
| 31 | OpTest2 operator+(const OpTest2 &, const OpTest2 &) { |
| 32 | py::print("Add OpTest2 with OpTest2"); |
| 33 | return OpTest2(); |
| 34 | } |
| 35 | OpTest2 operator+(const OpTest2 &, const OpTest1 &) { |
| 36 | py::print("Add OpTest2 with OpTest1"); |
| 37 | return OpTest2(); |
| 38 | } |
| 39 | |
Wenzel Jakob | 17cdb06 | 2016-03-10 13:24:10 +0100 | [diff] [blame] | 40 | void init_issues(py::module &m) { |
| 41 | py::module m2 = m.def_submodule("issues"); |
| 42 | |
Wenzel Jakob | 9059bd8 | 2016-05-01 10:39:45 +0200 | [diff] [blame] | 43 | #if !defined(_MSC_VER) |
| 44 | // Visual Studio 2015 currently cannot compile this test |
| 45 | // (see the comment in type_caster_base::make_copy_constructor) |
| 46 | // #70 compilation issue if operator new is not public |
| 47 | class NonConstructible { private: void *operator new(size_t bytes) throw(); }; |
| 48 | py::class_<NonConstructible>(m, "Foo"); |
Wenzel Jakob | bd57eb4 | 2016-05-01 14:42:20 +0200 | [diff] [blame] | 49 | m2.def("getstmt", []() -> NonConstructible * { return nullptr; }, |
Wenzel Jakob | 9059bd8 | 2016-05-01 10:39:45 +0200 | [diff] [blame] | 50 | py::return_value_policy::reference); |
| 51 | #endif |
| 52 | |
Wenzel Jakob | 17cdb06 | 2016-03-10 13:24:10 +0100 | [diff] [blame] | 53 | // #137: const char* isn't handled properly |
Dean Moldovan | 665e880 | 2016-08-12 22:28:31 +0200 | [diff] [blame] | 54 | m2.def("print_cchar", [](const char *s) { return std::string(s); }); |
Wenzel Jakob | d3349af | 2016-03-26 23:04:10 +0100 | [diff] [blame] | 55 | |
| 56 | // #150: char bindings broken |
Dean Moldovan | 665e880 | 2016-08-12 22:28:31 +0200 | [diff] [blame] | 57 | m2.def("print_char", [](char c) { return std::string(1, c); }); |
Wenzel Jakob | f5c154a | 2016-04-11 18:13:08 +0200 | [diff] [blame] | 58 | |
| 59 | // #159: virtual function dispatch has problems with similar-named functions |
Dean Moldovan | 665e880 | 2016-08-12 22:28:31 +0200 | [diff] [blame] | 60 | struct Base { virtual std::string dispatch() const { |
Wenzel Jakob | d2b628b | 2016-04-30 23:02:39 +0200 | [diff] [blame] | 61 | /* for some reason MSVC2015 can't compile this if the function is pure virtual */ |
Dean Moldovan | 665e880 | 2016-08-12 22:28:31 +0200 | [diff] [blame] | 62 | return {}; |
Wenzel Jakob | d2b628b | 2016-04-30 23:02:39 +0200 | [diff] [blame] | 63 | }; }; |
Wenzel Jakob | e707497 | 2016-04-30 22:44:00 +0200 | [diff] [blame] | 64 | |
| 65 | struct DispatchIssue : Base { |
Dean Moldovan | 665e880 | 2016-08-12 22:28:31 +0200 | [diff] [blame] | 66 | virtual std::string dispatch() const { |
| 67 | PYBIND11_OVERLOAD_PURE(std::string, Base, dispatch, /* no arguments */); |
Wenzel Jakob | e707497 | 2016-04-30 22:44:00 +0200 | [diff] [blame] | 68 | } |
| 69 | }; |
| 70 | |
Jason Rhinelander | 5fffe20 | 2016-09-06 12:17:06 -0400 | [diff] [blame] | 71 | py::class_<Base, DispatchIssue>(m2, "DispatchIssue") |
Wenzel Jakob | f54ded7 | 2016-04-20 17:00:57 +0200 | [diff] [blame] | 72 | .def(py::init<>()) |
Wenzel Jakob | f5c154a | 2016-04-11 18:13:08 +0200 | [diff] [blame] | 73 | .def("dispatch", &Base::dispatch); |
| 74 | |
Dean Moldovan | 665e880 | 2016-08-12 22:28:31 +0200 | [diff] [blame] | 75 | m2.def("dispatch_issue_go", [](const Base * b) { return b->dispatch(); }); |
Wenzel Jakob | e707497 | 2016-04-30 22:44:00 +0200 | [diff] [blame] | 76 | |
| 77 | struct Placeholder { int i; Placeholder(int i) : i(i) { } }; |
Wenzel Jakob | f54ded7 | 2016-04-20 17:00:57 +0200 | [diff] [blame] | 78 | |
| 79 | py::class_<Placeholder>(m2, "Placeholder") |
Wenzel Jakob | dbe43ff | 2016-04-21 12:21:14 +0200 | [diff] [blame] | 80 | .def(py::init<int>()) |
Wenzel Jakob | f54ded7 | 2016-04-20 17:00:57 +0200 | [diff] [blame] | 81 | .def("__repr__", [](const Placeholder &p) { return "Placeholder[" + std::to_string(p.i) + "]"; }); |
| 82 | |
| 83 | // #171: Can't return reference wrappers (or STL datastructures containing them) |
Wenzel Jakob | 85f07e1 | 2016-09-04 23:00:49 +0900 | [diff] [blame] | 84 | m2.def("return_vec_of_reference_wrapper", [](std::reference_wrapper<Placeholder> p4) { |
Wenzel Jakob | f54ded7 | 2016-04-20 17:00:57 +0200 | [diff] [blame] | 85 | Placeholder *p1 = new Placeholder{1}; |
| 86 | Placeholder *p2 = new Placeholder{2}; |
Wenzel Jakob | dbe43ff | 2016-04-21 12:21:14 +0200 | [diff] [blame] | 87 | Placeholder *p3 = new Placeholder{3}; |
Wenzel Jakob | f54ded7 | 2016-04-20 17:00:57 +0200 | [diff] [blame] | 88 | std::vector<std::reference_wrapper<Placeholder>> v; |
| 89 | v.push_back(std::ref(*p1)); |
| 90 | v.push_back(std::ref(*p2)); |
| 91 | v.push_back(std::ref(*p3)); |
Wenzel Jakob | dbe43ff | 2016-04-21 12:21:14 +0200 | [diff] [blame] | 92 | v.push_back(p4); |
Wenzel Jakob | f54ded7 | 2016-04-20 17:00:57 +0200 | [diff] [blame] | 93 | return v; |
| 94 | }); |
Wenzel Jakob | 6ca6e82 | 2016-04-27 14:33:52 +0200 | [diff] [blame] | 95 | |
| 96 | // #181: iterator passthrough did not compile |
| 97 | m2.def("iterator_passthrough", [](py::iterator s) -> py::iterator { |
| 98 | return py::make_iterator(std::begin(s), std::end(s)); |
| 99 | }); |
Wenzel Jakob | d2b628b | 2016-04-30 23:02:39 +0200 | [diff] [blame] | 100 | |
| 101 | // #187: issue involving std::shared_ptr<> return value policy & garbage collection |
| 102 | struct ElementBase { virtual void foo() { } /* Force creation of virtual table */ }; |
| 103 | struct ElementA : ElementBase { |
| 104 | ElementA(int v) : v(v) { } |
| 105 | int value() { return v; } |
| 106 | int v; |
| 107 | }; |
| 108 | |
| 109 | struct ElementList { |
| 110 | void add(std::shared_ptr<ElementBase> e) { l.push_back(e); } |
| 111 | std::vector<std::shared_ptr<ElementBase>> l; |
| 112 | }; |
| 113 | |
| 114 | py::class_<ElementBase, std::shared_ptr<ElementBase>> (m2, "ElementBase"); |
| 115 | |
Jason Rhinelander | 6b52c83 | 2016-09-06 12:27:00 -0400 | [diff] [blame] | 116 | py::class_<ElementA, ElementBase, std::shared_ptr<ElementA>>(m2, "ElementA") |
Wenzel Jakob | d2b628b | 2016-04-30 23:02:39 +0200 | [diff] [blame] | 117 | .def(py::init<int>()) |
| 118 | .def("value", &ElementA::value); |
| 119 | |
| 120 | py::class_<ElementList, std::shared_ptr<ElementList>>(m2, "ElementList") |
| 121 | .def(py::init<>()) |
| 122 | .def("add", &ElementList::add) |
Wenzel Jakob | 85f07e1 | 2016-09-04 23:00:49 +0900 | [diff] [blame] | 123 | .def("get", [](ElementList &el) { |
Wenzel Jakob | d2b628b | 2016-04-30 23:02:39 +0200 | [diff] [blame] | 124 | py::list list; |
| 125 | for (auto &e : el.l) |
| 126 | list.append(py::cast(e)); |
| 127 | return list; |
| 128 | }); |
Wenzel Jakob | bd57eb4 | 2016-05-01 14:42:20 +0200 | [diff] [blame] | 129 | |
| 130 | // (no id): should not be able to pass 'None' to a reference argument |
Dean Moldovan | 99dbdc1 | 2016-08-19 13:45:36 +0200 | [diff] [blame] | 131 | m2.def("get_element", [](ElementA &el) { return el.value(); }); |
Wenzel Jakob | 3f200fa | 2016-05-17 15:35:29 +0200 | [diff] [blame] | 132 | |
| 133 | // (no id): don't cast doubles to ints |
| 134 | m2.def("expect_float", [](float f) { return f; }); |
| 135 | m2.def("expect_int", [](int i) { return i; }); |
Wenzel Jakob | 86d825f | 2016-05-26 13:19:27 +0200 | [diff] [blame] | 136 | |
| 137 | // (no id): don't invoke Python dispatch code when instantiating C++ |
| 138 | // classes that were not extended on the Python side |
| 139 | struct A { |
| 140 | virtual ~A() {} |
Dean Moldovan | 81511be | 2016-09-07 00:50:10 +0200 | [diff] [blame] | 141 | virtual void f() { py::print("A.f()"); } |
Wenzel Jakob | 86d825f | 2016-05-26 13:19:27 +0200 | [diff] [blame] | 142 | }; |
| 143 | |
| 144 | struct PyA : A { |
Dean Moldovan | 81511be | 2016-09-07 00:50:10 +0200 | [diff] [blame] | 145 | PyA() { py::print("PyA.PyA()"); } |
Wenzel Jakob | 86d825f | 2016-05-26 13:19:27 +0200 | [diff] [blame] | 146 | |
| 147 | void f() override { |
Dean Moldovan | 81511be | 2016-09-07 00:50:10 +0200 | [diff] [blame] | 148 | py::print("PyA.f()"); |
Wenzel Jakob | 86d825f | 2016-05-26 13:19:27 +0200 | [diff] [blame] | 149 | PYBIND11_OVERLOAD(void, A, f); |
| 150 | } |
| 151 | }; |
| 152 | |
| 153 | auto call_f = [](A *a) { a->f(); }; |
| 154 | |
Wenzel Jakob | fb0e2e5 | 2016-07-01 14:54:24 +0200 | [diff] [blame] | 155 | pybind11::class_<A, std::unique_ptr<A>, PyA>(m2, "A") |
| 156 | .def(py::init<>()) |
| 157 | .def("f", &A::f); |
Wenzel Jakob | 86d825f | 2016-05-26 13:19:27 +0200 | [diff] [blame] | 158 | |
Wenzel Jakob | fb0e2e5 | 2016-07-01 14:54:24 +0200 | [diff] [blame] | 159 | m2.def("call_f", call_f); |
Wenzel Jakob | 38d8b8c | 2016-05-31 09:53:28 +0200 | [diff] [blame] | 160 | |
| 161 | try { |
| 162 | py::class_<Placeholder>(m2, "Placeholder"); |
| 163 | throw std::logic_error("Expected an exception!"); |
Dean Moldovan | f2b36c2 | 2016-06-01 23:03:10 +0200 | [diff] [blame] | 164 | } catch (std::runtime_error &) { |
Wenzel Jakob | 38d8b8c | 2016-05-31 09:53:28 +0200 | [diff] [blame] | 165 | /* All good */ |
| 166 | } |
Jason Rhinelander | 4e45e18 | 2016-07-17 17:43:00 -0400 | [diff] [blame] | 167 | |
| 168 | // Issue #283: __str__ called on uninitialized instance when constructor arguments invalid |
| 169 | class StrIssue { |
| 170 | public: |
| 171 | StrIssue(int i) : val{i} {} |
| 172 | StrIssue() : StrIssue(-1) {} |
| 173 | int value() const { return val; } |
| 174 | private: |
| 175 | int val; |
| 176 | }; |
| 177 | py::class_<StrIssue> si(m2, "StrIssue"); |
| 178 | si .def(py::init<int>()) |
| 179 | .def(py::init<>()) |
Dean Moldovan | 99dbdc1 | 2016-08-19 13:45:36 +0200 | [diff] [blame] | 180 | .def("__str__", [](const StrIssue &si) { return "StrIssue[" + std::to_string(si.value()) + "]"; }) |
Jason Rhinelander | 4e45e18 | 2016-07-17 17:43:00 -0400 | [diff] [blame] | 181 | ; |
| 182 | |
Jason Rhinelander | 1b05ce5 | 2016-08-09 17:57:59 -0400 | [diff] [blame] | 183 | // Issue #328: first member in a class can't be used in operators |
Jason Rhinelander | f2ecd89 | 2016-08-10 12:08:04 -0400 | [diff] [blame] | 184 | py::class_<NestABase>(m2, "NestABase").def(py::init<>()).def_readwrite("value", &NestABase::value); |
| 185 | py::class_<NestA>(m2, "NestA").def(py::init<>()).def(py::self += int()) |
| 186 | .def("as_base", [](NestA &a) -> NestABase& { return (NestABase&) a; }, py::return_value_policy::reference_internal); |
Jason Rhinelander | 1b05ce5 | 2016-08-09 17:57:59 -0400 | [diff] [blame] | 187 | py::class_<NestB>(m2, "NestB").def(py::init<>()).def(py::self -= int()).def_readwrite("a", &NestB::a); |
| 188 | py::class_<NestC>(m2, "NestC").def(py::init<>()).def(py::self *= int()).def_readwrite("b", &NestC::b); |
Dean Moldovan | 665e880 | 2016-08-12 22:28:31 +0200 | [diff] [blame] | 189 | m2.def("get_NestA", [](const NestA &a) { return a.value; }); |
| 190 | m2.def("get_NestB", [](const NestB &b) { return b.value; }); |
| 191 | m2.def("get_NestC", [](const NestC &c) { return c.value; }); |
Wenzel Jakob | c84b37b | 2016-09-07 00:47:17 +0900 | [diff] [blame] | 192 | |
| 193 | // Issue 389: r_v_p::move should fall-through to copy on non-movable objects |
| 194 | class MoveIssue1 { |
| 195 | public: |
| 196 | MoveIssue1(int v) : v{v} {} |
Dean Moldovan | 81511be | 2016-09-07 00:50:10 +0200 | [diff] [blame] | 197 | MoveIssue1(const MoveIssue1 &c) { v = c.v; } |
Wenzel Jakob | c84b37b | 2016-09-07 00:47:17 +0900 | [diff] [blame] | 198 | MoveIssue1(MoveIssue1 &&) = delete; |
| 199 | int v; |
| 200 | }; |
| 201 | class MoveIssue2 { |
| 202 | public: |
| 203 | MoveIssue2(int v) : v{v} {} |
| 204 | MoveIssue2(MoveIssue2 &&) = default; |
| 205 | int v; |
| 206 | }; |
| 207 | py::class_<MoveIssue1>(m2, "MoveIssue1").def(py::init<int>()).def_readwrite("value", &MoveIssue1::v); |
| 208 | py::class_<MoveIssue2>(m2, "MoveIssue2").def(py::init<int>()).def_readwrite("value", &MoveIssue2::v); |
| 209 | m2.def("get_moveissue1", [](int i) -> MoveIssue1 * { return new MoveIssue1(i); }, py::return_value_policy::move); |
| 210 | m2.def("get_moveissue2", [](int i) { return MoveIssue2(i); }, py::return_value_policy::move); |
Jason Rhinelander | 56f7177 | 2016-09-07 13:32:49 -0400 | [diff] [blame] | 211 | |
Jason Rhinelander | 9c6859e | 2016-09-08 11:03:08 -0400 | [diff] [blame] | 212 | // Issues 392/397: overridding reference-returning functions |
Jason Rhinelander | 56f7177 | 2016-09-07 13:32:49 -0400 | [diff] [blame] | 213 | class OverrideTest { |
| 214 | public: |
Jason Rhinelander | 9c6859e | 2016-09-08 11:03:08 -0400 | [diff] [blame] | 215 | struct A { std::string value = "hi"; }; |
| 216 | std::string v; |
Jason Rhinelander | 56f7177 | 2016-09-07 13:32:49 -0400 | [diff] [blame] | 217 | A a; |
Jason Rhinelander | 9c6859e | 2016-09-08 11:03:08 -0400 | [diff] [blame] | 218 | explicit OverrideTest(const std::string &v) : v{v} {} |
| 219 | virtual std::string str_value() { return v; } |
| 220 | virtual std::string &str_ref() { return v; } |
Jason Rhinelander | 56f7177 | 2016-09-07 13:32:49 -0400 | [diff] [blame] | 221 | virtual A A_value() { return a; } |
| 222 | virtual A &A_ref() { return a; } |
| 223 | }; |
| 224 | class PyOverrideTest : public OverrideTest { |
| 225 | public: |
| 226 | using OverrideTest::OverrideTest; |
Jason Rhinelander | 9c6859e | 2016-09-08 11:03:08 -0400 | [diff] [blame] | 227 | std::string str_value() override { PYBIND11_OVERLOAD(std::string, OverrideTest, str_value); } |
Jason Rhinelander | c03db9b | 2016-09-07 13:38:32 -0400 | [diff] [blame] | 228 | // Not allowed (uncommenting should hit a static_assert failure): we can't get a reference |
| 229 | // to a python numeric value, since we only copy values in the numeric type caster: |
Jason Rhinelander | 9c6859e | 2016-09-08 11:03:08 -0400 | [diff] [blame] | 230 | // std::string &str_ref() override { PYBIND11_OVERLOAD(std::string &, OverrideTest, str_ref); } |
| 231 | // But we can work around it like this: |
| 232 | private: |
| 233 | std::string _tmp; |
| 234 | std::string str_ref_helper() { PYBIND11_OVERLOAD(std::string, OverrideTest, str_ref); } |
| 235 | public: |
| 236 | std::string &str_ref() override { return _tmp = str_ref_helper(); } |
| 237 | |
Jason Rhinelander | 56f7177 | 2016-09-07 13:32:49 -0400 | [diff] [blame] | 238 | A A_value() override { PYBIND11_OVERLOAD(A, OverrideTest, A_value); } |
| 239 | A &A_ref() override { PYBIND11_OVERLOAD(A &, OverrideTest, A_ref); } |
| 240 | }; |
| 241 | py::class_<OverrideTest::A>(m2, "OverrideTest_A") |
| 242 | .def_readwrite("value", &OverrideTest::A::value); |
| 243 | py::class_<OverrideTest, PyOverrideTest>(m2, "OverrideTest") |
Jason Rhinelander | 9c6859e | 2016-09-08 11:03:08 -0400 | [diff] [blame] | 244 | .def(py::init<const std::string &>()) |
| 245 | .def("str_value", &OverrideTest::str_value) |
| 246 | // .def("str_ref", &OverrideTest::str_ref) |
Jason Rhinelander | 56f7177 | 2016-09-07 13:32:49 -0400 | [diff] [blame] | 247 | .def("A_value", &OverrideTest::A_value) |
| 248 | .def("A_ref", &OverrideTest::A_ref); |
Jason Rhinelander | c03db9b | 2016-09-07 13:38:32 -0400 | [diff] [blame] | 249 | |
Wenzel Jakob | 382484a | 2016-09-10 15:28:37 +0900 | [diff] [blame^] | 250 | /// Issue 393: need to return NotSupported to ensure correct arithmetic operator behavior |
| 251 | py::class_<OpTest1>(m2, "OpTest1") |
| 252 | .def(py::init<>()) |
| 253 | .def(py::self + py::self); |
| 254 | |
| 255 | py::class_<OpTest2>(m2, "OpTest2") |
| 256 | .def(py::init<>()) |
| 257 | .def(py::self + py::self) |
| 258 | .def("__add__", [](const OpTest2& c2, const OpTest1& c1) { return c2 + c1; }) |
| 259 | .def("__radd__", [](const OpTest2& c2, const OpTest1& c1) { return c2 + c1; }); |
Wenzel Jakob | bd57eb4 | 2016-05-01 14:42:20 +0200 | [diff] [blame] | 260 | } |
Jason Rhinelander | 52f4be8 | 2016-09-03 14:54:22 -0400 | [diff] [blame] | 261 | |
| 262 | // MSVC workaround: trying to use a lambda here crashes MSCV |
| 263 | test_initializer issues(&init_issues); |