commit 026f6643c72efc992a8498784f3dfa4e083dea81
author Jean-Paul Calderone <exarkun@divmod.com> Wed Apr 20 18:59:33 2011 -0400
committer Jean-Paul Calderone <exarkun@divmod.com> Wed Apr 20 18:59:33 2011 -0400
tree 73894d17039835163b8cd0c16dc8edd044cf52c4
parent 57e604a872cb60bb74260ae677fb2cadb0bdbe82

Fix a lot of reference counting bugs introduced by stupid copy/pasting

OpenSSL/crypto/crypto.c

diff --git a/OpenSSL/crypto/crypto.c b/OpenSSL/crypto/crypto.c
index a7d8cc2..8bea656 100644
--- a/OpenSSL/crypto/crypto.c
+++ b/OpenSSL/crypto/crypto.c
@@ -839,7 +839,7 @@
     if (c_api_object != NULL) {
         /* PyModule_AddObject steals a reference.
          */
-        Py_INCREF((PyObject *)&c_api_object);
+        Py_INCREF(c_api_object);
         PyModule_AddObject(module, "_C_API", c_api_object);
     }
 #endif
@@ -850,7 +850,7 @@
 
     /* PyModule_AddObject steals a reference.
      */
-    Py_INCREF((PyObject *)&crypto_Error);
+    Py_INCREF(crypto_Error);
     if (PyModule_AddObject(module, "Error", crypto_Error) != 0)
         goto error;
 

OpenSSL/rand/rand.c

diff --git a/OpenSSL/rand/rand.c b/OpenSSL/rand/rand.c
index a2ffa35..8307ac6 100644
--- a/OpenSSL/rand/rand.c
+++ b/OpenSSL/rand/rand.c
@@ -290,7 +290,7 @@
 
     /* PyModule_AddObject steals a reference.
      */
-    Py_INCREF((PyObject *)&rand_Error);
+    Py_INCREF(rand_Error);
     if (PyModule_AddObject(module, "Error", rand_Error) != 0) {
         goto error;
     }

OpenSSL/ssl/ssl.c

diff --git a/OpenSSL/ssl/ssl.c b/OpenSSL/ssl/ssl.c
index f968167..0dd9871 100644
--- a/OpenSSL/ssl/ssl.c
+++ b/OpenSSL/ssl/ssl.c
@@ -142,7 +142,7 @@
     if (ssl_api_object != NULL) {
         /* PyModule_AddObject steals a reference.
          */
-        Py_INCREF((PyObject *)&ssl_Context_Type);
+        Py_INCREF(ssl_api_object);
         PyModule_AddObject(module, "_C_API", ssl_api_object);
     }
 #endif
@@ -158,7 +158,7 @@
     if (ssl_##_name == NULL)                                            \
         goto error;                                                     \
     /* PyModule_AddObject steals a reference. */                        \
-    Py_INCREF((PyObject *)&ssl_##_name);                                \
+    Py_INCREF(ssl_##_name);                                             \
     if (PyModule_AddObject(module, #_name, ssl_##_name) != 0)           \
         goto error;                                                     \
 } while (0)