incref the X509Req when returning an X509Name from get_subject which refers to it; this prevents a segfault if the X509Name outlives the X509Req; update docs to reflect this and to reflect previous similar changes which were apparently made to X509.get_subject and X509.get_issuer
diff --git a/doc/pyOpenSSL.txt b/doc/pyOpenSSL.txt
index 1501682..695c9fd 100644
--- a/doc/pyOpenSSL.txt
+++ b/doc/pyOpenSSL.txt
@@ -238,9 +238,8 @@
X509 objects have the following methods:
get_issuer()
- Return a borrowed reference to a X509Name object representing
- the issuer of the certificate. When the corresponding X509 or
- X509Req object is destroyed, this object will be invalid!
+ Return an X509Name object representing the issuer of the
+ certificate.
get_pubkey()
Return a PKey object representing the public key of the
@@ -250,9 +249,8 @@
Return the certificate serial number.
get_subject()
- Return a borrowed reference to a X509Name object representing
- the subject of the certificate. When the corresponding X509 or
- X509Req object is destroyed, this object will be invalid!
+ Return an X509Name object representing the subject of the
+ certificate.
get_version()
Return the certificate version.
@@ -341,9 +339,8 @@
certificate request.
get_subject()
- Return a borrowed reference to a X509Name object representing
- the subject of the certificate. When the corresponding X509 or
- X509Req object is destroyed, this object will be invalid!
+ Return an X509Name object representing the subject of the
+ certificate.
set_pubkey(pkey)
Set the public key of the certificate request to pkey.