commit 2fe23b0aced08ccbcec6e9f9d7239e53ee758904
author Paul Kehrer <paul.l.kehrer@gmail.com> Wed Mar 09 22:02:15 2016 -0400
committer Paul Kehrer <paul.l.kehrer@gmail.com> Wed Mar 09 22:02:15 2016 -0400
tree 47027425f16c32d09c1463545909d8fba352acd8
parent b3ba708682ab7d5832be8b893ec500e1daed0a41

fix test and a missing X509_REVOKED_dup call

src/OpenSSL/crypto.py

diff --git a/src/OpenSSL/crypto.py b/src/OpenSSL/crypto.py
index 71fafab..acc9c5c 100644
--- a/src/OpenSSL/crypto.py
+++ b/src/OpenSSL/crypto.py
@@ -1912,7 +1912,7 @@
         revoked_stack = self._crl.crl.revoked
         for i in range(_lib.sk_X509_REVOKED_num(revoked_stack)):
             revoked = _lib.sk_X509_REVOKED_value(revoked_stack, i)
-            revoked_copy = _X509_REVOKED_dup(revoked)
+            revoked_copy = _lib.Cryptography_X509_REVOKED_dup(revoked)
             pyrev = Revoked.__new__(Revoked)
             pyrev._revoked = _ffi.gc(revoked_copy, _lib.X509_REVOKED_free)
             results.append(pyrev)

tests/test_crypto.py

diff --git a/tests/test_crypto.py b/tests/test_crypto.py
index 03b94b9..e90c868 100644
--- a/tests/test_crypto.py
+++ b/tests/test_crypto.py
@@ -3186,6 +3186,8 @@
         """
         crl = CRL()
         revoked = Revoked()
+        revoked.set_serial("01")
+        revoked.set_rev_date(b"20160310020145Z")
         crl.add_revoked(revoked=revoked)
         self.assertTrue(isinstance(crl.get_revoked()[0], Revoked))