Tests for more misuses: Revoked, Revoked.get_serial, Revoked.get_reason
diff --git a/test/test_crypto.py b/test/test_crypto.py
index 9d8e65a..9a87565 100644
--- a/test/test_crypto.py
+++ b/test/test_crypto.py
@@ -1551,6 +1551,16 @@
self.assertEqual( revoked.get_reason(), None )
+ def test_construction_wrong_args(self):
+ """
+ Calling L{OpenSSL.crypto.Revoked} with any arguments results
+ in a L{TypeError} being raised.
+ """
+ self.assertRaises(TypeError, Revoked, None)
+ self.assertRaises(TypeError, Revoked, 1)
+ self.assertRaises(TypeError, Revoked, "foo")
+
+
def test_serial(self):
"""
Confirm we can set and get serial numbers from
@@ -1569,6 +1579,9 @@
self.assertRaises(ValueError, revoked.set_serial, 'pqrst')
self.assertRaises(TypeError, revoked.set_serial, 100)
+ self.assertRaises(TypeError, revoked.get_serial, 1)
+ self.assertRaises(TypeError, revoked.get_serial, None)
+ self.assertRaises(TypeError, revoked.get_serial, "")
def test_date(self):
@@ -1608,15 +1621,29 @@
self.assertEqual(revoked.get_reason(), None)
- def test_bad_reasons(self):
+ def test_set_reason_wrong_arguments(self):
"""
- Use L{OpenSSL.crypto.Revoked.set_reason} in bad ways.
+ Calling L{OpenSSL.crypto.Revoked.set_reason} with other than
+ one argument, or an argument which isn't a valid reason,
+ results in L{TypeError} or L{ValueError} being raised.
"""
revoked = Revoked()
self.assertRaises(TypeError, revoked.set_reason, 100)
self.assertRaises(ValueError, revoked.set_reason, 'blue')
+ def test_get_reason_wrong_arguments(self):
+ """
+ Calling L{OpenSSL.crypto.Revoked.get_reason} with any
+ arguments results in L{TypeError} being raised.
+ """
+ revoked = Revoked()
+ self.assertRaises(TypeError, revoked.get_reason, None)
+ self.assertRaises(TypeError, revoked.get_reason, 1)
+ self.assertRaises(TypeError, revoked.get_reason, "foo")
+
+
+
class CRLTests(TestCase):
"""
Tests for L{OpenSSL.crypto.CRL}