commit b6d7525aefde1ba13186ef4e85da51eff15b1c58
author Jean-Paul Calderone <exarkun@divmod.com> Wed Aug 11 23:55:45 2010 -0400
committer Jean-Paul Calderone <exarkun@divmod.com> Wed Aug 11 23:55:45 2010 -0400
tree faf9a1f8da1e4a57da3a24991cba69f75c12f86a
parent dfcebfcf90c39caeb33f8044e17ca5de730c2e65

fix module init return values and type initializers and unicode/bytes conversions

OpenSSL/ssl/connection.c

diff --git a/OpenSSL/ssl/connection.c b/OpenSSL/ssl/connection.c
index 9c981c6..0289876 100755
--- a/OpenSSL/ssl/connection.c
+++ b/OpenSSL/ssl/connection.c
@@ -1349,7 +1349,7 @@
 }
 
 PyTypeObject ssl_Connection_Type = {
-    PyVarObject_HEAD_INIT(&PyType_Type, 0)
+    PyOpenSSL_HEAD_INIT(&PyType_Type, 0)
     "OpenSSL.SSL.Connection",
     sizeof(ssl_ConnectionObj),
     0,

OpenSSL/ssl/context.c

diff --git a/OpenSSL/ssl/context.c b/OpenSSL/ssl/context.c
index 902d1e4..a30b51f 100644
--- a/OpenSSL/ssl/context.c
+++ b/OpenSSL/ssl/context.c
@@ -368,8 +368,16 @@
         Py_DECREF(type);
         return NULL;
     }
+
+#ifdef PY3
+    {
+        PyObject* asciiname = PyUnicode_AsASCIIString(name_attr);
+        Py_DECREF(name_attr);
+        name_attr = asciiname;
+    }
+#endif
     right_name = (PyUnicode_CheckExact(name_attr) &&
-                  strcmp(name, _PyUnicode_AsString(name_attr)) == 0);
+                  strcmp(name, PyBytes_AsString(name_attr)) == 0);
     Py_DECREF(name_attr);
     res = (PyTypeObject *)type;
     if (!right_name || res->tp_basicsize != objsize) {
@@ -1243,7 +1251,7 @@
 
 
 PyTypeObject ssl_Context_Type = {
-    PyVarObject_HEAD_INIT(&PyType_Type, 0)
+    PyOpenSSL_HEAD_INIT(&PyType_Type, 0)
     "OpenSSL.SSL.Context",
     sizeof(ssl_ContextObj),
     0,

OpenSSL/ssl/ssl.c

diff --git a/OpenSSL/ssl/ssl.c b/OpenSSL/ssl/ssl.c
index 00b9617..8ac4420 100644
--- a/OpenSSL/ssl/ssl.c
+++ b/OpenSSL/ssl/ssl.c
@@ -84,7 +84,7 @@
     module = Py_InitModule3("SSL", ssl_methods, ssl_doc);
 #endif
     if (module == NULL) {
-        return NULL;
+        PyOpenSSL_MODRETURN(NULL);
     }
 
 #ifndef PY3
@@ -196,14 +196,9 @@
     _pyOpenSSL_tstate_key = PyThread_create_key();
 #endif
 
-#ifdef PY3
-    return module;
-#endif
+    PyOpenSSL_MODRETURN(module);
 
 error:
-#ifdef PY3
-    return NULL;
-#else
+    PyOpenSSL_MODRETURN(NULL);
     ;
-#endif
 }