commit e7f334583541e1de98614e76a65b7d04e7be4979
author Ayke <aykevanlaethem@gmail.com> Wed May 16 19:18:16 2018 +0200
committer Alex Gaynor <alex.gaynor@gmail.com> Wed May 16 13:18:16 2018 -0400
tree ba6264884b0c45bbfc5dcbb5efba26229b9a9bfc
parent 02261ad7a51f8cad31c548a67f8406a1ef5ff052

Make sure a NotImplementedError is always raised on Connection.makefile() (#744)

* Make sure a NotImplementedError is always raised on Connection.makefile

With this patch, code which calls (for example) conn.makefile('rb') will
get a NotImplementedError instead of a confusing TypeError:

    TypeError: makefile() takes 1 positional argument but 2 were given

* ignore any args/kwargs passed

src/OpenSSL/SSL.py

diff --git a/src/OpenSSL/SSL.py b/src/OpenSSL/SSL.py
index 8d8cfe3..4c708ba 100644
--- a/src/OpenSSL/SSL.py
+++ b/src/OpenSSL/SSL.py
@@ -2039,7 +2039,7 @@
             result.append(pyname)
         return result
 
-    def makefile(self):
+    def makefile(self, *args, **kwargs):
         """
         The makefile() method is not implemented, since there is no dup
         semantics for SSL connections