blob: 28359b024766ec49e57f5d1ef28679ad47994951 [file] [log] [blame] [view]
Laurens Van Houtven290aba12014-03-14 15:20:18 +01001# Contributing
2
3First of all, thank you for your interest in contributing to
4PyOpenSSL!
5
6## Filing bug reports
7
8Bug reports are very welcome. Please file them on the Github issue
9tracker. Good bug reports come with extensive descriptions of the
10error and how to reproduce it. Reporters are strongly encouraged to
11include an [SSCCE](http://www.sscce.org/).
12
13## Patches
14
15All patches to PyOpenSSL should be submitted in the form of pull
16requests to the main PyOpenSSL repository, `pyca/pyopenssl`. These
17pull requests should satisfy the following properties:
18
19- Pull requests that involve code must follow the
20 [Twisted Coding Standard][tcs]. For example, `methodNamesLikeThis`,
21 three empty lines between module-level elements, and two empty lines
22 between class-level elements.
23- Pull requests that introduce code must test all new behavior they
24 introduce, as well as previously untested or poorly tested behavior
25 that they touch.
26- Pull requests are not allowed to break existing tests.
27- Pull requests that include major changes should note those changes
28 in the `ChangeLog` text file in the root of the repository.
29
30Finally, pull requests must be reviewed before merging. This process
31is based on [the one from cryptography][cryptography-review]. Everyone
32can perform reviews; this is a very valuable way to contribute, and is
33highly encouraged.
34
35All members of the pyca Github organization can merge pull requests,
36of course keeping in mind all the requirements detailed in this
37document as well as the pyca/cryptography merge requirements.
38
39The final responsibility for the reviewing of merged code lies with
40the person merging it; since PyOpenSSL is obviously a sensitive
41project from a security perspective, so reviewers are strongly
42encouraged to take this review and merge process very seriously.
43
44[tcs]: https://twistedmatrix.com/documents/current/core/development/policy/coding-standard.html
45"Twisted Coding Standard"
46[cryptography-review]: https://cryptography.io/en/latest/development/reviewing-patches/