commit 446f7d6da0592127e7a89f8621d879967c24448d
author David Tolnay <dtolnay@gmail.com> Sun May 20 17:58:15 2018 -0700
committer David Tolnay <dtolnay@gmail.com> Sun May 20 18:09:51 2018 -0700
tree 3d7a6defc6cd2c20d23ac9efe3effd294cca2297
parent e58fa706e0d53c90a46108e2041b0df6b1104c85

Eliminate to_string() in Ident comparisons

codegen/src/main.rs

diff --git a/codegen/src/main.rs b/codegen/src/main.rs
index 8bf9d4e..c513cc9 100644
--- a/codegen/src/main.rs
+++ b/codegen/src/main.rs
@@ -51,7 +51,7 @@
     if a.segments.len() != 1 {
         return false
     }
-    a.segments[0].ident.to_string() == b
+    a.segments[0].ident == b
 }
 
 fn get_features(attrs: &[Attribute], mut features: TokenStream) -> TokenStream {
@@ -107,7 +107,7 @@
                 // We don't want to try to load the generated rust files and
                 // parse them, so we ignore them here.
                 for name in IGNORED_MODS {
-                    if item.ident.to_string() == *name {
+                    if item.ident == name {
                         continue 'items;
                     }
                 }
@@ -117,7 +117,7 @@
                 //
                 // The derive module is weird because it is built with either
                 // `full` or `derive` but exported only under `derive`.
-                let features = if item.ident.to_string() == "derive" {
+                let features = if item.ident == "derive" {
                     quote!(#[cfg(feature = "derive")])
                 } else {
                     get_features(&item.attrs, features.clone())
@@ -196,7 +196,7 @@
     named!(full -> (TokenStream, bool), map!(option!(do_parse!(
         punct!(#) >>
         id: syn!(Ident) >>
-        cond_reduce!(id.to_string() == "full") >>
+        cond_reduce!(id == "full") >>
         ()
     )), |s| if s.is_some() {
         (quote!(#[cfg(feature = "full")]), true)
@@ -207,7 +207,7 @@
     named!(manual_extra_traits -> (), do_parse!(
         punct!(#) >>
         id: syn!(Ident) >>
-        cond_reduce!(id.to_string() == "manual_extra_traits") >>
+        cond_reduce!(id == "manual_extra_traits") >>
         ()
     ));
 
@@ -241,7 +241,7 @@
     named!(no_visit -> (), do_parse!(
         punct!(#) >>
         id: syn!(Ident) >>
-        cond_reduce!(id.to_string() == "no_visit") >>
+        cond_reduce!(id == "no_visit") >>
         ()
     ));
 
@@ -387,7 +387,7 @@
             Type::Tuple(TypeTuple { ref elems, .. }) => {
                 RelevantType::Tuple(elems)
             }
-            Type::Macro(TypeMacro { ref mac }) if mac.path.segments.last().unwrap().into_value().ident.to_string() == "Token" => {
+            Type::Macro(TypeMacro { ref mac }) if mac.path.segments.last().unwrap().into_value().ident == "Token" => {
                 RelevantType::Token(mac.into_token_stream())
             }
             _ => RelevantType::Pass,