diff --git a/src/cursor.rs b/src/cursor.rs
index 407b2db..ddedd46 100644
--- a/src/cursor.rs
+++ b/src/cursor.rs
@@ -307,10 +307,10 @@
     /// cursor points to eof.
     pub fn span(self) -> Span {
         match *self.entry() {
-            Entry::Group(span, ..) => span,
-            Entry::Literal(span, ..) => span,
-            Entry::Term(span, ..) => span,
-            Entry::Op(span, ..) => span,
+            Entry::Group(span, ..)
+            | Entry::Literal(span, ..)
+            | Entry::Term(span, ..)
+            | Entry::Op(span, ..) => span,
             Entry::End(..) => Span::call_site(),
         }
     }
diff --git a/src/lib.rs b/src/lib.rs
index 3f95a17..715a604 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -9,7 +9,7 @@
 #![doc(html_root_url = "https://dtolnay.github.io/syn")]
 #![cfg_attr(feature = "cargo-clippy",
             allow(const_static_lifetime, doc_markdown, large_enum_variant, match_bool,
-                  redundant_closure))]
+                  redundant_closure, needless_pass_by_value))]
 
 extern crate proc_macro2;
 extern crate proc_macro;
diff --git a/src/lit.rs b/src/lit.rs
index 5834e60..041661a 100644
--- a/src/lit.rs
+++ b/src/lit.rs
@@ -539,6 +539,9 @@
         }
     }
 
+    // Clippy false positive
+    // https://github.com/rust-lang-nursery/rust-clippy/issues/2329
+    #[cfg_attr(feature = "cargo-clippy", allow(needless_continue))]
     fn parse_lit_str_cooked(mut s: &str) -> String {
         assert_eq!(byte(s, 0), b'"');
         s = &s[1..];
@@ -555,10 +558,10 @@
                             let (byte, rest) = backslash_x(s);
                             s = rest;
                             assert!(byte <= 0x80, "Invalid \\x byte in string literal");
-                            char::from_u32(byte as u32).unwrap()
+                            char::from_u32(u32::from(byte)).unwrap()
                         }
                         b'u' => {
-                            let (chr, rest) = backslash_u(&s);
+                            let (chr, rest) = backslash_u(s);
                             s = rest;
                             chr
                         }
@@ -624,6 +627,9 @@
         }
     }
 
+    // Clippy false positive
+    // https://github.com/rust-lang-nursery/rust-clippy/issues/2329
+    #[cfg_attr(feature = "cargo-clippy", allow(needless_continue))]
     fn parse_lit_byte_str_cooked(mut s: &str) -> Vec<u8> {
         assert_eq!(byte(s, 0), b'b');
         assert_eq!(byte(s, 1), b'"');
@@ -654,7 +660,7 @@
                         b'"' => b'"',
                         b'\r' | b'\n' => loop {
                             let byte = byte(s, 0);
-                            let ch = char::from_u32(byte as u32).unwrap();
+                            let ch = char::from_u32(u32::from(byte)).unwrap();
                             if ch.is_whitespace() {
                                 s = &s[1..];
                             } else {
@@ -736,7 +742,7 @@
                         let (byte, rest) = backslash_x(s);
                         s = rest;
                         assert!(byte <= 0x80, "Invalid \\x byte in string literal");
-                        char::from_u32(byte as u32).unwrap()
+                        char::from_u32(u32::from(byte)).unwrap()
                     }
                     b'u' => {
                         let (chr, rest) = backslash_u(s);
@@ -776,7 +782,7 @@
             b'A'...b'F' => 10 + (b0 - b'A'),
             _ => panic!("unexpected non-hex character after \\x"),
         };
-        ch += 0x1 * match b1 {
+        ch += match b1 {
             b'0'...b'9' => b1 - b'0',
             b'a'...b'f' => 10 + (b1 - b'a'),
             b'A'...b'F' => 10 + (b1 - b'A'),
@@ -797,17 +803,17 @@
             match b {
                 b'0'...b'9' => {
                     ch *= 0x10;
-                    ch += (b - b'0') as u32;
+                    ch += u32::from(b - b'0');
                     s = &s[1..];
                 }
                 b'a'...b'f' => {
                     ch *= 0x10;
-                    ch += (10 + b - b'a') as u32;
+                    ch += u32::from(10 + b - b'a');
                     s = &s[1..];
                 }
                 b'A'...b'F' => {
                     ch *= 0x10;
-                    ch += (10 + b - b'A') as u32;
+                    ch += u32::from(10 + b - b'A');
                     s = &s[1..];
                 }
                 b'}' => break,
@@ -846,9 +852,9 @@
         loop {
             let b = byte(s, 0);
             let digit = match b {
-                b'0'...b'9' => (b - b'0') as u64,
-                b'a'...b'f' if base > 10 => 10 + (b - b'a') as u64,
-                b'A'...b'F' if base > 10 => 10 + (b - b'A') as u64,
+                b'0'...b'9' => u64::from(b - b'0'),
+                b'a'...b'f' if base > 10 => 10 + u64::from(b - b'a'),
+                b'A'...b'F' if base > 10 => 10 + u64::from(b - b'A'),
                 b'_' => {
                     s = &s[1..];
                     continue;
@@ -887,7 +893,8 @@
         for read in 0..bytes.len() {
             if bytes[read] == b'_' {
                 continue; // Don't increase write
-            } else if write != read {
+            }
+            if write != read {
                 let x = bytes[read];
                 bytes[write] = x;
             }
@@ -895,7 +902,7 @@
         }
         bytes.truncate(write);
         let input = String::from_utf8(bytes).unwrap();
-        let end = input.find('f').unwrap_or(input.len());
+        let end = input.find('f').unwrap_or_else(|| input.len());
         input[..end].parse().unwrap()
     }
 
diff --git a/tests/test_lit.rs b/tests/test_lit.rs
index c0fbfa5..1a65c39 100644
--- a/tests/test_lit.rs
+++ b/tests/test_lit.rs
@@ -173,6 +173,7 @@
 
 #[test]
 fn floats() {
+    #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))]
     fn test_float(s: &str, value: f64, suffix: FloatSuffix) {
         match lit(s) {
             Lit::Float(lit) => {