commit 565ddf035eb945b14cc0b3e6dc00fefac6643db9
author Adrian Taylor <adetaylor@chromium.org> Thu Oct 29 21:12:36 2020 -0700
committer Adrian Taylor <adetaylor@chromium.org> Thu Oct 29 21:12:36 2020 -0700
tree d19ce179aa3d3126c014e2c43529d500c7f9ea35
parent 71b34be0be6457e9d939a9005f0f246dc7f98218

Code review comments on namespace work.

syntax/impls.rs

diff --git a/syntax/impls.rs b/syntax/impls.rs
index 424ad9d..92c804a 100644
--- a/syntax/impls.rs
+++ b/syntax/impls.rs
@@ -315,10 +315,6 @@
         Self { rust: ident }
     }
 
-    pub fn from_pair(pair: Pair) -> Self {
-        Self { rust: pair.rust }
-    }
-
     pub fn make_self(span: Span) -> Self {
         Self {
             rust: Token![Self](span).into(),
@@ -357,9 +353,7 @@
         Self { ns, ident }
     }
 
-    fn iter_all_segments(
-        &self,
-    ) -> std::iter::Chain<std::slice::Iter<Ident>, std::iter::Once<&Ident>> {
+    fn iter_all_segments(&self) -> impl Iterator<Item = &Ident> {
         self.ns.iter().chain(std::iter::once(&self.ident))
     }
 

syntax/parse.rs

diff --git a/syntax/parse.rs b/syntax/parse.rs
index 7a56ab8..484b101 100644
--- a/syntax/parse.rs
+++ b/syntax/parse.rs
@@ -245,7 +245,7 @@
             if let Api::CxxFunction(efn) | Api::RustFunction(efn) = item {
                 if let Some(receiver) = &mut efn.receiver {
                     if receiver.ty.is_self() {
-                        receiver.ty = ResolvableName::from_pair(single_type.clone());
+                        receiver.ty = ResolvableName::new(single_type.rust.clone());
                     }
                 }
             }