commit d7e1f1e519dd3ea66fe98a88e6e3b81cc3fa085a
author David Tolnay <dtolnay@gmail.com> Wed Mar 18 21:06:37 2020 -0700
committer David Tolnay <dtolnay@gmail.com> Wed Mar 25 20:18:39 2020 -0700
tree b257138550cb3470070cda275ff16b985809b9c2
parent cd0793f0f1b461435ea04e2ae83fed1e03388d64

Split function pointer error message into specific cases

syntax/check.rs

diff --git a/syntax/check.rs b/syntax/check.rs
index 256a193..b44d0cc 100644
--- a/syntax/check.rs
+++ b/syntax/check.rs
@@ -29,7 +29,6 @@
             Type::RustBox(ptr) => check_type_box(cx, ptr),
             Type::UniquePtr(ptr) => check_type_unique_ptr(cx, ptr),
             Type::Ref(ty) => check_type_ref(cx, ty),
-            Type::Fn(_) => cx.error(ty, "function pointer support is not implemented yet"),
             _ => {}
         }
     }
@@ -100,9 +99,12 @@
 }
 
 fn check_type_ref(cx: &mut Check, ty: &Ref) {
-    if let Type::Void(_) = ty.inner {
-        cx.error(ty, "unsupported reference type");
+    match ty.inner {
+        Type::Fn(_) | Type::Void(_) => {}
+        _ => return,
     }
+
+    cx.error(ty, "unsupported reference type");
 }
 
 fn check_api_struct(cx: &mut Check, strct: &Struct) {
@@ -117,6 +119,12 @@
             let msg = format!("using {} by value is not supported", desc);
             cx.error(field, msg);
         }
+        if let Type::Fn(_) = field.ty {
+            cx.error(
+                field,
+                "function pointers in a struct field are not implemented yet",
+            );
+        }
     }
 }
 
@@ -127,6 +135,12 @@
             let msg = format!("passing {} by value is not supported", desc);
             cx.error(arg, msg);
         }
+        if let Type::Fn(_) = arg.ty {
+            cx.error(
+                arg,
+                "passing a function pointer argument is not implemented yet",
+            );
+        }
     }
 
     if let Some(ty) = &efn.ret {
@@ -135,6 +149,9 @@
             let msg = format!("returning {} by value is not supported", desc);
             cx.error(ty, msg);
         }
+        if let Type::Fn(_) = ty {
+            cx.error(ty, "returning a function pointer is not implemented yet");
+        }
     }
 }