| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 1 | use crate::syntax::atom::Atom::{self, *}; |
| David Tolnay | df344a8 | 2020-05-03 23:23:18 -0700 | [diff] [blame] | 2 | use crate::syntax::report::Errors; |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 3 | use crate::syntax::types::TrivialReason; |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 4 | use crate::syntax::{ |
| David Tolnay | 7e69f89 | 2020-10-03 22:20:22 -0700 | [diff] [blame] | 5 | error, ident, Api, Enum, ExternFn, ExternType, Impl, Lang, Receiver, Ref, Slice, Struct, Ty1, |
| 6 | Type, Types, |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 7 | }; |
| David Tolnay | 09462ac | 2020-03-20 14:58:41 -0700 | [diff] [blame] | 8 | use proc_macro2::{Delimiter, Group, Ident, TokenStream}; |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 9 | use quote::{quote, ToTokens}; |
| 10 | use std::fmt::Display; |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 11 | |
| David Tolnay | a83301c | 2020-04-30 20:32:37 -0700 | [diff] [blame] | 12 | pub(crate) struct Check<'a> { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 13 | apis: &'a [Api], |
| 14 | types: &'a Types<'a>, |
| David Tolnay | df344a8 | 2020-05-03 23:23:18 -0700 | [diff] [blame] | 15 | errors: &'a mut Errors, |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 16 | } |
| 17 | |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 18 | pub(crate) fn typecheck(cx: &mut Errors, apis: &[Api], types: &Types) { |
| David Tolnay | 0dd85ff | 2020-05-03 23:43:33 -0700 | [diff] [blame] | 19 | do_typecheck(&mut Check { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 20 | apis, |
| 21 | types, |
| David Tolnay | 0dd85ff | 2020-05-03 23:43:33 -0700 | [diff] [blame] | 22 | errors: cx, |
| 23 | }); |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 24 | } |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 25 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 26 | fn do_typecheck(cx: &mut Check) { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 27 | ident::check_all(cx, cx.apis); |
| David Tolnay | 9dcb833 | 2020-04-30 20:37:33 -0700 | [diff] [blame] | 28 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 29 | for ty in cx.types { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 30 | match ty { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 31 | Type::Ident(ident) => check_type_ident(cx, &ident.rust), |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 32 | Type::RustBox(ptr) => check_type_box(cx, ptr), |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 33 | Type::RustVec(ty) => check_type_rust_vec(cx, ty), |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 34 | Type::UniquePtr(ptr) => check_type_unique_ptr(cx, ptr), |
| David Tolnay | fff4c8a | 2020-04-25 11:45:20 -0700 | [diff] [blame] | 35 | Type::CxxVector(ptr) => check_type_cxx_vector(cx, ptr), |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 36 | Type::Ref(ty) => check_type_ref(cx, ty), |
| David Tolnay | eebe9b7 | 2020-04-14 16:32:18 -0700 | [diff] [blame] | 37 | Type::Slice(ty) => check_type_slice(cx, ty), |
| David Tolnay | 5ecaea9 | 2020-11-14 23:25:42 -0800 | [diff] [blame^] | 38 | Type::Str(_) | Type::Fn(_) | Type::Void(_) | Type::SliceRefU8(_) => {} |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 39 | } |
| 40 | } |
| 41 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 42 | for api in cx.apis { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 43 | match api { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 44 | Api::Struct(strct) => check_api_struct(cx, strct), |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 45 | Api::Enum(enm) => check_api_enum(cx, enm), |
| David Tolnay | 4cefa72 | 2020-10-03 21:24:07 -0700 | [diff] [blame] | 46 | Api::CxxType(ety) | Api::RustType(ety) => check_api_type(cx, ety), |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 47 | Api::CxxFunction(efn) | Api::RustFunction(efn) => check_api_fn(cx, efn), |
| David Tolnay | 7e69f89 | 2020-10-03 22:20:22 -0700 | [diff] [blame] | 48 | Api::Impl(imp) => check_api_impl(cx, imp), |
| David Tolnay | 5ecaea9 | 2020-11-14 23:25:42 -0800 | [diff] [blame^] | 49 | Api::Include(_) | Api::TypeAlias(_) => {} |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 50 | } |
| 51 | } |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 52 | } |
| 53 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 54 | impl Check<'_> { |
| David Tolnay | a83301c | 2020-04-30 20:32:37 -0700 | [diff] [blame] | 55 | pub(crate) fn error(&mut self, sp: impl ToTokens, msg: impl Display) { |
| David Tolnay | df344a8 | 2020-05-03 23:23:18 -0700 | [diff] [blame] | 56 | self.errors.error(sp, msg); |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 57 | } |
| 58 | } |
| 59 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 60 | fn check_type_ident(cx: &mut Check, ident: &Ident) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 61 | if Atom::from(ident).is_none() |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 62 | && !cx.types.structs.contains_key(ident) |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 63 | && !cx.types.enums.contains_key(ident) |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 64 | && !cx.types.cxx.contains(ident) |
| 65 | && !cx.types.rust.contains(ident) |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 66 | { |
| David Tolnay | dbc5377 | 2020-10-28 17:28:51 -0700 | [diff] [blame] | 67 | let msg = format!("unsupported type: {}", ident); |
| 68 | cx.error(ident, &msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 69 | } |
| 70 | } |
| 71 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 72 | fn check_type_box(cx: &mut Check, ptr: &Ty1) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 73 | if let Type::Ident(ident) = &ptr.inner { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 74 | if cx.types.cxx.contains(&ident.rust) |
| 75 | && !cx.types.structs.contains_key(&ident.rust) |
| 76 | && !cx.types.enums.contains_key(&ident.rust) |
| David Tolnay | c880ae2 | 2020-08-29 16:46:00 -0700 | [diff] [blame] | 77 | { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 78 | cx.error(ptr, error::BOX_CXX_TYPE.msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 79 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 80 | |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 81 | if Atom::from(&ident.rust).is_none() { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 82 | return; |
| 83 | } |
| 84 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 85 | |
| 86 | cx.error(ptr, "unsupported target type of Box"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 87 | } |
| 88 | |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 89 | fn check_type_rust_vec(cx: &mut Check, ty: &Ty1) { |
| 90 | if let Type::Ident(ident) = &ty.inner { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 91 | if cx.types.cxx.contains(&ident.rust) |
| 92 | && !cx.types.structs.contains_key(&ident.rust) |
| 93 | && !cx.types.enums.contains_key(&ident.rust) |
| David Tolnay | c880ae2 | 2020-08-29 16:46:00 -0700 | [diff] [blame] | 94 | { |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 95 | cx.error(ty, "Rust Vec containing C++ type is not supported yet"); |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 96 | return; |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 97 | } |
| 98 | |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 99 | match Atom::from(&ident.rust) { |
| David Tolnay | 6bd63de | 2020-04-25 12:20:09 -0700 | [diff] [blame] | 100 | None | Some(U8) | Some(U16) | Some(U32) | Some(U64) | Some(Usize) | Some(I8) |
| David Tolnay | 33f56ad | 2020-08-27 17:06:35 -0700 | [diff] [blame] | 101 | | Some(I16) | Some(I32) | Some(I64) | Some(Isize) | Some(F32) | Some(F64) |
| 102 | | Some(RustString) => return, |
| 103 | Some(Bool) => { /* todo */ } |
| David Tolnay | 6bd63de | 2020-04-25 12:20:09 -0700 | [diff] [blame] | 104 | Some(CxxString) => {} |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 105 | } |
| 106 | } |
| 107 | |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 108 | cx.error(ty, "unsupported element type of Vec"); |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 109 | } |
| 110 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 111 | fn check_type_unique_ptr(cx: &mut Check, ptr: &Ty1) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 112 | if let Type::Ident(ident) = &ptr.inner { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 113 | if cx.types.rust.contains(&ident.rust) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 114 | cx.error(ptr, "unique_ptr of a Rust type is not supported yet"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 115 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 116 | |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 117 | match Atom::from(&ident.rust) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 118 | None | Some(CxxString) => return, |
| 119 | _ => {} |
| 120 | } |
| David Tolnay | 4377a9e | 2020-04-24 15:20:26 -0700 | [diff] [blame] | 121 | } else if let Type::CxxVector(_) = &ptr.inner { |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 122 | return; |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 123 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 124 | |
| 125 | cx.error(ptr, "unsupported unique_ptr target type"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 126 | } |
| 127 | |
| David Tolnay | fff4c8a | 2020-04-25 11:45:20 -0700 | [diff] [blame] | 128 | fn check_type_cxx_vector(cx: &mut Check, ptr: &Ty1) { |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 129 | if let Type::Ident(ident) = &ptr.inner { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 130 | if cx.types.rust.contains(&ident.rust) { |
| David Tolnay | c0faaf6 | 2020-04-25 12:18:38 -0700 | [diff] [blame] | 131 | cx.error( |
| 132 | ptr, |
| 133 | "C++ vector containing a Rust type is not supported yet", |
| 134 | ); |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 135 | } |
| 136 | |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 137 | match Atom::from(&ident.rust) { |
| David Tolnay | 6bd63de | 2020-04-25 12:20:09 -0700 | [diff] [blame] | 138 | None | Some(U8) | Some(U16) | Some(U32) | Some(U64) | Some(Usize) | Some(I8) |
| David Tolnay | 47e239d | 2020-08-28 00:32:04 -0700 | [diff] [blame] | 139 | | Some(I16) | Some(I32) | Some(I64) | Some(Isize) | Some(F32) | Some(F64) |
| 140 | | Some(CxxString) => return, |
| David Tolnay | 6bd63de | 2020-04-25 12:20:09 -0700 | [diff] [blame] | 141 | Some(Bool) | Some(RustString) => {} |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 142 | } |
| 143 | } |
| David Tolnay | c0faaf6 | 2020-04-25 12:18:38 -0700 | [diff] [blame] | 144 | |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 145 | cx.error(ptr, "unsupported vector target type"); |
| 146 | } |
| 147 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 148 | fn check_type_ref(cx: &mut Check, ty: &Ref) { |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 149 | if ty.lifetime.is_some() { |
| 150 | cx.error(ty, "references with explicit lifetimes are not supported"); |
| 151 | } |
| 152 | |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 153 | match ty.inner { |
| 154 | Type::Fn(_) | Type::Void(_) => {} |
| David Tolnay | 776fd89 | 2020-04-28 13:38:21 -0700 | [diff] [blame] | 155 | Type::Ref(_) => { |
| 156 | cx.error(ty, "C++ does not allow references to references"); |
| 157 | return; |
| 158 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 159 | _ => return, |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 160 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 161 | |
| 162 | cx.error(ty, "unsupported reference type"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 163 | } |
| 164 | |
| David Tolnay | eebe9b7 | 2020-04-14 16:32:18 -0700 | [diff] [blame] | 165 | fn check_type_slice(cx: &mut Check, ty: &Slice) { |
| 166 | cx.error(ty, "only &[u8] is supported so far, not other slice types"); |
| 167 | } |
| 168 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 169 | fn check_api_struct(cx: &mut Check, strct: &Struct) { |
| David Tolnay | 17a934c | 2020-11-02 00:40:04 -0800 | [diff] [blame] | 170 | let name = &strct.name; |
| 171 | check_reserved_name(cx, &name.rust); |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 172 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 173 | if strct.fields.is_empty() { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 174 | let span = span_for_struct_error(strct); |
| 175 | cx.error(span, "structs without any fields are not supported"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 176 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 177 | |
| David Tolnay | 17a934c | 2020-11-02 00:40:04 -0800 | [diff] [blame] | 178 | if cx.types.cxx.contains(&name.rust) { |
| 179 | if let Some(ety) = cx.types.untrusted.get(&name.rust) { |
| David Tolnay | c8b5035 | 2020-08-29 19:27:01 -0700 | [diff] [blame] | 180 | let msg = "extern shared struct must be declared in an `unsafe extern` block"; |
| 181 | cx.error(ety, msg); |
| David Tolnay | c8b5035 | 2020-08-29 19:27:01 -0700 | [diff] [blame] | 182 | } |
| David Tolnay | c880ae2 | 2020-08-29 16:46:00 -0700 | [diff] [blame] | 183 | } |
| 184 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 185 | for field in &strct.fields { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 186 | if is_unsized(cx, &field.ty) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 187 | let desc = describe(cx, &field.ty); |
| 188 | let msg = format!("using {} by value is not supported", desc); |
| 189 | cx.error(field, msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 190 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 191 | if let Type::Fn(_) = field.ty { |
| 192 | cx.error( |
| 193 | field, |
| 194 | "function pointers in a struct field are not implemented yet", |
| 195 | ); |
| 196 | } |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 197 | } |
| 198 | } |
| 199 | |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 200 | fn check_api_enum(cx: &mut Check, enm: &Enum) { |
| David Tolnay | 17a934c | 2020-11-02 00:40:04 -0800 | [diff] [blame] | 201 | check_reserved_name(cx, &enm.name.rust); |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 202 | |
| 203 | if enm.variants.is_empty() { |
| 204 | let span = span_for_enum_error(enm); |
| 205 | cx.error(span, "enums without any variants are not supported"); |
| 206 | } |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 207 | } |
| 208 | |
| David Tolnay | 4cefa72 | 2020-10-03 21:24:07 -0700 | [diff] [blame] | 209 | fn check_api_type(cx: &mut Check, ety: &ExternType) { |
| David Tolnay | 17a934c | 2020-11-02 00:40:04 -0800 | [diff] [blame] | 210 | check_reserved_name(cx, &ety.name.rust); |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 211 | |
| David Tolnay | 17a934c | 2020-11-02 00:40:04 -0800 | [diff] [blame] | 212 | if let Some(reason) = cx.types.required_trivial.get(&ety.name.rust) { |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 213 | let what = match reason { |
| David Tolnay | 17a934c | 2020-11-02 00:40:04 -0800 | [diff] [blame] | 214 | TrivialReason::StructField(strct) => format!("a field of `{}`", strct.name.rust), |
| 215 | TrivialReason::FunctionArgument(efn) => format!("an argument of `{}`", efn.name.rust), |
| 216 | TrivialReason::FunctionReturn(efn) => format!("a return value of `{}`", efn.name.rust), |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 217 | }; |
| 218 | let msg = format!( |
| 219 | "needs a cxx::ExternType impl in order to be used as {}", |
| 220 | what, |
| 221 | ); |
| David Tolnay | 4cefa72 | 2020-10-03 21:24:07 -0700 | [diff] [blame] | 222 | cx.error(ety, msg); |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 223 | } |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 224 | } |
| 225 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 226 | fn check_api_fn(cx: &mut Check, efn: &ExternFn) { |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 227 | if let Some(receiver) = &efn.receiver { |
| David Tolnay | a1f29c4 | 2020-04-22 18:01:38 -0700 | [diff] [blame] | 228 | let ref span = span_for_receiver_error(receiver); |
| 229 | |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 230 | if receiver.ty.is_self() { |
| David Tolnay | a1f29c4 | 2020-04-22 18:01:38 -0700 | [diff] [blame] | 231 | let mutability = match receiver.mutability { |
| 232 | Some(_) => "mut ", |
| 233 | None => "", |
| 234 | }; |
| 235 | let msg = format!( |
| 236 | "unnamed receiver type is only allowed if the surrounding \ |
| 237 | extern block contains exactly one extern type; \ |
| 238 | use `self: &{mutability}TheType`", |
| 239 | mutability = mutability, |
| 240 | ); |
| 241 | cx.error(span, msg); |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 242 | } else if !cx.types.structs.contains_key(&receiver.ty.rust) |
| 243 | && !cx.types.cxx.contains(&receiver.ty.rust) |
| 244 | && !cx.types.rust.contains(&receiver.ty.rust) |
| David Tolnay | 8b60bf1 | 2020-04-22 16:52:19 -0700 | [diff] [blame] | 245 | { |
| David Tolnay | 8b60bf1 | 2020-04-22 16:52:19 -0700 | [diff] [blame] | 246 | cx.error(span, "unrecognized receiver type"); |
| 247 | } |
| 248 | |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 249 | if receiver.lifetime.is_some() { |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 250 | cx.error(span, "references with explicit lifetimes are not supported"); |
| 251 | } |
| 252 | } |
| 253 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 254 | for arg in &efn.args { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 255 | if is_unsized(cx, &arg.ty) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 256 | let desc = describe(cx, &arg.ty); |
| 257 | let msg = format!("passing {} by value is not supported", desc); |
| 258 | cx.error(arg, msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 259 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 260 | if let Type::Fn(_) = arg.ty { |
| David Tolnay | 75dca2e | 2020-03-25 20:17:52 -0700 | [diff] [blame] | 261 | if efn.lang == Lang::Rust { |
| 262 | cx.error( |
| 263 | arg, |
| 264 | "passing a function pointer from C++ to Rust is not implemented yet", |
| 265 | ); |
| 266 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 267 | } |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 268 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 269 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 270 | if let Some(ty) = &efn.ret { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 271 | if is_unsized(cx, ty) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 272 | let desc = describe(cx, ty); |
| 273 | let msg = format!("returning {} by value is not supported", desc); |
| 274 | cx.error(ty, msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 275 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 276 | if let Type::Fn(_) = ty { |
| 277 | cx.error(ty, "returning a function pointer is not implemented yet"); |
| 278 | } |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 279 | } |
| David Tolnay | 96a826b | 2020-05-04 00:17:12 -0700 | [diff] [blame] | 280 | |
| 281 | if efn.lang == Lang::Cxx { |
| 282 | check_mut_return_restriction(cx, efn); |
| 283 | } |
| 284 | |
| 285 | check_multiple_arg_lifetimes(cx, efn); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 286 | } |
| 287 | |
| David Tolnay | 7e69f89 | 2020-10-03 22:20:22 -0700 | [diff] [blame] | 288 | fn check_api_impl(cx: &mut Check, imp: &Impl) { |
| 289 | if let Type::UniquePtr(ty) | Type::CxxVector(ty) = &imp.ty { |
| 290 | if let Type::Ident(inner) = &ty.inner { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 291 | if Atom::from(&inner.rust).is_none() { |
| David Tolnay | 7e69f89 | 2020-10-03 22:20:22 -0700 | [diff] [blame] | 292 | return; |
| 293 | } |
| 294 | } |
| 295 | } |
| 296 | |
| 297 | cx.error(imp, "unsupported Self type of explicit impl"); |
| 298 | } |
| 299 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 300 | fn check_mut_return_restriction(cx: &mut Check, efn: &ExternFn) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 301 | match &efn.ret { |
| 302 | Some(Type::Ref(ty)) if ty.mutability.is_some() => {} |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 303 | _ => return, |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 304 | } |
| 305 | |
| 306 | for arg in &efn.args { |
| 307 | if let Type::Ref(ty) = &arg.ty { |
| 308 | if ty.mutability.is_some() { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 309 | return; |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 310 | } |
| 311 | } |
| 312 | } |
| 313 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 314 | cx.error( |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 315 | efn, |
| 316 | "&mut return type is not allowed unless there is a &mut argument", |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 317 | ); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 318 | } |
| 319 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 320 | fn check_multiple_arg_lifetimes(cx: &mut Check, efn: &ExternFn) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 321 | match &efn.ret { |
| 322 | Some(Type::Ref(_)) => {} |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 323 | _ => return, |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 324 | } |
| 325 | |
| 326 | let mut reference_args = 0; |
| 327 | for arg in &efn.args { |
| 328 | if let Type::Ref(_) = &arg.ty { |
| 329 | reference_args += 1; |
| 330 | } |
| 331 | } |
| 332 | |
| Joel Galenson | 3d4f612 | 2020-04-07 15:54:05 -0700 | [diff] [blame] | 333 | if efn.receiver.is_some() { |
| 334 | reference_args += 1; |
| 335 | } |
| 336 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 337 | if reference_args != 1 { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 338 | cx.error( |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 339 | efn, |
| 340 | "functions that return a reference must take exactly one input reference", |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 341 | ); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 342 | } |
| 343 | } |
| 344 | |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 345 | fn check_reserved_name(cx: &mut Check, ident: &Ident) { |
| David Tolnay | 99c93d8 | 2020-04-25 14:07:44 -0700 | [diff] [blame] | 346 | if ident == "Box" |
| 347 | || ident == "UniquePtr" |
| 348 | || ident == "Vec" |
| 349 | || ident == "CxxVector" |
| 350 | || Atom::from(ident).is_some() |
| 351 | { |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 352 | cx.error(ident, "reserved name"); |
| 353 | } |
| 354 | } |
| 355 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 356 | fn is_unsized(cx: &mut Check, ty: &Type) -> bool { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 357 | let ident = match ty { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 358 | Type::Ident(ident) => &ident.rust, |
| David Tolnay | e70303c | 2020-04-25 15:02:37 -0700 | [diff] [blame] | 359 | Type::CxxVector(_) | Type::Slice(_) | Type::Void(_) => return true, |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 360 | _ => return false, |
| 361 | }; |
| David Tolnay | 8984995 | 2020-08-29 18:32:29 -0700 | [diff] [blame] | 362 | ident == CxxString |
| David Tolnay | c880ae2 | 2020-08-29 16:46:00 -0700 | [diff] [blame] | 363 | || cx.types.cxx.contains(ident) |
| 364 | && !cx.types.structs.contains_key(ident) |
| 365 | && !cx.types.enums.contains_key(ident) |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 366 | && !(cx.types.aliases.contains_key(ident) |
| 367 | && cx.types.required_trivial.contains_key(ident)) |
| David Tolnay | 8984995 | 2020-08-29 18:32:29 -0700 | [diff] [blame] | 368 | || cx.types.rust.contains(ident) |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 369 | } |
| 370 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 371 | fn span_for_struct_error(strct: &Struct) -> TokenStream { |
| 372 | let struct_token = strct.struct_token; |
| 373 | let mut brace_token = Group::new(Delimiter::Brace, TokenStream::new()); |
| 374 | brace_token.set_span(strct.brace_token.span); |
| 375 | quote!(#struct_token #brace_token) |
| 376 | } |
| 377 | |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 378 | fn span_for_enum_error(enm: &Enum) -> TokenStream { |
| 379 | let enum_token = enm.enum_token; |
| 380 | let mut brace_token = Group::new(Delimiter::Brace, TokenStream::new()); |
| 381 | brace_token.set_span(enm.brace_token.span); |
| 382 | quote!(#enum_token #brace_token) |
| 383 | } |
| 384 | |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 385 | fn span_for_receiver_error(receiver: &Receiver) -> TokenStream { |
| 386 | let ampersand = receiver.ampersand; |
| 387 | let lifetime = &receiver.lifetime; |
| 388 | let mutability = receiver.mutability; |
| 389 | if receiver.shorthand { |
| 390 | let var = receiver.var; |
| 391 | quote!(#ampersand #lifetime #mutability #var) |
| 392 | } else { |
| 393 | let ty = &receiver.ty; |
| 394 | quote!(#ampersand #lifetime #mutability #ty) |
| 395 | } |
| 396 | } |
| 397 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 398 | fn describe(cx: &mut Check, ty: &Type) -> String { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 399 | match ty { |
| 400 | Type::Ident(ident) => { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 401 | if cx.types.structs.contains_key(&ident.rust) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 402 | "struct".to_owned() |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 403 | } else if cx.types.enums.contains_key(&ident.rust) { |
| David Tolnay | 5548372 | 2020-08-29 18:27:37 -0700 | [diff] [blame] | 404 | "enum".to_owned() |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 405 | } else if cx.types.aliases.contains_key(&ident.rust) { |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 406 | "C++ type".to_owned() |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 407 | } else if cx.types.cxx.contains(&ident.rust) { |
| David Tolnay | 3208fd7 | 2020-10-03 20:19:40 -0700 | [diff] [blame] | 408 | "opaque C++ type".to_owned() |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 409 | } else if cx.types.rust.contains(&ident.rust) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 410 | "opaque Rust type".to_owned() |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 411 | } else if Atom::from(&ident.rust) == Some(CxxString) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 412 | "C++ string".to_owned() |
| 413 | } else { |
| Adrian Taylor | c871343 | 2020-10-21 18:20:55 -0700 | [diff] [blame] | 414 | ident.rust.to_string() |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 415 | } |
| 416 | } |
| 417 | Type::RustBox(_) => "Box".to_owned(), |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 418 | Type::RustVec(_) => "Vec".to_owned(), |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 419 | Type::UniquePtr(_) => "unique_ptr".to_owned(), |
| 420 | Type::Ref(_) => "reference".to_owned(), |
| 421 | Type::Str(_) => "&str".to_owned(), |
| David Tolnay | fa85fce | 2020-04-25 15:03:25 -0700 | [diff] [blame] | 422 | Type::CxxVector(_) => "C++ vector".to_owned(), |
| Adrian Taylor | f5dd552 | 2020-04-13 16:50:14 -0700 | [diff] [blame] | 423 | Type::Slice(_) => "slice".to_owned(), |
| 424 | Type::SliceRefU8(_) => "&[u8]".to_owned(), |
| David Tolnay | 417305a | 2020-03-18 13:54:00 -0700 | [diff] [blame] | 425 | Type::Fn(_) => "function pointer".to_owned(), |
| David Tolnay | 2fb14e9 | 2020-03-15 23:11:38 -0700 | [diff] [blame] | 426 | Type::Void(_) => "()".to_owned(), |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 427 | } |
| 428 | } |