blob: a90db49b8fdce7233b0293641a3f5d36fdeaefdd [file] [log] [blame]
David Tolnay7db73692019-10-20 14:51:12 -04001use crate::syntax::atom::Atom::{self, *};
David Tolnayd763f4c2020-04-22 16:09:19 -07002use crate::syntax::{
David Tolnay0b368ae2020-04-22 17:55:02 -07003 error, ident, Api, ExternFn, ExternType, Lang, Receiver, Ref, Slice, Struct, Ty1, Type, Types,
David Tolnayd763f4c2020-04-22 16:09:19 -07004};
David Tolnay09462ac2020-03-20 14:58:41 -07005use proc_macro2::{Delimiter, Group, Ident, TokenStream};
David Tolnaya420f012020-03-25 17:55:56 -07006use quote::{quote, ToTokens};
7use std::fmt::Display;
David Tolnay7db73692019-10-20 14:51:12 -04008use syn::{Error, Result};
9
David Tolnay26a2a1d2020-03-25 17:26:43 -070010struct Check<'a> {
11 apis: &'a [Api],
12 types: &'a Types<'a>,
13 errors: &'a mut Vec<Error>,
14}
15
David Tolnay7db73692019-10-20 14:51:12 -040016pub(crate) fn typecheck(apis: &[Api], types: &Types) -> Result<()> {
David Tolnay26a2a1d2020-03-25 17:26:43 -070017 let mut errors = Vec::new();
18 let mut cx = Check {
19 apis,
20 types,
21 errors: &mut errors,
22 };
23 do_typecheck(&mut cx);
24 combine_errors(errors)
25}
David Tolnay7db73692019-10-20 14:51:12 -040026
David Tolnay26a2a1d2020-03-25 17:26:43 -070027fn do_typecheck(cx: &mut Check) {
28 for ty in cx.types {
David Tolnay7db73692019-10-20 14:51:12 -040029 match ty {
David Tolnay26a2a1d2020-03-25 17:26:43 -070030 Type::Ident(ident) => check_type_ident(cx, ident),
31 Type::RustBox(ptr) => check_type_box(cx, ptr),
David Tolnayc6d891e2020-04-25 12:06:34 -070032 Type::RustVec(ty) => check_type_rust_vec(cx, ty),
David Tolnay26a2a1d2020-03-25 17:26:43 -070033 Type::UniquePtr(ptr) => check_type_unique_ptr(cx, ptr),
David Tolnayfff4c8a2020-04-25 11:45:20 -070034 Type::CxxVector(ptr) => check_type_cxx_vector(cx, ptr),
David Tolnay26a2a1d2020-03-25 17:26:43 -070035 Type::Ref(ty) => check_type_ref(cx, ty),
David Tolnayeebe9b72020-04-14 16:32:18 -070036 Type::Slice(ty) => check_type_slice(cx, ty),
David Tolnay7db73692019-10-20 14:51:12 -040037 _ => {}
38 }
39 }
40
David Tolnay26a2a1d2020-03-25 17:26:43 -070041 for api in cx.apis {
David Tolnay7db73692019-10-20 14:51:12 -040042 match api {
David Tolnay26a2a1d2020-03-25 17:26:43 -070043 Api::Struct(strct) => check_api_struct(cx, strct),
David Tolnay0b368ae2020-04-22 17:55:02 -070044 Api::CxxType(ty) | Api::RustType(ty) => check_api_type(cx, ty),
David Tolnay26a2a1d2020-03-25 17:26:43 -070045 Api::CxxFunction(efn) | Api::RustFunction(efn) => check_api_fn(cx, efn),
David Tolnay7db73692019-10-20 14:51:12 -040046 _ => {}
47 }
48 }
49
David Tolnay26a2a1d2020-03-25 17:26:43 -070050 for api in cx.apis {
David Tolnay7db73692019-10-20 14:51:12 -040051 if let Api::CxxFunction(efn) = api {
David Tolnay26a2a1d2020-03-25 17:26:43 -070052 check_mut_return_restriction(cx, efn);
David Tolnay7db73692019-10-20 14:51:12 -040053 }
54 if let Api::CxxFunction(efn) | Api::RustFunction(efn) = api {
David Tolnay26a2a1d2020-03-25 17:26:43 -070055 check_multiple_arg_lifetimes(cx, efn);
David Tolnay7db73692019-10-20 14:51:12 -040056 }
57 }
58
David Tolnay26a2a1d2020-03-25 17:26:43 -070059 ident::check_all(cx.apis, cx.errors);
David Tolnay7db73692019-10-20 14:51:12 -040060}
61
David Tolnaya420f012020-03-25 17:55:56 -070062impl Check<'_> {
63 fn error(&mut self, sp: impl ToTokens, msg: impl Display) {
64 self.errors.push(Error::new_spanned(sp, msg));
65 }
66}
67
David Tolnay26a2a1d2020-03-25 17:26:43 -070068fn check_type_ident(cx: &mut Check, ident: &Ident) {
David Tolnayd4e68302020-03-25 12:04:17 -070069 if Atom::from(ident).is_none()
David Tolnay26a2a1d2020-03-25 17:26:43 -070070 && !cx.types.structs.contains_key(ident)
71 && !cx.types.cxx.contains(ident)
72 && !cx.types.rust.contains(ident)
David Tolnayd4e68302020-03-25 12:04:17 -070073 {
David Tolnaya420f012020-03-25 17:55:56 -070074 cx.error(ident, "unsupported type");
David Tolnayd4e68302020-03-25 12:04:17 -070075 }
76}
77
David Tolnay26a2a1d2020-03-25 17:26:43 -070078fn check_type_box(cx: &mut Check, ptr: &Ty1) {
David Tolnayd4e68302020-03-25 12:04:17 -070079 if let Type::Ident(ident) = &ptr.inner {
David Tolnay26a2a1d2020-03-25 17:26:43 -070080 if cx.types.cxx.contains(ident) {
David Tolnaya420f012020-03-25 17:55:56 -070081 cx.error(ptr, error::BOX_CXX_TYPE.msg);
David Tolnayd4e68302020-03-25 12:04:17 -070082 }
David Tolnaya420f012020-03-25 17:55:56 -070083
David Tolnayd4e68302020-03-25 12:04:17 -070084 if Atom::from(ident).is_none() {
85 return;
86 }
87 }
David Tolnaya420f012020-03-25 17:55:56 -070088
89 cx.error(ptr, "unsupported target type of Box");
David Tolnayd4e68302020-03-25 12:04:17 -070090}
91
David Tolnayc6d891e2020-04-25 12:06:34 -070092fn check_type_rust_vec(cx: &mut Check, ty: &Ty1) {
93 if let Type::Ident(ident) = &ty.inner {
94 if cx.types.cxx.contains(ident) {
95 cx.error(ty, "Rust Vec containing C++ type is not supported yet");
Myron Ahneba35cf2020-02-05 19:41:51 +070096 return;
David Tolnayc6d891e2020-04-25 12:06:34 -070097 }
98
99 match Atom::from(ident) {
David Tolnay6bd63de2020-04-25 12:20:09 -0700100 None | Some(U8) | Some(U16) | Some(U32) | Some(U64) | Some(Usize) | Some(I8)
101 | Some(I16) | Some(I32) | Some(I64) | Some(Isize) | Some(F32) | Some(F64) => return,
102 Some(Bool) | Some(RustString) => { /* todo */ }
103 Some(CxxString) => {}
Myron Ahneba35cf2020-02-05 19:41:51 +0700104 }
105 }
106
David Tolnayc6d891e2020-04-25 12:06:34 -0700107 cx.error(ty, "unsupported element type of Vec");
Myron Ahneba35cf2020-02-05 19:41:51 +0700108}
109
David Tolnay26a2a1d2020-03-25 17:26:43 -0700110fn check_type_unique_ptr(cx: &mut Check, ptr: &Ty1) {
David Tolnayd4e68302020-03-25 12:04:17 -0700111 if let Type::Ident(ident) = &ptr.inner {
David Tolnay26a2a1d2020-03-25 17:26:43 -0700112 if cx.types.rust.contains(ident) {
David Tolnaya420f012020-03-25 17:55:56 -0700113 cx.error(ptr, "unique_ptr of a Rust type is not supported yet");
David Tolnayd4e68302020-03-25 12:04:17 -0700114 }
David Tolnaya420f012020-03-25 17:55:56 -0700115
David Tolnayd4e68302020-03-25 12:04:17 -0700116 match Atom::from(ident) {
117 None | Some(CxxString) => return,
118 _ => {}
119 }
David Tolnay4377a9e2020-04-24 15:20:26 -0700120 } else if let Type::CxxVector(_) = &ptr.inner {
Myron Ahneba35cf2020-02-05 19:41:51 +0700121 return;
David Tolnayd4e68302020-03-25 12:04:17 -0700122 }
David Tolnaya420f012020-03-25 17:55:56 -0700123
124 cx.error(ptr, "unsupported unique_ptr target type");
David Tolnayd4e68302020-03-25 12:04:17 -0700125}
126
David Tolnayfff4c8a2020-04-25 11:45:20 -0700127fn check_type_cxx_vector(cx: &mut Check, ptr: &Ty1) {
Myron Ahneba35cf2020-02-05 19:41:51 +0700128 if let Type::Ident(ident) = &ptr.inner {
129 if cx.types.rust.contains(ident) {
David Tolnayc0faaf62020-04-25 12:18:38 -0700130 cx.error(
131 ptr,
132 "C++ vector containing a Rust type is not supported yet",
133 );
Myron Ahneba35cf2020-02-05 19:41:51 +0700134 }
135
136 match Atom::from(ident) {
David Tolnay6bd63de2020-04-25 12:20:09 -0700137 None | Some(U8) | Some(U16) | Some(U32) | Some(U64) | Some(Usize) | Some(I8)
138 | Some(I16) | Some(I32) | Some(I64) | Some(Isize) | Some(F32) | Some(F64) => return,
139 Some(CxxString) => { /* todo */ }
140 Some(Bool) | Some(RustString) => {}
Myron Ahneba35cf2020-02-05 19:41:51 +0700141 }
142 }
David Tolnayc0faaf62020-04-25 12:18:38 -0700143
Myron Ahneba35cf2020-02-05 19:41:51 +0700144 cx.error(ptr, "unsupported vector target type");
145}
146
David Tolnay26a2a1d2020-03-25 17:26:43 -0700147fn check_type_ref(cx: &mut Check, ty: &Ref) {
David Tolnayd763f4c2020-04-22 16:09:19 -0700148 if ty.lifetime.is_some() {
149 cx.error(ty, "references with explicit lifetimes are not supported");
150 }
151
David Tolnayd7e1f1e2020-03-18 21:06:37 -0700152 match ty.inner {
153 Type::Fn(_) | Type::Void(_) => {}
154 _ => return,
David Tolnayd4e68302020-03-25 12:04:17 -0700155 }
David Tolnayd7e1f1e2020-03-18 21:06:37 -0700156
157 cx.error(ty, "unsupported reference type");
David Tolnayd4e68302020-03-25 12:04:17 -0700158}
159
David Tolnayeebe9b72020-04-14 16:32:18 -0700160fn check_type_slice(cx: &mut Check, ty: &Slice) {
161 cx.error(ty, "only &[u8] is supported so far, not other slice types");
162}
163
David Tolnay26a2a1d2020-03-25 17:26:43 -0700164fn check_api_struct(cx: &mut Check, strct: &Struct) {
David Tolnay0b368ae2020-04-22 17:55:02 -0700165 check_reserved_name(cx, &strct.ident);
166
David Tolnayd4e68302020-03-25 12:04:17 -0700167 if strct.fields.is_empty() {
David Tolnaya420f012020-03-25 17:55:56 -0700168 let span = span_for_struct_error(strct);
169 cx.error(span, "structs without any fields are not supported");
David Tolnayd4e68302020-03-25 12:04:17 -0700170 }
David Tolnaya420f012020-03-25 17:55:56 -0700171
David Tolnayd4e68302020-03-25 12:04:17 -0700172 for field in &strct.fields {
David Tolnay26a2a1d2020-03-25 17:26:43 -0700173 if is_unsized(cx, &field.ty) {
David Tolnaya420f012020-03-25 17:55:56 -0700174 let desc = describe(cx, &field.ty);
175 let msg = format!("using {} by value is not supported", desc);
176 cx.error(field, msg);
David Tolnayd4e68302020-03-25 12:04:17 -0700177 }
David Tolnayd7e1f1e2020-03-18 21:06:37 -0700178 if let Type::Fn(_) = field.ty {
179 cx.error(
180 field,
181 "function pointers in a struct field are not implemented yet",
182 );
183 }
David Tolnayd4e68302020-03-25 12:04:17 -0700184 }
185}
186
David Tolnay0b368ae2020-04-22 17:55:02 -0700187fn check_api_type(cx: &mut Check, ty: &ExternType) {
188 check_reserved_name(cx, &ty.ident);
189}
190
David Tolnay26a2a1d2020-03-25 17:26:43 -0700191fn check_api_fn(cx: &mut Check, efn: &ExternFn) {
David Tolnayd763f4c2020-04-22 16:09:19 -0700192 if let Some(receiver) = &efn.receiver {
David Tolnaya1f29c42020-04-22 18:01:38 -0700193 let ref span = span_for_receiver_error(receiver);
194
195 if receiver.ty == "Self" {
196 let mutability = match receiver.mutability {
197 Some(_) => "mut ",
198 None => "",
199 };
200 let msg = format!(
201 "unnamed receiver type is only allowed if the surrounding \
202 extern block contains exactly one extern type; \
203 use `self: &{mutability}TheType`",
204 mutability = mutability,
205 );
206 cx.error(span, msg);
207 } else if !cx.types.structs.contains_key(&receiver.ty)
David Tolnay8b60bf12020-04-22 16:52:19 -0700208 && !cx.types.cxx.contains(&receiver.ty)
209 && !cx.types.rust.contains(&receiver.ty)
210 {
David Tolnay8b60bf12020-04-22 16:52:19 -0700211 cx.error(span, "unrecognized receiver type");
212 }
213
David Tolnayd763f4c2020-04-22 16:09:19 -0700214 if receiver.lifetime.is_some() {
David Tolnayd763f4c2020-04-22 16:09:19 -0700215 cx.error(span, "references with explicit lifetimes are not supported");
216 }
217 }
218
David Tolnayd4e68302020-03-25 12:04:17 -0700219 for arg in &efn.args {
David Tolnay26a2a1d2020-03-25 17:26:43 -0700220 if is_unsized(cx, &arg.ty) {
David Tolnaya420f012020-03-25 17:55:56 -0700221 let desc = describe(cx, &arg.ty);
222 let msg = format!("passing {} by value is not supported", desc);
223 cx.error(arg, msg);
David Tolnayd4e68302020-03-25 12:04:17 -0700224 }
David Tolnayd7e1f1e2020-03-18 21:06:37 -0700225 if let Type::Fn(_) = arg.ty {
David Tolnay75dca2e2020-03-25 20:17:52 -0700226 if efn.lang == Lang::Rust {
227 cx.error(
228 arg,
229 "passing a function pointer from C++ to Rust is not implemented yet",
230 );
231 }
David Tolnayd7e1f1e2020-03-18 21:06:37 -0700232 }
Joel Galenson2bd13122020-04-28 10:05:40 -0700233 if let Type::Ref(ity) = &arg.ty {
234 if let Type::Ref(_) = &ity.inner {
235 cx.error(arg, "Passing a reference to a reference is not supported");
236 }
237 }
David Tolnayd4e68302020-03-25 12:04:17 -0700238 }
David Tolnaya420f012020-03-25 17:55:56 -0700239
David Tolnayd4e68302020-03-25 12:04:17 -0700240 if let Some(ty) = &efn.ret {
David Tolnay26a2a1d2020-03-25 17:26:43 -0700241 if is_unsized(cx, ty) {
David Tolnaya420f012020-03-25 17:55:56 -0700242 let desc = describe(cx, ty);
243 let msg = format!("returning {} by value is not supported", desc);
244 cx.error(ty, msg);
David Tolnayd4e68302020-03-25 12:04:17 -0700245 }
David Tolnayd7e1f1e2020-03-18 21:06:37 -0700246 if let Type::Fn(_) = ty {
247 cx.error(ty, "returning a function pointer is not implemented yet");
248 }
David Tolnayd4e68302020-03-25 12:04:17 -0700249 }
David Tolnay7db73692019-10-20 14:51:12 -0400250}
251
David Tolnay26a2a1d2020-03-25 17:26:43 -0700252fn check_mut_return_restriction(cx: &mut Check, efn: &ExternFn) {
David Tolnay7db73692019-10-20 14:51:12 -0400253 match &efn.ret {
254 Some(Type::Ref(ty)) if ty.mutability.is_some() => {}
David Tolnay26a2a1d2020-03-25 17:26:43 -0700255 _ => return,
David Tolnay7db73692019-10-20 14:51:12 -0400256 }
257
258 for arg in &efn.args {
259 if let Type::Ref(ty) = &arg.ty {
260 if ty.mutability.is_some() {
David Tolnay26a2a1d2020-03-25 17:26:43 -0700261 return;
David Tolnay7db73692019-10-20 14:51:12 -0400262 }
263 }
264 }
265
David Tolnaya420f012020-03-25 17:55:56 -0700266 cx.error(
David Tolnay7db73692019-10-20 14:51:12 -0400267 efn,
268 "&mut return type is not allowed unless there is a &mut argument",
David Tolnaya420f012020-03-25 17:55:56 -0700269 );
David Tolnay7db73692019-10-20 14:51:12 -0400270}
271
David Tolnay26a2a1d2020-03-25 17:26:43 -0700272fn check_multiple_arg_lifetimes(cx: &mut Check, efn: &ExternFn) {
David Tolnay7db73692019-10-20 14:51:12 -0400273 match &efn.ret {
274 Some(Type::Ref(_)) => {}
David Tolnay26a2a1d2020-03-25 17:26:43 -0700275 _ => return,
David Tolnay7db73692019-10-20 14:51:12 -0400276 }
277
278 let mut reference_args = 0;
279 for arg in &efn.args {
280 if let Type::Ref(_) = &arg.ty {
281 reference_args += 1;
282 }
283 }
284
Joel Galenson3d4f6122020-04-07 15:54:05 -0700285 if efn.receiver.is_some() {
286 reference_args += 1;
287 }
288
David Tolnay26a2a1d2020-03-25 17:26:43 -0700289 if reference_args != 1 {
David Tolnaya420f012020-03-25 17:55:56 -0700290 cx.error(
David Tolnay7db73692019-10-20 14:51:12 -0400291 efn,
292 "functions that return a reference must take exactly one input reference",
David Tolnaya420f012020-03-25 17:55:56 -0700293 );
David Tolnay7db73692019-10-20 14:51:12 -0400294 }
295}
296
David Tolnay0b368ae2020-04-22 17:55:02 -0700297fn check_reserved_name(cx: &mut Check, ident: &Ident) {
David Tolnay99c93d82020-04-25 14:07:44 -0700298 if ident == "Box"
299 || ident == "UniquePtr"
300 || ident == "Vec"
301 || ident == "CxxVector"
302 || Atom::from(ident).is_some()
303 {
David Tolnay0b368ae2020-04-22 17:55:02 -0700304 cx.error(ident, "reserved name");
305 }
306}
307
David Tolnay26a2a1d2020-03-25 17:26:43 -0700308fn is_unsized(cx: &mut Check, ty: &Type) -> bool {
David Tolnayd4e68302020-03-25 12:04:17 -0700309 let ident = match ty {
310 Type::Ident(ident) => ident,
David Tolnaye70303c2020-04-25 15:02:37 -0700311 Type::CxxVector(_) | Type::Slice(_) | Type::Void(_) => return true,
David Tolnayd4e68302020-03-25 12:04:17 -0700312 _ => return false,
313 };
David Tolnay26a2a1d2020-03-25 17:26:43 -0700314 ident == CxxString || cx.types.cxx.contains(ident) || cx.types.rust.contains(ident)
315}
316
David Tolnaya420f012020-03-25 17:55:56 -0700317fn span_for_struct_error(strct: &Struct) -> TokenStream {
318 let struct_token = strct.struct_token;
319 let mut brace_token = Group::new(Delimiter::Brace, TokenStream::new());
320 brace_token.set_span(strct.brace_token.span);
321 quote!(#struct_token #brace_token)
322}
323
David Tolnayd763f4c2020-04-22 16:09:19 -0700324fn span_for_receiver_error(receiver: &Receiver) -> TokenStream {
325 let ampersand = receiver.ampersand;
326 let lifetime = &receiver.lifetime;
327 let mutability = receiver.mutability;
328 if receiver.shorthand {
329 let var = receiver.var;
330 quote!(#ampersand #lifetime #mutability #var)
331 } else {
332 let ty = &receiver.ty;
333 quote!(#ampersand #lifetime #mutability #ty)
334 }
335}
336
David Tolnay26a2a1d2020-03-25 17:26:43 -0700337fn combine_errors(errors: Vec<Error>) -> Result<()> {
338 let mut iter = errors.into_iter();
339 let mut all_errors = match iter.next() {
340 Some(err) => err,
341 None => return Ok(()),
342 };
343 for err in iter {
344 all_errors.combine(err);
345 }
346 Err(all_errors)
David Tolnayd4e68302020-03-25 12:04:17 -0700347}
348
David Tolnaya420f012020-03-25 17:55:56 -0700349fn describe(cx: &mut Check, ty: &Type) -> String {
David Tolnay7db73692019-10-20 14:51:12 -0400350 match ty {
351 Type::Ident(ident) => {
David Tolnaya420f012020-03-25 17:55:56 -0700352 if cx.types.structs.contains_key(ident) {
David Tolnay7db73692019-10-20 14:51:12 -0400353 "struct".to_owned()
David Tolnaya420f012020-03-25 17:55:56 -0700354 } else if cx.types.cxx.contains(ident) {
David Tolnay7db73692019-10-20 14:51:12 -0400355 "C++ type".to_owned()
David Tolnaya420f012020-03-25 17:55:56 -0700356 } else if cx.types.rust.contains(ident) {
David Tolnay7db73692019-10-20 14:51:12 -0400357 "opaque Rust type".to_owned()
358 } else if Atom::from(ident) == Some(CxxString) {
359 "C++ string".to_owned()
360 } else {
361 ident.to_string()
362 }
363 }
364 Type::RustBox(_) => "Box".to_owned(),
Myron Ahneba35cf2020-02-05 19:41:51 +0700365 Type::RustVec(_) => "Vec".to_owned(),
David Tolnay7db73692019-10-20 14:51:12 -0400366 Type::UniquePtr(_) => "unique_ptr".to_owned(),
367 Type::Ref(_) => "reference".to_owned(),
368 Type::Str(_) => "&str".to_owned(),
David Tolnayfa85fce2020-04-25 15:03:25 -0700369 Type::CxxVector(_) => "C++ vector".to_owned(),
Adrian Taylorf5dd5522020-04-13 16:50:14 -0700370 Type::Slice(_) => "slice".to_owned(),
371 Type::SliceRefU8(_) => "&[u8]".to_owned(),
David Tolnay417305a2020-03-18 13:54:00 -0700372 Type::Fn(_) => "function pointer".to_owned(),
David Tolnay2fb14e92020-03-15 23:11:38 -0700373 Type::Void(_) => "()".to_owned(),
David Tolnay7db73692019-10-20 14:51:12 -0400374 }
375}