| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 1 | use crate::syntax::atom::Atom::{self, *}; |
| David Tolnay | eebe9b7 | 2020-04-14 16:32:18 -0700 | [diff] [blame^] | 2 | use crate::syntax::{error, ident, Api, ExternFn, Lang, Ref, Slice, Struct, Ty1, Type, Types}; |
| David Tolnay | 09462ac | 2020-03-20 14:58:41 -0700 | [diff] [blame] | 3 | use proc_macro2::{Delimiter, Group, Ident, TokenStream}; |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 4 | use quote::{quote, ToTokens}; |
| 5 | use std::fmt::Display; |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 6 | use syn::{Error, Result}; |
| 7 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 8 | struct Check<'a> { |
| 9 | apis: &'a [Api], |
| 10 | types: &'a Types<'a>, |
| 11 | errors: &'a mut Vec<Error>, |
| 12 | } |
| 13 | |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 14 | pub(crate) fn typecheck(apis: &[Api], types: &Types) -> Result<()> { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 15 | let mut errors = Vec::new(); |
| 16 | let mut cx = Check { |
| 17 | apis, |
| 18 | types, |
| 19 | errors: &mut errors, |
| 20 | }; |
| 21 | do_typecheck(&mut cx); |
| 22 | combine_errors(errors) |
| 23 | } |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 24 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 25 | fn do_typecheck(cx: &mut Check) { |
| 26 | for ty in cx.types { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 27 | match ty { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 28 | Type::Ident(ident) => check_type_ident(cx, ident), |
| 29 | Type::RustBox(ptr) => check_type_box(cx, ptr), |
| 30 | Type::UniquePtr(ptr) => check_type_unique_ptr(cx, ptr), |
| 31 | Type::Ref(ty) => check_type_ref(cx, ty), |
| David Tolnay | eebe9b7 | 2020-04-14 16:32:18 -0700 | [diff] [blame^] | 32 | Type::Slice(ty) => check_type_slice(cx, ty), |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 33 | _ => {} |
| 34 | } |
| 35 | } |
| 36 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 37 | for api in cx.apis { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 38 | match api { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 39 | Api::Struct(strct) => check_api_struct(cx, strct), |
| 40 | Api::CxxFunction(efn) | Api::RustFunction(efn) => check_api_fn(cx, efn), |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 41 | _ => {} |
| 42 | } |
| 43 | } |
| 44 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 45 | for api in cx.apis { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 46 | if let Api::CxxFunction(efn) = api { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 47 | check_mut_return_restriction(cx, efn); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 48 | } |
| 49 | if let Api::CxxFunction(efn) | Api::RustFunction(efn) = api { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 50 | check_multiple_arg_lifetimes(cx, efn); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 51 | } |
| 52 | } |
| 53 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 54 | ident::check_all(cx.apis, cx.errors); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 55 | } |
| 56 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 57 | impl Check<'_> { |
| 58 | fn error(&mut self, sp: impl ToTokens, msg: impl Display) { |
| 59 | self.errors.push(Error::new_spanned(sp, msg)); |
| 60 | } |
| 61 | } |
| 62 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 63 | fn check_type_ident(cx: &mut Check, ident: &Ident) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 64 | if Atom::from(ident).is_none() |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 65 | && !cx.types.structs.contains_key(ident) |
| 66 | && !cx.types.cxx.contains(ident) |
| 67 | && !cx.types.rust.contains(ident) |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 68 | { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 69 | cx.error(ident, "unsupported type"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 70 | } |
| 71 | } |
| 72 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 73 | fn check_type_box(cx: &mut Check, ptr: &Ty1) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 74 | if let Type::Ident(ident) = &ptr.inner { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 75 | if cx.types.cxx.contains(ident) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 76 | cx.error(ptr, error::BOX_CXX_TYPE.msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 77 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 78 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 79 | if Atom::from(ident).is_none() { |
| 80 | return; |
| 81 | } |
| 82 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 83 | |
| 84 | cx.error(ptr, "unsupported target type of Box"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 85 | } |
| 86 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 87 | fn check_type_unique_ptr(cx: &mut Check, ptr: &Ty1) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 88 | if let Type::Ident(ident) = &ptr.inner { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 89 | if cx.types.rust.contains(ident) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 90 | cx.error(ptr, "unique_ptr of a Rust type is not supported yet"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 91 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 92 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 93 | match Atom::from(ident) { |
| 94 | None | Some(CxxString) => return, |
| 95 | _ => {} |
| 96 | } |
| 97 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 98 | |
| 99 | cx.error(ptr, "unsupported unique_ptr target type"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 100 | } |
| 101 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 102 | fn check_type_ref(cx: &mut Check, ty: &Ref) { |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 103 | match ty.inner { |
| 104 | Type::Fn(_) | Type::Void(_) => {} |
| 105 | _ => return, |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 106 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 107 | |
| 108 | cx.error(ty, "unsupported reference type"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 109 | } |
| 110 | |
| David Tolnay | eebe9b7 | 2020-04-14 16:32:18 -0700 | [diff] [blame^] | 111 | fn check_type_slice(cx: &mut Check, ty: &Slice) { |
| 112 | cx.error(ty, "only &[u8] is supported so far, not other slice types"); |
| 113 | } |
| 114 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 115 | fn check_api_struct(cx: &mut Check, strct: &Struct) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 116 | if strct.fields.is_empty() { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 117 | let span = span_for_struct_error(strct); |
| 118 | cx.error(span, "structs without any fields are not supported"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 119 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 120 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 121 | for field in &strct.fields { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 122 | if is_unsized(cx, &field.ty) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 123 | let desc = describe(cx, &field.ty); |
| 124 | let msg = format!("using {} by value is not supported", desc); |
| 125 | cx.error(field, msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 126 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 127 | if let Type::Fn(_) = field.ty { |
| 128 | cx.error( |
| 129 | field, |
| 130 | "function pointers in a struct field are not implemented yet", |
| 131 | ); |
| 132 | } |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 133 | } |
| 134 | } |
| 135 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 136 | fn check_api_fn(cx: &mut Check, efn: &ExternFn) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 137 | for arg in &efn.args { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 138 | if is_unsized(cx, &arg.ty) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 139 | let desc = describe(cx, &arg.ty); |
| 140 | let msg = format!("passing {} by value is not supported", desc); |
| 141 | cx.error(arg, msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 142 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 143 | if let Type::Fn(_) = arg.ty { |
| David Tolnay | 75dca2e | 2020-03-25 20:17:52 -0700 | [diff] [blame] | 144 | if efn.lang == Lang::Rust { |
| 145 | cx.error( |
| 146 | arg, |
| 147 | "passing a function pointer from C++ to Rust is not implemented yet", |
| 148 | ); |
| 149 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 150 | } |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 151 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 152 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 153 | if let Some(ty) = &efn.ret { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 154 | if is_unsized(cx, ty) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 155 | let desc = describe(cx, ty); |
| 156 | let msg = format!("returning {} by value is not supported", desc); |
| 157 | cx.error(ty, msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 158 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 159 | if let Type::Fn(_) = ty { |
| 160 | cx.error(ty, "returning a function pointer is not implemented yet"); |
| 161 | } |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 162 | } |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 163 | } |
| 164 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 165 | fn check_mut_return_restriction(cx: &mut Check, efn: &ExternFn) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 166 | match &efn.ret { |
| 167 | Some(Type::Ref(ty)) if ty.mutability.is_some() => {} |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 168 | _ => return, |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 169 | } |
| 170 | |
| 171 | for arg in &efn.args { |
| 172 | if let Type::Ref(ty) = &arg.ty { |
| 173 | if ty.mutability.is_some() { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 174 | return; |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 175 | } |
| 176 | } |
| 177 | } |
| 178 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 179 | cx.error( |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 180 | efn, |
| 181 | "&mut return type is not allowed unless there is a &mut argument", |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 182 | ); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 183 | } |
| 184 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 185 | fn check_multiple_arg_lifetimes(cx: &mut Check, efn: &ExternFn) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 186 | match &efn.ret { |
| 187 | Some(Type::Ref(_)) => {} |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 188 | _ => return, |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 189 | } |
| 190 | |
| 191 | let mut reference_args = 0; |
| 192 | for arg in &efn.args { |
| 193 | if let Type::Ref(_) = &arg.ty { |
| 194 | reference_args += 1; |
| 195 | } |
| 196 | } |
| 197 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 198 | if reference_args != 1 { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 199 | cx.error( |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 200 | efn, |
| 201 | "functions that return a reference must take exactly one input reference", |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 202 | ); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 203 | } |
| 204 | } |
| 205 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 206 | fn is_unsized(cx: &mut Check, ty: &Type) -> bool { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 207 | let ident = match ty { |
| 208 | Type::Ident(ident) => ident, |
| David Tolnay | eebe9b7 | 2020-04-14 16:32:18 -0700 | [diff] [blame^] | 209 | Type::Slice(_) | Type::Void(_) => return true, |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 210 | _ => return false, |
| 211 | }; |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 212 | ident == CxxString || cx.types.cxx.contains(ident) || cx.types.rust.contains(ident) |
| 213 | } |
| 214 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 215 | fn span_for_struct_error(strct: &Struct) -> TokenStream { |
| 216 | let struct_token = strct.struct_token; |
| 217 | let mut brace_token = Group::new(Delimiter::Brace, TokenStream::new()); |
| 218 | brace_token.set_span(strct.brace_token.span); |
| 219 | quote!(#struct_token #brace_token) |
| 220 | } |
| 221 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 222 | fn combine_errors(errors: Vec<Error>) -> Result<()> { |
| 223 | let mut iter = errors.into_iter(); |
| 224 | let mut all_errors = match iter.next() { |
| 225 | Some(err) => err, |
| 226 | None => return Ok(()), |
| 227 | }; |
| 228 | for err in iter { |
| 229 | all_errors.combine(err); |
| 230 | } |
| 231 | Err(all_errors) |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 232 | } |
| 233 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 234 | fn describe(cx: &mut Check, ty: &Type) -> String { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 235 | match ty { |
| 236 | Type::Ident(ident) => { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 237 | if cx.types.structs.contains_key(ident) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 238 | "struct".to_owned() |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 239 | } else if cx.types.cxx.contains(ident) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 240 | "C++ type".to_owned() |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 241 | } else if cx.types.rust.contains(ident) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 242 | "opaque Rust type".to_owned() |
| 243 | } else if Atom::from(ident) == Some(CxxString) { |
| 244 | "C++ string".to_owned() |
| 245 | } else { |
| 246 | ident.to_string() |
| 247 | } |
| 248 | } |
| 249 | Type::RustBox(_) => "Box".to_owned(), |
| 250 | Type::UniquePtr(_) => "unique_ptr".to_owned(), |
| 251 | Type::Ref(_) => "reference".to_owned(), |
| 252 | Type::Str(_) => "&str".to_owned(), |
| Adrian Taylor | f5dd552 | 2020-04-13 16:50:14 -0700 | [diff] [blame] | 253 | Type::Slice(_) => "slice".to_owned(), |
| 254 | Type::SliceRefU8(_) => "&[u8]".to_owned(), |
| David Tolnay | 417305a | 2020-03-18 13:54:00 -0700 | [diff] [blame] | 255 | Type::Fn(_) => "function pointer".to_owned(), |
| David Tolnay | 2fb14e9 | 2020-03-15 23:11:38 -0700 | [diff] [blame] | 256 | Type::Void(_) => "()".to_owned(), |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 257 | } |
| 258 | } |