remove SkMiniPicture and co.
This was an optimization for Chromium that I believe is no longer
relevant in a world of PaintOpBuffers.
Change-Id: Ic7526715a0ef1c3cec387a44189b7d56d5107af5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/213680
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
diff --git a/tests/PictureTest.cpp b/tests/PictureTest.cpp
index e851cfb..44da230 100644
--- a/tests/PictureTest.cpp
+++ b/tests/PictureTest.cpp
@@ -11,6 +11,7 @@
#include "include/core/SkClipOp.h"
#include "include/core/SkColor.h"
#include "include/core/SkData.h"
+#include "include/core/SkFont.h"
#include "include/core/SkFontStyle.h"
#include "include/core/SkImageInfo.h"
#include "include/core/SkMatrix.h"
@@ -29,7 +30,6 @@
#include "src/core/SkBBoxHierarchy.h"
#include "src/core/SkBigPicture.h"
#include "src/core/SkClipOpPriv.h"
-#include "src/core/SkMiniRecorder.h"
#include "src/core/SkPicturePriv.h"
#include "src/core/SkRectPriv.h"
#include "tests/Test.h"
@@ -758,16 +758,6 @@
}
}
-DEF_TEST(MiniRecorderLeftHanging, r) {
- // Any shader or other ref-counted effect will do just fine here.
- SkPaint paint;
- paint.setShader(SkShaders::Color(SK_ColorRED));
-
- SkMiniRecorder rec;
- REPORTER_ASSERT(r, rec.drawRect(SkRect::MakeWH(20,30), paint));
- // Don't call rec.detachPicture(). Test succeeds by not asserting or leaking the shader.
-}
-
DEF_TEST(Picture_preserveCullRect, r) {
SkPictureRecorder recorder;
@@ -793,7 +783,7 @@
// bounds of those ops, we should trim down the picture cull to the ops' bounds.
// If we're not using an SkBBH, we shouldn't change it.
DEF_TEST(Picture_UpdatedCull_1, r) {
- // Testing 1 draw exercises SkMiniPicture.
+ // Testing 1 draw exercised SkMiniPicture, which no longer exists, but still a fine test.
SkRTreeFactory factory;
SkPictureRecorder recorder;