commit 053f785903e6548895111435dc50f1e5af3fd6db
author John Stiles <johnstiles@google.com> Mon Jan 25 13:04:12 2021 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Mon Jan 25 21:27:19 2021 +0000
tree e2390e82baa6421eab05170de12bd9e36afee521
parent e7ff4bc9b8b274aafc005d3d136bcfab7e198097

Avoid relying on bit-perfect irrational numbers in test code.

Comparing sqrt(5) against a variable containing sqrt(5) was not working
properly in some versions of Android running Vulkan.

Change-Id: I4f6bbff78a9ba56ec6e222f2037d66b13e3cd635
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/358530
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>

tests/SkSLTest.cpp

diff --git a/tests/SkSLTest.cpp b/tests/SkSLTest.cpp
index 5139c3f..a378b22 100644
--- a/tests/SkSLTest.cpp
+++ b/tests/SkSLTest.cpp
@@ -85,17 +85,13 @@
 
 SKSL_TEST(SkSLBoolFolding,             "folding/BoolFolding.sksl")
 SKSL_TEST(SkSLIntFoldingES2,           "folding/IntFoldingES2.sksl")
+SKSL_TEST(SkSLFloatFolding,            "folding/FloatFolding.sksl")
 SKSL_TEST(SkSLMatrixFoldingES2,        "folding/MatrixFoldingES2.sksl")
 SKSL_TEST(SkSLShortCircuitBoolFolding, "folding/ShortCircuitBoolFolding.sksl")
 SKSL_TEST(SkSLVectorScalarFolding,     "folding/VectorScalarFolding.sksl")
 SKSL_TEST(SkSLVectorVectorFolding,     "folding/VectorVectorFolding.sksl")
 
 /*
-TODO(johnstiles): Investigate failures on certain Android Vulkan devices, then re-enable this test.
-SKSL_TEST(SkSLFloatFolding,            "folding/FloatFolding.sksl")
-*/
-
-/*
 TODO(skia:11209): enable these tests when Runtime Effects have support for ES3
 
 SKSL_TEST(SkSLIntFoldingES3,           "folding/IntFoldingES3.sksl")