commit 05d3fe3f100b794abe3f99a770734057960d7da5
author Greg Daniel <egdaniel@google.com> Wed Jun 27 15:04:39 2018 +0000
committer Greg Daniel <egdaniel@google.com> Wed Jun 27 15:24:23 2018 +0000
tree 5498a44126c8c190894def22a623db80a3db6965
parent 05f83d9ea31b589502f3a46f79221726013b5581

Revert "Move Vulkan DebugCallback code into tools."

This reverts commit d4b2adeaa929edd1664754ac6621ec524992ef03.

Reason for revert: Need to revert earlier changes cause of fucshia

Original change's description:
> Move Vulkan DebugCallback code into tools.
> 
> Bug: skia:
> Change-Id: Ib356200e86e54f9ff0ba16396874e6fd10cf0465
> Reviewed-on: https://skia-review.googlesource.com/137424
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Greg Daniel <egdaniel@google.com>

TBR=egdaniel@google.com,jvanverth@google.com,bsalomon@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:
Change-Id: I38d4e71dc29c6503f92712be54e22c58956498c5
Reviewed-on: https://skia-review.googlesource.com/137902
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>

tools/sk_app/VulkanWindowContext.cpp

diff --git a/tools/sk_app/VulkanWindowContext.cpp b/tools/sk_app/VulkanWindowContext.cpp
index 8e0749e..411f114 100644
--- a/tools/sk_app/VulkanWindowContext.cpp
+++ b/tools/sk_app/VulkanWindowContext.cpp
@@ -51,8 +51,7 @@
 
     GrVkBackendContext backendContext;
     if (!sk_gpu_test::CreateVkBackendContext(fGetInstanceProcAddr, fGetDeviceProcAddr,
-                                             &backendContext, &fDebugCallback,
-                                             &fPresentQueueIndex, fCanPresentFn)) {
+                                             &backendContext, &fPresentQueueIndex, fCanPresentFn)) {
         return;
     }
 
@@ -410,26 +409,28 @@
 }
 
 void VulkanWindowContext::destroyContext() {
-    if (this->isValid()) {
-        fQueueWaitIdle(fPresentQueue);
-        fDeviceWaitIdle(fDevice);
+    if (!this->isValid()) {
+        return;
+    }
 
-        this->destroyBuffers();
+    fQueueWaitIdle(fPresentQueue);
+    fDeviceWaitIdle(fDevice);
 
-        if (VK_NULL_HANDLE != fCommandPool) {
-            GR_VK_CALL(fInterface, DestroyCommandPool(fDevice, fCommandPool, nullptr));
-            fCommandPool = VK_NULL_HANDLE;
-        }
+    this->destroyBuffers();
 
-        if (VK_NULL_HANDLE != fSwapchain) {
-            fDestroySwapchainKHR(fDevice, fSwapchain, nullptr);
-            fSwapchain = VK_NULL_HANDLE;
-        }
+    if (VK_NULL_HANDLE != fCommandPool) {
+        GR_VK_CALL(fInterface, DestroyCommandPool(fDevice, fCommandPool, nullptr));
+        fCommandPool = VK_NULL_HANDLE;
+    }
 
-        if (VK_NULL_HANDLE != fSurface) {
-            fDestroySurfaceKHR(fInstance, fSurface, nullptr);
-            fSurface = VK_NULL_HANDLE;
-        }
+    if (VK_NULL_HANDLE != fSwapchain) {
+        fDestroySwapchainKHR(fDevice, fSwapchain, nullptr);
+        fSwapchain = VK_NULL_HANDLE;
+    }
+
+    if (VK_NULL_HANDLE != fSurface) {
+        fDestroySurfaceKHR(fInstance, fSurface, nullptr);
+        fSurface = VK_NULL_HANDLE;
     }
 
     fContext.reset();
@@ -439,14 +440,6 @@
         fDestroyDevice(fDevice, nullptr);
         fDevice = VK_NULL_HANDLE;
     }
-
-#ifdef SK_ENABLE_VK_LAYERS
-    if (fDebugCallback != VK_NULL_HANDLE) {
-        GR_VK_CALL(fInterface, DestroyDebugReportCallbackEXT(fInstance, fDebugCallback,
-                                                             nullptr));
-    }
-#endif
-
     fPhysicalDevice = VK_NULL_HANDLE;
 
     if (VK_NULL_HANDLE != fInstance) {