commit 0cace8ed86b6e6161bc9dd5870238458f85841be
author Robert Phillips <robertphillips@google.com> Thu Jan 03 12:42:43 2019 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Thu Jan 03 20:14:21 2019 +0000
tree 4b547129fa52e60796cdbe84d2b33f5634ae1b8f
parent 7a8d08db55d7116e156706b15bf8c56d87b567b3

Make the RRectEffect's screen coords be Float4 (rather than Half4)

For large screens Half4 can have insufficient precision to effectively address all of screen space.

This was originally found and fixed in https://android-review.googlesource.com/c/platform/external/skia/+/859297 (fix CtsViewTestCases).

Bug: b/122105577
Change-Id: I7a18cd9f8ea1fcf2340e456597760ca189d404e2
Reviewed-on: https://skia-review.googlesource.com/c/180926
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>

src/gpu/effects/GrRRectEffect.cpp

diff --git a/src/gpu/effects/GrRRectEffect.cpp b/src/gpu/effects/GrRRectEffect.cpp
index 6478306..5cd54b7 100644
--- a/src/gpu/effects/GrRRectEffect.cpp
+++ b/src/gpu/effects/GrRRectEffect.cpp
@@ -157,7 +157,7 @@
     // edges correspond to components x, y, z, and w, respectively. When a side of the rrect has
     // only rectangular corners, that side's value corresponds to the rect edge's value outset by
     // half a pixel.
-    fInnerRectUniform = uniformHandler->addUniform(kFragment_GrShaderFlag, kHalf4_GrSLType,
+    fInnerRectUniform = uniformHandler->addUniform(kFragment_GrShaderFlag, kFloat4_GrSLType,
                                                    "innerRect", &rectName);
     // x is (r + .5) and y is 1/(r + .5)
     fRadiusPlusHalfUniform = uniformHandler->addUniform(kFragment_GrShaderFlag, kHalf2_GrSLType,
@@ -503,7 +503,7 @@
     GrGLSLUniformHandler* uniformHandler = args.fUniformHandler;
     const char *rectName;
     // The inner rect is the rrect bounds inset by the x/y radii
-    fInnerRectUniform = uniformHandler->addUniform(kFragment_GrShaderFlag, kHalf4_GrSLType,
+    fInnerRectUniform = uniformHandler->addUniform(kFragment_GrShaderFlag, kFloat4_GrSLType,
                                                    "innerRect", &rectName);
 
     GrGLSLFPFragmentBuilder* fragBuilder = args.fFragBuilder;