| commit | 0ebdb37b5516de9b7160253a979b8bea443258c5 | [log] [tgz] |
|---|---|---|
| author | Mike Klein <mtklein@google.com> | Thu Feb 11 09:40:46 2021 -0600 |
| committer | Mike Klein <mtklein@google.com> | Thu Feb 11 17:24:21 2021 +0000 |
| tree | 8f58f8e0237e08d1a1bc792dd8dc8a41318bdc43 | |
| parent | 1352d0e47d4fa81eb216905e24df669f5ded899c [diff] |
plumb errors up to mid-level steps
As is, on failure the top-level task fails correctly,
then the next level steps all confusingly look green,
then the next two levels down are correctly failed and red.
I think this is because worker(ctx) fails `ctx`, which we make like
this,
ctx := startStep(w.Ctx, td.Props(strings.Join(w.Sources, " ")))
but nothing ever fails that `w.Ctx`. This should fix that.
Compare trybot runs here with https://task-driver.skia.org/td/BMCjZbc5ki1cXbkM0oZp?ifNotFound=https%3A%2F%2Fchromium-swarm.appspot.com%2Ftask%3Fid%3D51aa8032a90a8810
Change-Id: Idfbd933b9027cac423a3a2cc5b0513c894d60e63
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/369265
Reviewed-by: Eric Boren <borenet@google.com>