commit 118706a80660177ece10936c3730a6bb804f2358
author John Stiles <johnstiles@google.com> Fri Oct 09 10:07:38 2020 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Fri Oct 09 17:39:33 2020 +0000
tree 9e4cff51d0fc1423ef3831e38b804b8e2abddcd9
parent f52bca10695bb9f639d2d3e4b8eeb11aa8a6a346

Improve codegen for gradients.

Replacing `sk_OutColor = x` with `return x` in single-exit FP functions
results in fewer scratch variables in the final post-inliner output.

Change-Id: I81c081a78d0fb7dfad5230e3044027901673236c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324377
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>

src/gpu/gradients/generated/GrRadialGradientLayout.cpp

diff --git a/src/gpu/gradients/generated/GrRadialGradientLayout.cpp b/src/gpu/gradients/generated/GrRadialGradientLayout.cpp
index fbcd1ac..190d4e8 100644
--- a/src/gpu/gradients/generated/GrRadialGradientLayout.cpp
+++ b/src/gpu/gradients/generated/GrRadialGradientLayout.cpp
@@ -26,9 +26,9 @@
         (void)_outer;
         fragBuilder->codeAppendf(
                 R"SkSL(half t = half(length(%s));
-%s = half4(t, 1.0, 0.0, 0.0);
+return half4(t, 1.0, 0.0, 0.0);
 )SkSL",
-                args.fSampleCoord, args.fOutputColor);
+                args.fSampleCoord);
     }
 
 private:
@@ -45,7 +45,7 @@
     (void)that;
     return true;
 }
-bool GrRadialGradientLayout::usesExplicitReturn() const { return false; }
+bool GrRadialGradientLayout::usesExplicitReturn() const { return true; }
 GrRadialGradientLayout::GrRadialGradientLayout(const GrRadialGradientLayout& src)
         : INHERITED(kGrRadialGradientLayout_ClassID, src.optimizationFlags()) {
     this->cloneAndRegisterAllChildProcessors(src);