| commit | 157577b8663bb812c530188ce9d6b2649c0e57ea | [log] [tgz] |
|---|---|---|
| author | Kevin Lubick <kjlubick@google.com> | Thu Aug 20 10:47:34 2020 -0400 |
| committer | Kevin Lubick <kjlubick@google.com> | Thu Aug 20 14:55:50 2020 +0000 |
| tree | 5ca212be9e41c5996831de346c46b425b6b1d7c9 | |
| parent | 7e9b56317957ab881a42a85af2e48acf3a0c3dd1 [diff] |
[canvaskit,pathkit] Update to emsdk 2.0 There was a break that was solved by adding -lGL to our link steps. I discovered a few extra flags to aid in debugging builds and I've left those in (they aren't too noisy IMO). This changes the base dockerfile to use the official emscripten one. Code size delta for full build is +5 kb For future reference, emsdk decides which "library JS" files to pull in using https://github.com/emscripten-core/emscripten/blob/a83ba99d60a0bedaa5cfaecf22e2ce8c750e0147/tools/building.py#L1553 Those JS files live in src (e.g. https://github.com/emscripten-core/emscripten/blob/a83ba99d60a0bedaa5cfaecf22e2ce8c750e0147/src/library_html5_webgl.js#L222) and define functions that the C++ code can call. I'd like to follow-up on what -lEGL is doing. Also, since the new image no longer has depot_tools, we need to make docker/skia-wasm-release/Dockerfile install it. Change-Id: I5a38e61e5080e9c4cb1e0a7e031509bcb107ff86 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/311726 Reviewed-by: Nathaniel Nifong <nifong@google.com>