| commit | 170de0193f5a731733d3e641a5ac5a3cf0072bcd | [log] [tgz] |
|---|---|---|
| author | Michael Ludwig <michaelludwig@google.com> | Fri Nov 15 21:55:18 2019 +0000 |
| committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Fri Nov 15 21:55:26 2019 +0000 |
| tree | 362991b84e9893a2561765ea3df6504652363440 | |
| parent | aee681de8e4c980064f9a4d4f226d6300f8609f4 [diff] |
Revert "Replace GrTextureDomainEffect with GrDomainEffect." This reverts commit f29caf1433e3185df01b4a286d0fc9715ad32ae2. Reason for revert: Breaks canvas-pattern-no-repeat-with-transformations.html layout test for legit reasons: https://test-results.appspot.com/data/layout_results/linux-blink-rel/22907/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html Original change's description: > Replace GrTextureDomainEffect with GrDomainEffect. > > The new effect takes a child processor rather than a texture proxy. > > In future changes it can implement domains on top of other effects > rather than incorporating the domain into each effect. > > The longer term plan is to remove GrTextureDomain as a helper and just > have GrDomainEffect. That requires rewriting all the effects to take a > child effect. > > Change-Id: Ieaab3a838b7eb4fbf7d8250b8816980645b7cea0 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/252097 > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,brianosman@google.com,ethannicholas@google.com,michaelludwig@google.com Change-Id: I59a594218e1a87e59f20935d5c55726bcb43b1de No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/254986 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>