commit 18ab2030e3be3e2c3a8e3ff5fb5419475831a9ea
author Brian Salomon <bsalomon@google.com> Tue Feb 23 10:07:05 2021 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Tue Feb 23 19:31:01 2021 +0000
tree 1bbc2cc1fcf713bb87f239d6c7edbb4e2e91fbc3
parent 56566c68aaf44f805f027792da8fc2de831ae435

Make GrGLSLFragmentProcessors be created as std::unique_ptr.

Rename factory function from createGLSLInstance() to makeProgramImpl()

Bug: b/180759848
Bug: skia:11358
Change-Id: I095bdf1f26db5a8192fa8ab59000db4a1d561d96
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/373738
Reviewed-by: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>

src/gpu/glsl/GrGLSLProgramBuilder.cpp

diff --git a/src/gpu/glsl/GrGLSLProgramBuilder.cpp b/src/gpu/glsl/GrGLSLProgramBuilder.cpp
index 271bdd7..91e691d 100644
--- a/src/gpu/glsl/GrGLSLProgramBuilder.cpp
+++ b/src/gpu/glsl/GrGLSLProgramBuilder.cpp
@@ -137,7 +137,7 @@
         SkString* inOut = this->pipeline().isColorFragmentProcessor(i) ? color : coverage;
         SkString output;
         const GrFragmentProcessor& fp = this->pipeline().getFragmentProcessor(i);
-        fFragmentProcessors[i] = std::unique_ptr<GrGLSLFragmentProcessor>(fp.createGLSLInstance());
+        fFragmentProcessors[i] = fp.makeProgramImpl();
         output = this->emitFragProc(fp, *fFragmentProcessors[i], transformedCoordVarsIdx, *inOut,
                                     output);
         for (const auto& subFP : GrFragmentProcessor::FPRange(fp)) {