commit 1a0882e7ee9c7929f0079d3b335efb9a664f605b
author Chris Dalton <csmartdalton@google.com> Thu Jun 15 08:51:33 2017 -0600
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Thu Jun 15 15:36:39 2017 +0000
tree 7001eaa028fceae33b98c2fd0ff1d1c520047c8d
parent 58564425e5acb5911cc3719f9c1e39190cc829b8

Fix buffer overflow in SamplePathText

Bug: skia:6764
Change-Id: If0b9dba6e2bbd15ab7d94e271a0c577ca5fcf729
Reviewed-on: https://skia-review.googlesource.com/20021
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>

samplecode/SamplePathText.cpp

diff --git a/samplecode/SamplePathText.cpp b/samplecode/SamplePathText.cpp
index bb2142e..023dc6d 100644
--- a/samplecode/SamplePathText.cpp
+++ b/samplecode/SamplePathText.cpp
@@ -354,11 +354,11 @@
 }
 
 SkPoint WavyPathText::Waves::apply(float tsec, const Sk2f matrix[3], const SkPoint& pt) const {
-    constexpr static int kTableSize = 4096;
+    constexpr static int kTableSize = 1 << 12;
     static float sin2table[kTableSize];
     static SkOnce initTable;
     initTable([]() {
-        for (int i = 0; i <= kTableSize; ++i) {
+        for (int i = 0; i < kTableSize; ++i) {
             const double sintheta = sin(i * (SK_ScalarPI / kTableSize));
             sin2table[i] = static_cast<float>(sintheta * sintheta - 0.5);
         }