Windows-on-ARM testing fixes
- Blacklist the (recently crashing) GLPrograms unit test
- Only test ANGLE ES3 (not ES2) on our Windows-on-ARM bot
With recent changes, ANGLE always returns an ES3 context. They may
reverse that decision, but at the moment there is no actual difference
so the testing is redundant. For this bot in particular, each config
takes upwards of 20 minutes, so this will significantly speed up one of
our slowest bots.
Bug: skia:9275
Change-Id: I04d6e37ae176fab14d7d06c8ebf55d19f9775b53
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229761
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
diff --git a/infra/bots/recipes/test.py b/infra/bots/recipes/test.py
index c7be8aa..669e353 100644
--- a/infra/bots/recipes/test.py
+++ b/infra/bots/recipes/test.py
@@ -192,13 +192,13 @@
'angle_d3d9_es2',
'angle_gl_es2',
'angle_d3d11_es3']
- if 'LenovoYogaC630' in bot:
- # LenovoYogaC630 only supports D3D11, not GL.
- configs = ['angle_d3d11_es2',
- 'angle_d3d11_es3']
if sample_count:
configs.append('angle_d3d11_es2_msaa' + sample_count)
configs.append('angle_d3d11_es3_msaa' + sample_count)
+ if 'LenovoYogaC630' in bot:
+ # LenovoYogaC630 only supports D3D11, and to save time, we only test ES3
+ configs = ['angle_d3d11_es3',
+ 'angle_d3d11_es3_msaa' + sample_count]
if 'GTX' in bot or 'Quadro' in bot:
# See skia:7823 and chromium:693090.
configs.append('angle_gl_es3')
@@ -785,6 +785,8 @@
match.append('~^GrMeshTest$')
if 'LenovoYogaC630' in bot and 'ANGLE' in api.vars.extra_tokens:
+ # skia:9275
+ blacklist(['_', 'tests', '_', 'GLPrograms'])
# skia:8976
blacklist(['_', 'tests', '_', 'GrDefaultPathRendererTest'])
# https://bugs.chromium.org/p/angleproject/issues/detail?id=3414