commit 1c467774e56e591519bfd112e517705dec1e88dc
author Brian Osman <brianosman@google.com> Fri Jul 02 13:11:15 2021 +0000
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Fri Jul 02 13:11:40 2021 +0000
tree 01bc138a24cf083a2d2dc32bac59f79453defeab
parent a149e8ff0503025320aed6db537f1e545e7b92ac

Revert "Convert GrConfigConversionEffect to a runtime FP"

This reverts commit 4a778130080c181dd7fb3df7d7aeb0e35b049f1e.

Reason for revert: Memory regression in Chrome.

Original change's description:
> Convert GrConfigConversionEffect to a runtime FP
>
> Change-Id: I7f22447cf3356b1558d73665ff3e9b61639ebe83
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423576
> Auto-Submit: Brian Osman <brianosman@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>

TBR=bsalomon@google.com,brianosman@google.com,ethannicholas@google.com

Change-Id: I05497295b88b378f0aa236f18118fe676bbf05c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/424256
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>

src/gpu/GrDirectContextPriv.h

diff --git a/src/gpu/GrDirectContextPriv.h b/src/gpu/GrDirectContextPriv.h
index ac17868..fd8f9af 100644
--- a/src/gpu/GrDirectContextPriv.h
+++ b/src/gpu/GrDirectContextPriv.h
@@ -105,7 +105,8 @@
     bool validPMUPMConversionExists();
 
     /**
-     * These functions create premul <-> unpremul effects, using specialized round-trip effects.
+     * These functions create premul <-> unpremul effects, using the specialized round-trip effects
+     * from GrConfigConversionEffect.
      */
     std::unique_ptr<GrFragmentProcessor> createPMToUPMEffect(std::unique_ptr<GrFragmentProcessor>);
     std::unique_ptr<GrFragmentProcessor> createUPMToPMEffect(std::unique_ptr<GrFragmentProcessor>);