commit 23e4544e9442be38bea9678d66f1c76225eb5bb7
author Mike Klein <mtklein@chromium.org> Thu Apr 19 09:29:02 2018 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Thu Apr 19 14:08:14 2018 +0000
tree a06a6bc44265b331ca8346ed71a154f1c8147c15
parent bd000a11c7f95fc58558c2164e7fac5a238bbe8b

disallow negative setReserve() calls

We already assert that setCount()'s argument is non-negative.
This does the same for setReserve().

There was one call site I could find that was actually sometimes
passing negative values to setReserve(), guarded here.

Already reviewed: https://skia-review.googlesource.com/c/skia/+/115982

Change-Id: Ia52a286732bf4056e9baf09555d27bab9abf2554
Reviewed-on: https://skia-review.googlesource.com/122305
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>

src/utils/SkOffsetPolygon.cpp

diff --git a/src/utils/SkOffsetPolygon.cpp b/src/utils/SkOffsetPolygon.cpp
index 94fe965..47b4125 100755
--- a/src/utils/SkOffsetPolygon.cpp
+++ b/src/utils/SkOffsetPolygon.cpp
@@ -347,7 +347,9 @@
     static constexpr SkScalar kCleanupTolerance = 0.01f;
 
     insetPolygon->reset();
-    insetPolygon->setReserve(insetVertexCount);
+    if (insetVertexCount >= 0) {
+        insetPolygon->setReserve(insetVertexCount);
+    }
     currIndex = -1;
     for (int i = 0; i < inputPolygonSize; ++i) {
         if (edgeData[i].fValid && (currIndex == -1 ||