commit 2a3093c154cb937d946d95fbeb0d24e4a1848f02
author Hal Canary <halcanary@google.com> Wed Feb 20 11:25:45 2019 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Wed Mar 06 16:30:56 2019 +0000
tree 0da70ab93cb02186c8cb3146afbb5af9d6da7fd6
parent 0abbaca9a54f0d4623a852e68ac4360c64624f02

SkPDF: Add experimental Harfbuzz font subsetter

Currently hidden behind gn flag:  skia_pdf_subset_harfbuzz

Replaces Sfntly subsetter.

TODO:
  1) Test on all clients.
  2) Enable on each client.
  3) Set skia_pdf_subset_harfbuzz default to true,
  4) Delete sfntly dependency.

Bug: chromium:931719
Change-Id: I5c763ce3e6b21d6bc65284d4105b9974e0907cdc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/171223
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index 3492311..c7df242 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -745,8 +745,10 @@
   }
   sources = skia_pdf_sources
   sources_when_disabled = [ "src/pdf/SkDocument_PDF_None.cpp" ]
-
-  if (skia_use_sfntly) {
+  if (skia_use_icu && skia_use_harfbuzz && skia_pdf_subset_harfbuzz) {
+    deps += [ "//third_party/harfbuzz" ]
+    defines = [ "SK_PDF_USE_HARFBUZZ_SUBSET" ]
+  } else if (skia_use_icu && skia_use_sfntly) {
     deps += [ "//third_party/sfntly" ]
     defines = [ "SK_PDF_USE_SFNTLY" ]
   }