commit 2a4d1e1c1f574e3ee99ae0e3a47ef24f635b9b16
author halcanary <halcanary@google.com> Thu Sep 22 14:13:16 2016 -0700
committer Commit bot <commit-bot@chromium.org> Thu Sep 22 14:13:16 2016 -0700
tree cf23a2e1f6e0c1d83a1418ae8cc01a86cd51c93f
parent d14df7c700bf77c8c42c791ca7a865c1bbc96679

SkPDF: do not assert when openStream return nullptr

BUG=163892
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332813002

Review-Url: https://codereview.chromium.org/2332813002

src/pdf/SkPDFFont.cpp

diff --git a/src/pdf/SkPDFFont.cpp b/src/pdf/SkPDFFont.cpp
index 682f721..db9a177 100644
--- a/src/pdf/SkPDFFont.cpp
+++ b/src/pdf/SkPDFFont.cpp
@@ -368,9 +368,11 @@
     int ttcIndex;
     std::unique_ptr<SkStreamAsset> fontAsset(face->openStream(&ttcIndex));
     size_t fontSize = fontAsset ? fontAsset->getLength() : 0;
-    SkASSERT(fontAsset);
-    SkASSERT(fontSize > 0);
-    if (fontSize > 0) {
+    if (0 == fontSize) {
+        SkDebugf("Error: (SkTypeface)(%p)::openStream() returned "
+                 "empty stream (%p) when identified as kType1CID_Font "
+                 "or kTrueType_Font.\n", face, fontAsset.get());
+    } else {
         switch (type) {
             case SkAdvancedTypefaceMetrics::kTrueType_Font: {
                 #ifdef SK_PDF_USE_SFNTLY