commit 3010f3d791937a1ef6892a906077791cc236f0ec
author Florin Malita <fmalita@chromium.org> Fri Apr 30 10:48:42 2021 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Fri Apr 30 15:41:38 2021 +0000
tree 55ecba82a5a6200bcacbf966a9c2301e97c0d0ce
parent 995f2e6159da3c88cf9bf58a03e5cbae2c62ef54

[svg] Refactor object bounding box access

Introduce a helper (SkSVGRenderContext::obbTransform) and refactor all
obb clients to funnel their calls through it.

This will facilitate some follow up obb changes.

Bug: skia:11936
Change-Id: If0d81b0fc9148389c2cb4bff597057a2afa2fb1b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/402956
Reviewed-by: Tyler Denniston <tdenniston@google.com>
Commit-Queue: Florin Malita <fmalita@google.com>

modules/svg/src/SkSVGFeGaussianBlur.cpp

diff --git a/modules/svg/src/SkSVGFeGaussianBlur.cpp b/modules/svg/src/SkSVGFeGaussianBlur.cpp
index 54ea011..1443845 100644
--- a/modules/svg/src/SkSVGFeGaussianBlur.cpp
+++ b/modules/svg/src/SkSVGFeGaussianBlur.cpp
@@ -20,17 +20,11 @@
 
 sk_sp<SkImageFilter> SkSVGFeGaussianBlur::onMakeImageFilter(const SkSVGRenderContext& ctx,
                                                             const SkSVGFilterContext& fctx) const {
-    SkScalar sigmaX = fStdDeviation.fX;
-    SkScalar sigmaY = fStdDeviation.fY;
-    if (fctx.primitiveUnits().type() == SkSVGObjectBoundingBoxUnits::Type::kObjectBoundingBox) {
-        SkASSERT(ctx.node());
-        const SkRect objBounds = ctx.node()->objectBoundingBox(ctx);
-        sigmaX *= objBounds.width();
-        sigmaY *= objBounds.height();
-    }
+    const auto sigma = SkV2{fStdDeviation.fX, fStdDeviation.fY}
+                     * ctx.transformForCurrentOBB(fctx.primitiveUnits()).scale;
 
     return SkImageFilters::Blur(
-            sigmaX, sigmaY,
+            sigma.x, sigma.y,
             fctx.resolveInput(ctx, this->getIn(), this->resolveColorspace(ctx, fctx)),
             this->resolveFilterSubregion(ctx, fctx));
 }