| commit | 32a71f126f0f8356a1d6e20b5124d21e29948f26 | [log] [tgz] |
|---|---|---|
| author | Herb Derby <herb@google.com> | Wed Jan 30 19:08:52 2019 +0000 |
| committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Wed Jan 30 19:09:03 2019 +0000 |
| tree | b48a04e015b958af3d410f039b2d042d78a2863f | |
| parent | ac262a036830be91cd9d5173de79d6081e3f8e19 [diff] |
Revert "make third_party() static libraries" This reverts commit e738bf11392ce572a8e95e0da34911ee8d8fb792. Reason for revert: Breaks CLION's cmake builds This affects the Clion users Herb and Brian. I talked with Kevin, and he thought we should revert this change. Original change's description: > make third_party() static libraries > > It's sometimes nice to have a libfoo.a to work with. > > I've had to borrow a trick from Chromium's component template [1] to > avoid trying to make static libraries for header or config only targets. > > [1] https://cs.chromium.org/chromium/src/build/config/BUILDCONFIG.gn?rcl=ebf3d7e5827761e1f540cc788bbe301e0f6cc674&l=596 > > Change-Id: I9ec46089c7a4d0a5194ef8ac262dadac10508786 > Reviewed-on: https://skia-review.googlesource.com/c/188024 > Commit-Queue: Mike Klein <mtklein@google.com> > Commit-Queue: Kevin Lubick <kjlubick@google.com> > Reviewed-by: Kevin Lubick <kjlubick@google.com> > Auto-Submit: Mike Klein <mtklein@google.com> TBR=mtklein@google.com,kjlubick@google.com Change-Id: I3fd49b78c0d4e28d805bdc70d8405b1e991cb413 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/188140 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>