commit 32b3089618ab547c0e7c9cc25c25f14c2bee8a6f
author Tyler Denniston <tdenniston@google.com> Tue Jan 26 14:36:32 2021 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Tue Jan 26 21:36:34 2021 +0000
tree 6fb48c2562c3a2c8901bc5047197bf380d31e516
parent 578f1acbe8a47178efb21df49561c365226f9d95

[svg] Add light source classes and lighting-color pres attr

https://www.w3.org/TR/SVG11/filters.html#LightSourceDefinitions

The three classes represent light source elements that will eventually
be used for feSpecularLighting and feDiffuseLighting. Currently they are
unused.

Also added the (currently unused) lighting-color presentation attribute.

Bug: skia:10841
Change-Id: Ic7824671662b8cd88cf627affc54173d5e881b7d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/359557
Commit-Queue: Tyler Denniston <tdenniston@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>

modules/svg/src/SkSVGDOM.cpp

diff --git a/modules/svg/src/SkSVGDOM.cpp b/modules/svg/src/SkSVGDOM.cpp
index 08fea1f..b026e36 100644
--- a/modules/svg/src/SkSVGDOM.cpp
+++ b/modules/svg/src/SkSVGDOM.cpp
@@ -22,6 +22,7 @@
 #include "modules/svg/include/SkSVGFeDisplacementMap.h"
 #include "modules/svg/include/SkSVGFeFlood.h"
 #include "modules/svg/include/SkSVGFeGaussianBlur.h"
+#include "modules/svg/include/SkSVGFeLightSource.h"
 #include "modules/svg/include/SkSVGFeMorphology.h"
 #include "modules/svg/include/SkSVGFeOffset.h"
 #include "modules/svg/include/SkSVGFeTurbulence.h"
@@ -266,11 +267,14 @@
     { "feBlend"          , []() -> sk_sp<SkSVGNode> { return SkSVGFeBlend::Make();           }},
     { "feColorMatrix"    , []() -> sk_sp<SkSVGNode> { return SkSVGFeColorMatrix::Make();     }},
     { "feComposite"      , []() -> sk_sp<SkSVGNode> { return SkSVGFeComposite::Make();       }},
+    { "feDistantLight"   , []() -> sk_sp<SkSVGNode> { return SkSVGFeDistantLight::Make();    }},
     { "feDisplacementMap", []() -> sk_sp<SkSVGNode> { return SkSVGFeDisplacementMap::Make(); }},
     { "feFlood"          , []() -> sk_sp<SkSVGNode> { return SkSVGFeFlood::Make();           }},
     { "feGaussianBlur"   , []() -> sk_sp<SkSVGNode> { return SkSVGFeGaussianBlur::Make();    }},
     { "feMorphology"     , []() -> sk_sp<SkSVGNode> { return SkSVGFeMorphology::Make();      }},
     { "feOffset"         , []() -> sk_sp<SkSVGNode> { return SkSVGFeOffset::Make();          }},
+    { "fePointLight"     , []() -> sk_sp<SkSVGNode> { return SkSVGFePointLight::Make();      }},
+    { "feSpotLight"      , []() -> sk_sp<SkSVGNode> { return SkSVGFeSpotLight::Make();       }},
     { "feTurbulence"     , []() -> sk_sp<SkSVGNode> { return SkSVGFeTurbulence::Make();      }},
     { "filter"           , []() -> sk_sp<SkSVGNode> { return SkSVGFilter::Make();            }},
     { "g"                , []() -> sk_sp<SkSVGNode> { return SkSVGG::Make();                 }},