| commit | 35f55764b81390a085fb90f624082c196fbd6229 | [log] [tgz] |
|---|---|---|
| author | mtklein <mtklein@google.com> | Wed Apr 08 14:09:41 2015 -0700 |
| committer | Commit bot <commit-bot@chromium.org> | Wed Apr 08 14:09:41 2015 -0700 |
| tree | e16cf8961b814300b4c3f02551aff5cd869ffd06 | |
| parent | e2dd9408cd711777afaa9410427fb0d761ab004a [diff] [blame] |
Revert of Rearrange SkRecord with small N in mind (patchset #8 id:120001 of https://codereview.chromium.org/1061783002/) Reason for revert: https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug/builds/149/steps/dm/logs/stdio Original issue's description: > Rearrange SkRecord with small N in mind > > This rearranges the record pointers and types so they can go in a single array, then preallocates some space for them and for the SkVarAlloc. > > picture_overhead_draw bench drops from ~1000ns to 500-600ns, with no effect on picture_overhead_nodraw. > > I don't see any significant effect on large picture recording times from our .skps. > > BUG=chromium:470553 > > Committed: https://skia.googlesource.com/skia/+/e2dd9408cd711777afaa9410427fb0d761ab004a TBR=reed@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:470553 Review URL: https://codereview.chromium.org/1068383003
diff --git a/tests/PictureTest.cpp b/tests/PictureTest.cpp index 2fe6e47..153695b 100644 --- a/tests/PictureTest.cpp +++ b/tests/PictureTest.cpp
@@ -1119,7 +1119,7 @@ // Protect against any unintentional bloat. size_t approxUsed = SkPictureUtils::ApproximateBytesUsed(empty.get()); - REPORTER_ASSERT(reporter, approxUsed <= 416); + REPORTER_ASSERT(reporter, approxUsed <= 136); // Sanity check of nested SkPictures. SkPictureRecorder r2;