commit 36b86aff6b714bd738cd92de726387de420f5486
author Jim Van Verth <jvanverth@google.com> Mon Aug 24 17:16:46 2020 +0000
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Mon Aug 24 17:16:54 2020 +0000
tree 967dce1e567e1f10fb46c2ed902afe84fb24b1c7
parent f759eade0d953916ac0834d618c62efa64401a45

Revert "Remove ARC from Metal backend"

This reverts commit 6541013b536ffb1e74c26462a5af54238244c62b.

Reason for revert: TSAN issues with GrFence, and crash in GrMtlPipelineStateBuilder::CreatePipelineState.

Original change's description:
> Remove ARC from Metal backend
> 
> Change-Id: I5ab28f6eda3b37d1b82c94c7cc6eaa2ce59157da
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/311113
> Reviewed-by: Adlai Holler <adlai@google.com>
> Reviewed-by: John Stiles <johnstiles@google.com>
> Commit-Queue: Jim Van Verth <jvanverth@google.com>

TBR=jvanverth@google.com,bsalomon@google.com,adlai@google.com,johnstiles@google.com

Change-Id: I031629b483fc46de8bd3751253e5391c2ce87853
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312843
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index 88a2c2a..d4dc462 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -791,6 +791,7 @@
     frameworks += [ "Metal.framework" ]
     frameworks += [ "MetalKit.framework" ]
     frameworks += [ "Foundation.framework" ]
+    cflags_objcc += [ "-fobjc-arc" ]
   }
 
   if (is_debug) {
@@ -1593,6 +1594,8 @@
       libs +=
           [ "${fuchsia_sdk_path}/arch/${target_cpu}/sysroot/lib/libzircon.so" ]
     }
+
+    cflags_objcc = [ "-fobjc-arc" ]
   }  # test_lib("gpu_tool_utils")
 
   test_lib("flags") {
@@ -1753,6 +1756,7 @@
     sources = tests_sources + pathops_tests_sources
     if (skia_use_metal) {
       sources += metal_tests_sources
+      cflags_objcc = [ "-fobjc-arc" ]
     }
     if (skia_use_gl) {
       sources += gl_tests_sources