commit 36c1804e8f5ce024ab91522cae8d2db22f359f23
author Chris Dalton <csmartdalton@google.com> Wed Jul 14 02:23:02 2021 -0600
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Wed Jul 14 16:50:48 2021 +0000
tree 602b585cf99a4a2e5742a6c55763359b01a4db48
parent 773a0b8c7e744e1492e118c08ebab314b9e85dd1

Don't disable multisample for GrDashLinePathRenderer

We've concluded that disabling multisample for coverage ops is too
slow. If we decide DashOp is triggering DMSAA too often we can update
the coverage version to be DMSAA compatible.

Bug: skia:11396
Change-Id: I7d23fb391ecd1695ab379ed7cf0b784d5491b7d0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427978
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>

src/gpu/ops/GrDashLinePathRenderer.cpp

diff --git a/src/gpu/ops/GrDashLinePathRenderer.cpp b/src/gpu/ops/GrDashLinePathRenderer.cpp
index 1580ab7..c7d22ee 100644
--- a/src/gpu/ops/GrDashLinePathRenderer.cpp
+++ b/src/gpu/ops/GrDashLinePathRenderer.cpp
@@ -37,16 +37,9 @@
             aaMode = GrDashOp::AAMode::kNone;
             break;
         case GrAAType::kMSAA:
-            if (args.fSurfaceDrawContext->canUseDynamicMSAA() &&
-                args.fContext->priv().caps()->multisampleDisableSupport()) {
-                // The coverage-only mode works as well as MSAA, so try to avoid DMSAA triggers.
-                aaMode = GrDashOp::AAMode::kCoverage;
-            } else {
-                // In this mode we will use aa between dashes but the outer border uses MSAA.
-                // Otherwise, we can wind up with external edges antialiased and internal edges
-                // unantialiased.
-                aaMode = GrDashOp::AAMode::kCoverageWithMSAA;
-            }
+            // In this mode we will use aa between dashes but the outer border uses MSAA. Otherwise,
+            // we can wind up with external edges antialiased and internal edges unantialiased.
+            aaMode = GrDashOp::AAMode::kCoverageWithMSAA;
             break;
         case GrAAType::kCoverage:
             aaMode = GrDashOp::AAMode::kCoverage;