commit 377add74267e5e0c94521858fb1f9ac5cf299667
author reed <reed@google.com> Fri Apr 08 12:47:14 2016 -0700
committer Commit bot <commit-bot@chromium.org> Fri Apr 08 12:47:14 2016 -0700
tree d30129fe90043125775bdc4aabce258dcbdaea1f
parent 0576aa9c0722bba358a27f80cc134ea2cd4ca2c9

Fix race condition in SkROBuffer.

SkBufferBlock::fUsed may be updated by the writer while a reader is
attempting to read it.

BUG=chromium:601578
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1872853002

Review URL: https://codereview.chromium.org/1872853002

tests/DataRefTest.cpp

diff --git a/tests/DataRefTest.cpp b/tests/DataRefTest.cpp
index 03b80fb..002abcb 100644
--- a/tests/DataRefTest.cpp
+++ b/tests/DataRefTest.cpp
@@ -294,11 +294,7 @@
     {
         SkRWBuffer buffer;
         for (int i = 0; i < N; ++i) {
-            if (0 == (i & 1)) {
-                buffer.append(gABC, 26);
-            } else {
-                memcpy(buffer.append(26), gABC, 26);
-            }
+            buffer.append(gABC, 26);
             readers[i] = buffer.newRBufferSnapshot();
             streams[i] = buffer.newStreamSnapshot();
         }